iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #384 from crystal-ameba/fix-issue-383

Browse source 
Fix `Style/VerboseBlock` rule to work with binary operations
This commit is contained in:
Sijawusz Pur Rahnama 2023-06-29 10:20:13 +02:00 • committed by GitHub
commit b7b21ffeb0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
spec/ameba/rule/style/verbose_block_spec.cr
View file

@ -25,6 +25,7 @@ module Ameba::Rule::Style
(1..3).map { |l| l.to_i64 * l.to_i64 } (1..3).map { |l| l.to_i64 * l.to_i64 }
(1..3).map { |m| m.to_s[start: m.to_i64, count: 3]? } (1..3).map { |m| m.to_s[start: m.to_i64, count: 3]? }
(1..3).map { |n| n.to_s.split.map { |z| n.to_i * z.to_i }.join } (1..3).map { |n| n.to_s.split.map { |z| n.to_i * z.to_i }.join }
(1..3).map { |o| o.foo = foos[o.abs]? || 0 }
CRYSTAL CRYSTAL
end end

5
src/ameba/rule/style/verbose_block.cr
View file

@ -99,6 +99,9 @@ module Ameba::Rule::Style
node.named_args.try &.each do |arg| node.named_args.try &.each do |arg|
i += reference_count(arg.value, obj) i += reference_count(arg.value, obj)
end end
when Crystal::BinaryOp
i += reference_count(node.left, obj)
i += reference_count(node.right, obj)
when Crystal::Block when Crystal::Block
i += reference_count(node.body, obj) i += reference_count(node.body, obj)
when Crystal::Var when Crystal::Var
@ -230,7 +233,7 @@ module Ameba::Rule::Style
# we filter out the blocks that are of call type - `i.to_i64.odd?` # we filter out the blocks that are of call type - `i.to_i64.odd?`
return unless (body = block.body).is_a?(Crystal::Call) return unless (body = block.body).is_a?(Crystal::Call)
# we need to "unwind" the chain challs, so the final receiver object # we need to "unwind" the chain calls, so the final receiver object
# ends up being a variable - `i` # ends up being a variable - `i`
obj = body.obj obj = body.obj
while obj.is_a?(Crystal::Call) while obj.is_a?(Crystal::Call)