iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor AST::ScopeVisitor similarly to AST::NodeVisitor

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2022-04-04 01:35:32 +02:00
parent 3f7ade573a
commit a38cfd1661
1 changed files with 23 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

78
src/ameba/ast/visitors/scope_visitor.cr
View file

@ -3,11 +3,28 @@ require "./base_visitor"
module Ameba::AST module Ameba::AST
# AST Visitor that traverses the source and constructs scopes. # AST Visitor that traverses the source and constructs scopes.
class ScopeVisitor < BaseVisitor class ScopeVisitor < BaseVisitor
# Non-exhaustive list of nodes to be visited by Ameba's rules.
NODES = [
ClassDef,
ModuleDef,
EnumDef,
LibDef,
FunDef,
TypeDef,
TypeOf,
CStructOrUnionDef,
ProcLiteral,
Block,
Macro,
MacroFor,
]
SUPER_NODE_NAME = "super" SUPER_NODE_NAME = "super"
RECORD_NODE_NAME = "record" RECORD_NODE_NAME = "record"
@scope_queue = [] of Scope @scope_queue = [] of Scope
@current_scope : Scope @current_scope : Scope
@current_assign : Crystal::ASTNode?
@skip : Array(Crystal::ASTNode.class)? @skip : Array(Crystal::ASTNode.class)?
def initialize(@rule, @source, skip = nil) def initialize(@rule, @source, skip = nil)
@ -39,73 +56,18 @@ module Ameba::AST
on_scope_end(node) if @current_scope.eql?(node) on_scope_end(node) if @current_scope.eql?(node)
end end
{% for name in NODES %}
# :nodoc: # :nodoc:
def visit(node : Crystal::ClassDef) def visit(node : Crystal::{{name}})
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::ModuleDef)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::EnumDef)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::LibDef)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::FunDef)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::TypeDef)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::TypeOf)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::CStructOrUnionDef)
on_scope_enter(node) on_scope_enter(node)
end end
{% end %}
# :nodoc: # :nodoc:
def visit(node : Crystal::Def) def visit(node : Crystal::Def)
node.name == "->" || on_scope_enter(node) node.name == "->" || on_scope_enter(node)
end end
# :nodoc:
def visit(node : Crystal::ProcLiteral)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::Block)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::Macro)
on_scope_enter(node)
end
# :nodoc:
def visit(node : Crystal::MacroFor)
on_scope_enter(node)
end
@current_assign : Crystal::ASTNode?
# :nodoc: # :nodoc:
def visit(node : Crystal::Assign | Crystal::OpAssign | Crystal::MultiAssign | Crystal::UninitializedVar) def visit(node : Crystal::Assign | Crystal::OpAssign | Crystal::MultiAssign | Crystal::UninitializedVar)
@current_assign = node @current_assign = node