iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove rotate from the list of call_names

Browse source 
In some cases it returns `self` and not a copy.
This commit is contained in:
Sijawusz Pur Rahnama 2021-01-22 12:20:50 +01:00
parent 5f6c14c9d6
commit a219a73258
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/ameba/rule/performance/chained_calls_with_no_bang.cr
View file

@ -33,7 +33,6 @@ module Ameba::Rule::Performance
# - sort_by # - sort_by
# - shuffle # - shuffle
# - reverse # - reverse
# - rotate
# ``` # ```
class ChainedCallsWithNoBang < Base class ChainedCallsWithNoBang < Base
properties do properties do
@ -42,7 +41,7 @@ module Ameba::Rule::Performance
# All of those have bang method variants returning `self` # All of those have bang method variants returning `self`
# and are not modifying the receiver type (like `compact` does), # and are not modifying the receiver type (like `compact` does),
# thus are safe to switch to the bang variant. # thus are safe to switch to the bang variant.
call_names : Array(String) = %w(uniq sort sort_by shuffle reverse rotate) call_names : Array(String) = %w(uniq sort sort_by shuffle reverse)
end end
# All these methods are allocating a new object # All these methods are allocating a new object