iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'develop'

Browse source
This commit is contained in:
Vitalii Elenhaupt 2021-04-04 21:19:55 +03:00
commit 9a25214bb5
No known key found for this signature in database
GPG key ID: CD0BF17825928BC0
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec/ameba/rule/style/is_a_filter_spec.cr
View file

@ -47,11 +47,11 @@ module Ameba::Rule::Style
end end
context "macro" do context "macro" do
it "reports in macro scope" do it "doesn't report in macro scope" do
source = Source.new %( source = Source.new %(
{{ [1, 2, nil].reject(&.nil?) }} {{ [1, 2, nil].reject(&.nil?) }}
) )
subject.catch(source).should_not be_valid subject.catch(source).should be_valid
end end
end end

9
src/ameba/rule/style/is_a_filter.cr
View file

@ -46,6 +46,15 @@ module Ameba::Rule::Style
MSG = "Use `%s(%s)` instead of `%s {...}`" MSG = "Use `%s(%s)` instead of `%s {...}`"
def test(source)
AST::NodeVisitor.new self, source, skip: [
Crystal::Macro,
Crystal::MacroExpression,
Crystal::MacroIf,
Crystal::MacroFor,
]
end
def test(source, node : Crystal::Call) def test(source, node : Crystal::Call)
return unless node.name.in?(filter_names) return unless node.name.in?(filter_names)
return unless (block = node.block) return unless (block = node.block)