iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Skip lib definitions altogether

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2024-01-10 01:14:03 +01:00
parent d23ad7f0ab
commit 98d5bc720a
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/ameba/rule/lint/useless_assign_spec.cr
View file

@ -998,6 +998,16 @@ module Ameba::Rule::Lint
CRYSTAL CRYSTAL
end end
it "doesn't report if it's referenced in a lib" do
expect_no_issues subject, <<-CRYSTAL
lib LibFoo
struct Foo
a : Int32
end
end
CRYSTAL
end
it "doesn't report if it's referenced" do it "doesn't report if it's referenced" do
expect_no_issues subject, <<-CRYSTAL expect_no_issues subject, <<-CRYSTAL
def foo def foo

2
src/ameba/rule/lint/useless_assign.cr
View file

@ -39,6 +39,8 @@ module Ameba::Rule::Lint
end end
def test(source, node, scope : AST::Scope) def test(source, node, scope : AST::Scope)
return if scope.lib_def?(check_outer_scopes: true)
scope.variables.each do |var| scope.variables.each do |var|
next if var.ignored? || var.used_in_macro? || var.captured_by_block? next if var.ignored? || var.used_in_macro? || var.captured_by_block?
next if exclude_type_declarations? && scope.assigns_type_dec?(var.name) next if exclude_type_declarations? && scope.assigns_type_dec?(var.name)