Track issue.end_location properly

2024-08-15 00:53:29 +00:00 · 2018-11-24 19:38:13 +02:00 · 2018-11-24 19:38:13 +02:00 · 9885457227
commit 9885457227
parent ad2c6bad0e
45 changed files with 90 additions and 20 deletions
--- a/spec/ameba/rule/layout/line_length_spec.cr
+++ b/spec/ameba/rule/layout/line_length_spec.cr
@ -27,6 +27,7 @@ module Ameba::Rule::Layout
      issue = source.issues.first
      issue.rule.should eq subject
      issue.location.to_s.should eq "source.cr:1:#{subject.max_length + 1}"
+      issue.end_location.should be_nil
      issue.message.should eq "Line too long"
    end

--- a/spec/ameba/rule/layout/trailing_blank_lines_spec.cr
+++ b/spec/ameba/rule/layout/trailing_blank_lines_spec.cr
@ -31,6 +31,7 @@ module Ameba::Rule::Layout
      issue = source.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:3:1"
+      issue.end_location.should be_nil
      issue.message.should eq "Blank lines detected at the end of the file"
    end
  end
--- a/spec/ameba/rule/layout/trailing_whitespace_spec.cr
+++ b/spec/ameba/rule/layout/trailing_whitespace_spec.cr
@ -21,6 +21,7 @@ module Ameba::Rule::Layout
      issue = source.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:7"
+      issue.end_location.should be_nil
      issue.message.should eq "Trailing whitespace detected"
    end
  end
--- a/spec/ameba/rule/lint/comparison_to_boolean_spec.cr
+++ b/spec/ameba/rule/lint/comparison_to_boolean_spec.cr
@ -106,6 +106,7 @@ module Ameba::Rule::Lint
        issue = source.issues.first
        issue.rule.should_not be_nil
        issue.location.to_s.should eq "source.cr:1:1"
+        issue.end_location.to_s.should eq "source.cr:1:9"
        issue.message.should eq "Comparison to a boolean is pointless"
      end
    end
--- a/spec/ameba/rule/lint/debugger_statement_spec.cr
+++ b/spec/ameba/rule/lint/debugger_statement_spec.cr
@ -38,6 +38,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:8"
      issue.message.should eq "Possible forgotten debugger statement detected"
    end
  end
--- a/spec/ameba/rule/lint/empty_ensure_spec.cr
+++ b/spec/ameba/rule/lint/empty_ensure_spec.cr
@ -62,6 +62,7 @@ module Ameba::Rule::Lint

      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:3"
+      issue.end_location.to_s.should eq "source.cr:6:3"
      issue.message.should eq "Empty `ensure` block detected"
    end
  end
--- a/spec/ameba/rule/lint/empty_expression_spec.cr
+++ b/spec/ameba/rule/lint/empty_expression_spec.cr
@ -104,6 +104,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:4"
+      issue.end_location.to_s.should eq "source.cr:1:5"
      issue.message.should eq "Avoid empty expressions"
    end
  end
--- a/spec/ameba/rule/lint/hash_duplicated_key_spec.cr
+++ b/spec/ameba/rule/lint/hash_duplicated_key_spec.cr
@ -35,6 +35,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:5"
+      issue.end_location.to_s.should eq "source.cr:1:24"
      issue.message.should eq %(Duplicated keys in hash literal: "a")
    end

--- a/spec/ameba/rule/lint/literal_in_condition_spec.cr
+++ b/spec/ameba/rule/lint/literal_in_condition_spec.cr
@ -66,6 +66,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:20"
      issue.message.should eq "Literal value found in conditional"
    end
  end
--- a/spec/ameba/rule/lint/literal_in_interpolation_spec.cr
+++ b/spec/ameba/rule/lint/literal_in_interpolation_spec.cr
@ -35,6 +35,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:6"
      issue.message.should eq "Literal value found in interpolation"
    end
  end
--- a/spec/ameba/rule/lint/percent_arrays_spec.cr
+++ b/spec/ameba/rule/lint/percent_arrays_spec.cr
@ -61,6 +61,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.should be_nil
      issue.message.should eq(
        "Symbols `,\"` may be unwanted in %w array literals"
      )
--- a/spec/ameba/rule/lint/rand_zero_spec.cr
+++ b/spec/ameba/rule/lint/rand_zero_spec.cr
@ -30,6 +30,7 @@ module Ameba::Rule::Lint

      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:7"
      issue.message.should eq "rand(1) always returns 0"
    end
  end
--- a/spec/ameba/rule/lint/shadowed_argument_spec.cr
+++ b/spec/ameba/rule/lint/shadowed_argument_spec.cr
@ -159,6 +159,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:3"
+      issue.end_location.to_s.should eq "source.cr:2:10"
      issue.message.should eq "Argument `bar` is assigned before it is used"
    end
  end
--- a/spec/ameba/rule/lint/shadowed_exception_spec.cr
+++ b/spec/ameba/rule/lint/shadowed_exception_spec.cr
@ -167,6 +167,7 @@ module Ameba::Rule::Lint

      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:3"
+      issue.end_location.to_s.should eq "source.cr:4:3"
      issue.message.should eq(
        "Exception handler has shadowed exceptions: IndexError"
      )
--- a/spec/ameba/rule/lint/shadowing_local_outer_var_spec.cr
+++ b/spec/ameba/rule/lint/shadowing_local_outer_var_spec.cr
@ -161,6 +161,7 @@ module Ameba::Rule::Lint
      issue = source.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:12"
+      issue.end_location.should be_nil
      issue.message.should eq "Shadowing outer local variable `foo`"
    end
  end
--- a/spec/ameba/rule/lint/unreachable_code_spec.cr
+++ b/spec/ameba/rule/lint/unreachable_code_spec.cr
@ -682,5 +682,20 @@ module Ameba::Rule::Lint
        subject.catch(s).should be_valid
      end
    end
+
+    it "reports message, rule, location" do
+      s = Source.new %(
+        return
+        :unreachable
+      ), "source.cr"
+
+      subject.catch(s).should_not be_valid
+
+      issue = s.issues.first
+      issue.rule.should_not be_nil
+      issue.location.to_s.should eq "source.cr:2:1"
+      issue.end_location.to_s.should eq "source.cr:2:12"
+      issue.message.should eq "Unreachable code detected"
+    end
  end
 end
--- a/spec/ameba/rule/lint/useless_condition_in_when_spec.cr
+++ b/spec/ameba/rule/lint/useless_condition_in_when_spec.cr
@ -39,6 +39,7 @@ module Ameba::Rule::Lint
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:5:15"
+      issue.end_location.to_s.should eq "source.cr:5:27"
      issue.message.should eq "Useless condition in when detected"
    end
  end
--- a/spec/ameba/rule/style/constant_names_spec.cr
+++ b/spec/ameba/rule/style/constant_names_spec.cr
@ -43,6 +43,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:9"
      issue.message.should eq(
        "Constant name should be screaming-cased: CONST, not Const"
      )
--- a/spec/ameba/rule/style/large_numbers_spec.cr
+++ b/spec/ameba/rule/style/large_numbers_spec.cr
@ -118,6 +118,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.should be_nil
      issue.message.should match /1_200_000/
    end

--- a/spec/ameba/rule/style/method_names_spec.cr
+++ b/spec/ameba/rule/style/method_names_spec.cr
@ -47,6 +47,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:2:3"
      issue.message.should eq(
        "Method name should be underscore-cased: bad_name, not bad_Name"
      )
--- a/spec/ameba/rule/style/negated_conditions_in_unless_spec.cr
+++ b/spec/ameba/rule/style/negated_conditions_in_unless_spec.cr
@ -62,6 +62,7 @@ module Ameba::Rule::Style
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:21"
      issue.message.should eq "Avoid negated conditions in unless blocks"
    end
  end
--- a/spec/ameba/rule/style/predicate_name_spec.cr
+++ b/spec/ameba/rule/style/predicate_name_spec.cr
@ -41,6 +41,7 @@ module Ameba::Rule::Style
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:2:3"
+      issue.end_location.to_s.should eq "source.cr:4:5"
      issue.message.should eq(
        "Favour method name 'picture?' over 'has_picture?'")
    end
--- a/spec/ameba/rule/style/redundant_begin_spec.cr
+++ b/spec/ameba/rule/style/redundant_begin_spec.cr
@ -220,6 +220,7 @@ module Ameba::Rule::Style
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:7:3"
      issue.message.should eq "Redundant `begin` block detected"
    end
  end
--- a/spec/ameba/rule/style/type_names_spec.cr
+++ b/spec/ameba/rule/style/type_names_spec.cr
@ -52,6 +52,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:2:3"
      issue.message.should eq(
        "Type name should be camelcased: MyClass, but it was My_class"
      )
--- a/spec/ameba/rule/style/unless_else_spec.cr
+++ b/spec/ameba/rule/style/unless_else_spec.cr
@ -38,6 +38,7 @@ module Ameba::Rule::Style
      issue.should_not be_nil
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:5:3"
      issue.message.should eq "Favour if over unless with else"
    end
  end
--- a/spec/ameba/rule/style/variable_names_spec.cr
+++ b/spec/ameba/rule/style/variable_names_spec.cr
@ -53,6 +53,7 @@ module Ameba
      issue = s.issues.first
      issue.rule.should_not be_nil
      issue.location.to_s.should eq "source.cr:1:1"
+      issue.end_location.to_s.should eq "source.cr:1:7"
      issue.message.should eq(
        "Var name should be underscore-cased: bad_name, not badName"
      )
--- a/spec/ameba/rule/style/while_true_spec.cr
+++ b/spec/ameba/rule/style/while_true_spec.cr
@ -36,6 +36,7 @@ module Ameba::Rule::Style

      issue = source.issues.first
      issue.location.to_s.should eq "source.cr:2:1"
+      issue.end_location.to_s.should eq "source.cr:5:3"
      issue.message.should eq "While statement using true literal as condition"
    end
  end