iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Track issue.end_location properly

Browse source
This commit is contained in:
Vitalii Elenhaupt 2018-11-24 19:38:13 +02:00
parent ad2c6bad0e
commit 9885457227
No known key found for this signature in database
GPG key ID: 7558EF3A4056C706
45 changed files with 90 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

3
spec/ameba/ast/branch_spec.cr
View file

@ -323,7 +323,7 @@ module Ameba::AST
branch.to_s.should eq branch.node.to_s
end
it "delegates location to node" do
it "delegates locations to node" do
nodes = as_nodes %(
if true
a = 2
@ -332,6 +332,7 @@ module Ameba::AST
branchable = Branchable.new nodes.if_nodes.first
branch = Branch.new nodes.assign_nodes.first, branchable
branch.location.should eq branch.node.location
branch.end_location.should eq branch.node.end_location
end
end

3
spec/ameba/ast/branchable_spec.cr
View file

@ -16,10 +16,11 @@ module Ameba::AST
branchable.to_s.should eq node.to_s
end
it "delegates location to @node" do
it "delegates locations to @node" do
node = as_node %(a = 2 if true)
branchable = Branchable.new node
branchable.location.should eq node.location
branchable.end_location.should eq node.end_location
end
end

3
spec/ameba/ast/flow_expression_spec.cr
View file

@ -17,10 +17,11 @@ module Ameba::AST
flow_expression.to_s.should eq node.to_s
end
it "delegates location to @node" do
it "delegates locations to @node" do
node = as_node %(break if true)
flow_expression = FlowExpression.new node, false
flow_expression.location.should eq node.location
flow_expression.end_location.should eq node.end_location
end
end

15
spec/ameba/ast/scope_spec.cr
View file

@ -18,6 +18,21 @@ module Ameba::AST
end
end
describe "delegation" do
it "delegates to_s to node" do
node = as_node("def foo; end")
scope = Scope.new node
scope.to_s.should eq node.to_s
end
it "delegates locations to node" do
node = as_node("def foo; end")
scope = Scope.new node
scope.location.should eq node.location
scope.end_location.should eq node.end_location
end
end
describe "#add_variable" do
it "adds a new variable to the scope" do
scope = Scope.new as_node("")

3
spec/ameba/ast/variabling/argument_spec.cr
View file

@ -14,9 +14,10 @@ module Ameba::AST
end
describe "delegation" do
it "delegates location to node" do
it "delegates locations to node" do
argument = Argument.new(arg, variable)
argument.location.should eq arg.location
argument.end_location.should eq arg.end_location
end
it "delegates to_s to node" do

3
spec/ameba/ast/variabling/assignment_spec.cr
View file

@ -22,9 +22,10 @@ module Ameba::AST
end
describe "delegation" do
it "delegates location" do
it "delegates locations" do
assignment = Assignment.new(node, variable)
assignment.location.should eq node.location
assignment.end_location.should eq node.end_location
end
it "delegates to_s" do

3
spec/ameba/ast/variabling/variable_spec.cr
View file

@ -13,9 +13,10 @@ module Ameba::AST
end
describe "delegation" do
it "delegates location" do
it "delegates locations" do
variable = Variable.new(var_node, scope)
variable.location.should eq var_node.location
variable.end_location.should eq var_node.end_location
end
it "delegates name" do

1
spec/ameba/rule/layout/line_length_spec.cr
View file

@ -27,6 +27,7 @@ module Ameba::Rule::Layout
issue = source.issues.first
issue.rule.should eq subject
issue.location.to_s.should eq "source.cr:1:#{subject.max_length + 1}"
issue.end_location.should be_nil
issue.message.should eq "Line too long"
end

1
spec/ameba/rule/layout/trailing_blank_lines_spec.cr
View file

@ -31,6 +31,7 @@ module Ameba::Rule::Layout
issue = source.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:3:1"
issue.end_location.should be_nil
issue.message.should eq "Blank lines detected at the end of the file"
end
end

1
spec/ameba/rule/layout/trailing_whitespace_spec.cr
View file

@ -21,6 +21,7 @@ module Ameba::Rule::Layout
issue = source.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:7"
issue.end_location.should be_nil
issue.message.should eq "Trailing whitespace detected"
end
end

1
spec/ameba/rule/lint/comparison_to_boolean_spec.cr
View file

@ -106,6 +106,7 @@ module Ameba::Rule::Lint
issue = source.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:9"
issue.message.should eq "Comparison to a boolean is pointless"
end
end

1
spec/ameba/rule/lint/debugger_statement_spec.cr
View file

@ -38,6 +38,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:8"
issue.message.should eq "Possible forgotten debugger statement detected"
end
end

1
spec/ameba/rule/lint/empty_ensure_spec.cr
View file

@ -62,6 +62,7 @@ module Ameba::Rule::Lint
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:6:3"
issue.message.should eq "Empty `ensure` block detected"
end
end

1
spec/ameba/rule/lint/empty_expression_spec.cr
View file

@ -104,6 +104,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:4"
issue.end_location.to_s.should eq "source.cr:1:5"
issue.message.should eq "Avoid empty expressions"
end
end

1
spec/ameba/rule/lint/hash_duplicated_key_spec.cr
View file

@ -35,6 +35,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:5"
issue.end_location.to_s.should eq "source.cr:1:24"
issue.message.should eq %(Duplicated keys in hash literal: "a")
end

1
spec/ameba/rule/lint/literal_in_condition_spec.cr
View file

@ -66,6 +66,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:20"
issue.message.should eq "Literal value found in conditional"
end
end

1
spec/ameba/rule/lint/literal_in_interpolation_spec.cr
View file

@ -35,6 +35,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:6"
issue.message.should eq "Literal value found in interpolation"
end
end

1
spec/ameba/rule/lint/percent_arrays_spec.cr
View file

@ -61,6 +61,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.should be_nil
issue.message.should eq(
"Symbols `,\"` may be unwanted in %w array literals"
)

1
spec/ameba/rule/lint/rand_zero_spec.cr
View file

@ -30,6 +30,7 @@ module Ameba::Rule::Lint
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:7"
issue.message.should eq "rand(1) always returns 0"
end
end

1
spec/ameba/rule/lint/shadowed_argument_spec.cr
View file

@ -159,6 +159,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:2:10"
issue.message.should eq "Argument `bar` is assigned before it is used"
end
end

1
spec/ameba/rule/lint/shadowed_exception_spec.cr
View file

@ -167,6 +167,7 @@ module Ameba::Rule::Lint
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:4:3"
issue.message.should eq(
"Exception handler has shadowed exceptions: IndexError"
)

1
spec/ameba/rule/lint/shadowing_local_outer_var_spec.cr
View file

@ -161,6 +161,7 @@ module Ameba::Rule::Lint
issue = source.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:12"
issue.end_location.should be_nil
issue.message.should eq "Shadowing outer local variable `foo`"
end
end

15
spec/ameba/rule/lint/unreachable_code_spec.cr
View file

@ -682,5 +682,20 @@ module Ameba::Rule::Lint
subject.catch(s).should be_valid
end
end
it "reports message, rule, location" do
s = Source.new %(
return
:unreachable
), "source.cr"
subject.catch(s).should_not be_valid
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:1"
issue.end_location.to_s.should eq "source.cr:2:12"
issue.message.should eq "Unreachable code detected"
end
end
end

1
spec/ameba/rule/lint/useless_condition_in_when_spec.cr
View file

@ -39,6 +39,7 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:5:15"
issue.end_location.to_s.should eq "source.cr:5:27"
issue.message.should eq "Useless condition in when detected"
end
end

1
spec/ameba/rule/style/constant_names_spec.cr
View file

@ -43,6 +43,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:9"
issue.message.should eq(
"Constant name should be screaming-cased: CONST, not Const"
)

1
spec/ameba/rule/style/large_numbers_spec.cr
View file

@ -118,6 +118,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.should be_nil
issue.message.should match /1_200_000/
end

1
spec/ameba/rule/style/method_names_spec.cr
View file

@ -47,6 +47,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:2:3"
issue.message.should eq(
"Method name should be underscore-cased: bad_name, not bad_Name"
)

1
spec/ameba/rule/style/negated_conditions_in_unless_spec.cr
View file

@ -62,6 +62,7 @@ module Ameba::Rule::Style
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:21"
issue.message.should eq "Avoid negated conditions in unless blocks"
end
end

1
spec/ameba/rule/style/predicate_name_spec.cr
View file

@ -41,6 +41,7 @@ module Ameba::Rule::Style
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:4:5"
issue.message.should eq(
"Favour method name 'picture?' over 'has_picture?'")
end

1
spec/ameba/rule/style/redundant_begin_spec.cr
View file

@ -220,6 +220,7 @@ module Ameba::Rule::Style
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:7:3"
issue.message.should eq "Redundant `begin` block detected"
end
end

1
spec/ameba/rule/style/type_names_spec.cr
View file

@ -52,6 +52,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:2:3"
issue.message.should eq(
"Type name should be camelcased: MyClass, but it was My_class"
)

1
spec/ameba/rule/style/unless_else_spec.cr
View file

@ -38,6 +38,7 @@ module Ameba::Rule::Style
issue.should_not be_nil
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:5:3"
issue.message.should eq "Favour if over unless with else"
end
end

1
spec/ameba/rule/style/variable_names_spec.cr
View file

@ -53,6 +53,7 @@ module Ameba
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
issue.end_location.to_s.should eq "source.cr:1:7"
issue.message.should eq(
"Var name should be underscore-cased: bad_name, not badName"
)

1
spec/ameba/rule/style/while_true_spec.cr
View file

@ -36,6 +36,7 @@ module Ameba::Rule::Style
issue = source.issues.first
issue.location.to_s.should eq "source.cr:2:1"
issue.end_location.to_s.should eq "source.cr:5:3"
issue.message.should eq "While statement using true literal as condition"
end
end