iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Refactor ternary handling in Style/RedundantParentheses rule

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2022-11-15 00:46:21 +01:00
parent 3340613a6a
commit 935296b041
2 changed files with 30 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

16
spec/ameba/rule/style/redundant_parentheses_spec.cr
View file

@ -55,16 +55,22 @@ module Ameba::Rule::Style
rule.exclude_ternary = false
expect_issue rule, <<-CRYSTAL
(foo > bar) ? true : false
# ^^^^^^^^^ error: Redundant parentheses
(foo.empty?) ? true : false
# ^^^^^^^^^^ error: Redundant parentheses
CRYSTAL
expect_no_issues subject, <<-CRYSTAL
(foo && bar) ? true : false
CRYSTAL
expect_no_issues subject, <<-CRYSTAL
(foo || bar) ? true : false
(foo = @foo) ? true : false
foo == 42 ? true : false
(foo = 42) ? true : false
(foo > 42) ? true : false
(foo >= 42) ? true : false
(3 >= foo >= 42) ? true : false
(3.in? 0..42) ? true : false
(yield 42) ? true : false
(foo rescue 42) ? true : false
CRYSTAL
end
end