iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #199 from crystal-ameba/Sija/rename-chained-calls-with-no-bang

Browse source 
ChainedCallsWithNoBang -> ChainedCallWithNoBang
This commit is contained in:
Sijawusz Pur Rahnama 2021-01-22 22:48:57 +01:00 committed by GitHub
commit 8b52dc4b1d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/ameba/rule/performance/chained_calls_with_no_bang_spec.cr → spec/ameba/rule/performance/chained_call_with_no_bang_spec.cr
View file

@ -1,9 +1,9 @@
require "../../../spec_helper" require "../../../spec_helper"
module Ameba::Rule::Performance module Ameba::Rule::Performance
subject = ChainedCallsWithNoBang.new subject = ChainedCallWithNoBang.new
describe ChainedCallsWithNoBang do describe ChainedCallWithNoBang do
it "passes if there is no potential performance improvements" do it "passes if there is no potential performance improvements" do
source = Source.new %( source = Source.new %(
(1..3).select { |e| e > 1 }.sort! (1..3).select { |e| e > 1 }.sort!
@ -35,7 +35,7 @@ module Ameba::Rule::Performance
source = Source.new %( source = Source.new %(
[1, 2, 3].select { |e| e > 2 }.reverse [1, 2, 3].select { |e| e > 2 }.reverse
) )
rule = ChainedCallsWithNoBang.new rule = ChainedCallWithNoBang.new
rule.call_names = %w(uniq) rule.call_names = %w(uniq)
rule.catch(source).should be_valid rule.catch(source).should be_valid
end end

4
src/ameba/rule/performance/chained_calls_with_no_bang.cr → src/ameba/rule/performance/chained_call_with_no_bang.cr
View file

@ -25,7 +25,7 @@ module Ameba::Rule::Performance
# YAML configuration example: # YAML configuration example:
# #
# ``` # ```
# Performance/ChainedCallsWithNoBang # Performance/ChainedCallWithNoBang
# Enabled: true # Enabled: true
# CallNames: # CallNames:
# - uniq # - uniq
@ -34,7 +34,7 @@ module Ameba::Rule::Performance
# - shuffle # - shuffle
# - reverse # - reverse
# ``` # ```
class ChainedCallsWithNoBang < Base class ChainedCallWithNoBang < Base
properties do properties do
description "Identifies usage of chained calls not utilizing the bang method variants." description "Identifies usage of chained calls not utilizing the bang method variants."