+

+ + class Ameba::Rule::Lint::NotNilAfterNoBang + +

+ + + + + + + +

+ + + + Overview +

+ +

This rule is used to identify usage of index/find calls followed by not_nil!.

+

For example, this is considered a code smell:

+
%w[Alice Bob].find(&.match(/^A./)).not_nil!
+

And can be written as this:

+
%w[Alice Bob].find!(&.match(/^A./))
+

YAML configuration example:

+
Lint/NotNilAfterNoBang:
+  Enabled: true
+ + + + + +

+ + + + Included Modules +

+
    + +
  • Ameba::AST::Util
    • + +
  • YAML::Serializable
    • + +
  • YAML::Serializable::Strict
    • + +
+ + + + + + + + + + +

+ + + + Defined in: +

+ + + + ameba/rule/lint/not_nil_after_no_bang.cr + + +
+ + + + + +

+ + + + Constant Summary +

+ +
+ +
+ BLOCK_CALL_NAMES = ["index", "find"] of ::String +
+ + +
+ CALL_NAMES = ["index"] of ::String +
+ + +
+ MSG = "Use `%s! {...}` instead of `%s {...}.not_nil!`" +
+ + +
+ NOT_NIL_NAME = "not_nil!" +
+ + +
+ + + +

+ + + + Constructors +

+ + + + +

+ + + + Class Method Summary +

+ + + + +

+ + + + Instance Method Summary +

+ + + + + + +
+ + + +

Instance methods inherited from module Ameba::AST::Util

+ + + + abort?(node) + abort?, + + + + control_exp_code(node : Crystal::ControlExpression, code_lines) + control_exp_code, + + + + exit?(node) + exit?, + + + + flow_command?(node, in_loop) + flow_command?, + + + + flow_expression?(node, in_loop = false) + flow_expression?, + + + + literal?(node) + literal?, + + + + loop?(node) + loop?, + + + + name_end_location(node) + name_end_location, + + + + name_location(node) + name_location, + + + + name_size(node) + name_size, + + + + node_source(node, code_lines) + node_source, + + + + raise?(node) + raise?, + + + + source_between(loc, end_loc, code_lines) : String? + source_between + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +

Instance methods inherited from class Ameba::Rule::Base

+ + + + ==(other) + ==, + + + + catch(source : Source) + catch, + + + + excluded?(source) + excluded?, + + + + group + group, + + + + hash + hash, + + + + name + name, + + + + special? + special?, + + + + test(source : Source, node : Crystal::ASTNode, *opts)
test(source : Source) + test + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +
+ + +

+ + + + Constructor Detail +

+ +
+
+ + def self.new(ctx : YAML::ParseContext, node : YAML::Nodes::Node) + + # +
+ +
+
+ +
+
+ +
+
+ + def self.new(config = nil) + + # +
+ +
+ +

This rule is used to identify usage of index/find calls followed by not_nil!.

+

For example, this is considered a code smell:

+
%w[Alice Bob].find(&.match(/^A./)).not_nil!
+

And can be written as this:

+
%w[Alice Bob].find!(&.match(/^A./))
+

YAML configuration example:

+
Lint/NotNilAfterNoBang:
+  Enabled: true
+
+ +
+
+ + [View source] + +
+
+ + + + +

+ + + + Class Method Detail +

+ +
+
+ + def self.parsed_doc : String? + + # +
+ +
+ +

Returns documentation for this rule, if there is any.

+
module Ameba
+  # This is a test rule.
+  # Does nothing.
+  class MyRule < Ameba::Rule::Base
+    def test(source)
+    end
+  end
+end
+
+MyRule.parsed_doc # => "This is a test rule.\nDoes nothing."
+
+ +
+
+ +
+
+ + + + +

+ + + + Instance Method Detail +

+ +
+
+ + def description : String + + # +
+ +
+
+ +
+
+ +
+
+ + def description=(description : String) + + # +
+ +
+
+ +
+
+ +
+
+ + def enabled : Bool + + # +
+ +
+
+ +
+
+ +
+
+ + def enabled=(enabled : Bool) + + # +
+ +
+
+ +
+
+ +
+
+ + def excluded : Array(String)? + + # +
+ +
+
+ +
+
+ +
+
+ + def excluded=(excluded : Array(String)?) + + # +
+ +
+
+ +
+
+ +
+
+ + def severity : Ameba::Severity + + # +
+ +
+
+ +
+
+ +
+
+ + def severity=(severity : Ameba::Severity) + + # +
+ +
+
+ +
+
+ +
+
+ + def test(source, node : Crystal::Call) + + # +
+ +
+
+ + [View source] + +
+
+ +
+
+ + def test(source) + + # +
+ +
+
+ + [View source] + +
+
+ + + + + +