iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #438 from crystal-ameba/add-error-as-allowed-variable-name

Browse source 
Add `error` to the `RescuedExceptionsVariableName#allowed_names`
This commit is contained in:
Sijawusz Pur Rahnama 2023-12-28 14:32:45 +01:00 committed by GitHub
commit 46a42ee9e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/ameba/rule/naming/rescued_exceptions_variable_name_spec.cr
View file

@ -21,7 +21,7 @@ module Ameba::Rule::Naming
def foo def foo
raise "foo" raise "foo"
rescue wtf rescue wtf
# ^^^^^^^^ error: Disallowed variable name, use one of these instead: 'e', 'ex', 'exception' # ^^^^^^^^ error: Disallowed variable name, use one of these instead: 'e', 'ex', 'exception', 'error'
nil nil
end end
CRYSTAL CRYSTAL
@ -31,7 +31,7 @@ module Ameba::Rule::Naming
context "#allowed_names" do context "#allowed_names" do
it "returns sensible defaults" do it "returns sensible defaults" do
rule = RescuedExceptionsVariableName.new rule = RescuedExceptionsVariableName.new
rule.allowed_names.should eq %w[e ex exception] rule.allowed_names.should eq %w[e ex exception error]
end end
it "allows setting custom names" do it "allows setting custom names" do

4
src/ameba/rule/naming/rescued_exceptions_variable_name.cr
View file

@ -22,12 +22,12 @@ module Ameba::Rule::Naming
# ``` # ```
# Naming/RescuedExceptionsVariableName: # Naming/RescuedExceptionsVariableName:
# Enabled: true # Enabled: true
# AllowedNames: [e, ex, exception] # AllowedNames: [e, ex, exception, error]
# ``` # ```
class RescuedExceptionsVariableName < Base class RescuedExceptionsVariableName < Base
properties do properties do
description "Makes sure that rescued exceptions variables are named as expected" description "Makes sure that rescued exceptions variables are named as expected"
allowed_names %w[e ex exception] allowed_names %w[e ex exception error]
end end
MSG = "Disallowed variable name, use one of these instead: '%s'" MSG = "Disallowed variable name, use one of these instead: '%s'"