iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Do not report shadowing outer local var is var is declared below the

Browse source 
shadowed var

closes #144
This commit is contained in:
Vitalii Elenhaupt 2020-04-08 12:21:06 +03:00
parent 99c65b5a28
commit 458c492730
No known key found for this signature in database
GPG key ID: CD0BF17825928BC0
5 changed files with 80 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
spec/ameba/rule/lint/shadowing_local_outer_var_spec.cr
View file

@ -34,6 +34,14 @@ module Ameba::Rule::Lint
subject.catch(source).should_not be_valid
end
it "does not report outer vars declared below shadowed block" do
source = Source.new %(
methods = klass.methods.select { |m| m.annotation(MyAnn) }
m = methods.last
)
subject.catch(source).should be_valid
end
it "reports if there is a shadowing in a proc" do
source = Source.new %(
def some_method
@ -176,7 +184,7 @@ module Ameba::Rule::Lint
end
context "macro" do
it "does not report shadowed vars A" do
it "does not report shadowed vars in outer scope" do
source = Source.new %(
macro included
def foo
@ -192,6 +200,19 @@ module Ameba::Rule::Lint
)
subject.catch(source).should be_valid
end
it "does not report shadowed vars in macro withing the same scope" do
source = Source.new %(
{% methods = klass.methods.select { |m| m.annotation(MyAnn) } %}
{% for m, m_idx in methods %}
{% if d = m.annotation(MyAnn) %}
{% d %}
{% end %}
{% end %}
)
subject.catch(source).should be_valid
end
end
end
end