Do not report shadowing outer local var is var is declared below the

shadowed var

closes #144
This commit is contained in:
Vitalii Elenhaupt 2020-04-08 12:21:06 +03:00
parent 99c65b5a28
commit 458c492730
No known key found for this signature in database
GPG key ID: CD0BF17825928BC0
5 changed files with 80 additions and 8 deletions

View file

@ -160,5 +160,42 @@ module Ameba::AST
variable.eql?(variable.node).should be_true
end
end
describe "#declared_before?" do
it "is falsey if variable doesn't have location" do
var1 = Crystal::Var.new("foo")
var2 = Crystal::Var.new("bar").at(Crystal::Location.new(nil, 1, 2))
Variable.new(var1, scope).declared_before?(var2).should be_falsey
end
it "is falsey if node doesn't have location" do
var1 = Crystal::Var.new("foo").at(Crystal::Location.new(nil, 1, 2))
var2 = Crystal::Var.new("bar")
Variable.new(var1, scope).declared_before?(var2).should be_falsey
end
it "is true if var's line_number below the node" do
var1 = Crystal::Var.new("foo").at(Crystal::Location.new(nil, 1, 2))
var2 = Crystal::Var.new("bar").at(Crystal::Location.new(nil, 2, 2))
Variable.new(var1, scope).declared_before?(var2).should be_true
end
it "is true if var's column_number is after the node" do
var1 = Crystal::Var.new("foo").at(Crystal::Location.new(nil, 1, 2))
var2 = Crystal::Var.new("bar").at(Crystal::Location.new(nil, 1, 3))
Variable.new(var1, scope).declared_before?(var2).should be_true
end
it "is false if var's location is before the node" do
var1 = Crystal::Var.new("foo").at(Crystal::Location.new(nil, 2, 2))
var2 = Crystal::Var.new("bar").at(Crystal::Location.new(nil, 1, 3))
Variable.new(var1, scope).declared_before?(var2).should be_false
end
it "is false is the node is the same var" do
var = Crystal::Var.new("foo").at(Crystal::Location.new(nil, 2, 2))
Variable.new(var, scope).declared_before?(var).should be_false
end
end
end
end