iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Do not report unreachable code after loops

Browse source 
closes #251
This commit is contained in:
Vitalii Elenhaupt 2021-11-10 09:11:45 +02:00
parent d843afd962
commit 429f76f8b6
No known key found for this signature in database
GPG key ID: CD0BF17825928BC0
3 changed files with 21 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec/ameba/rule/lint/unreachable_code_spec.cr
View file

@ -420,7 +420,7 @@ module Ameba::Rule::Lint
end
context "while/until" do
it "reports if there is unreachable code after while" do
it "does not report if there is no unreachable code after while" do
s = Source.new %(
def method
while something
@ -434,13 +434,10 @@ module Ameba::Rule::Lint
end
)
subject.catch(s).should_not be_valid
issue = s.issues.first
issue.location.to_s.should eq ":9:3"
subject.catch(s).should be_valid
end
it "reports if there is unreachable code after until" do
it "does not report if there is no unreachable code after until" do
s = Source.new %(
def method
until something
@ -454,10 +451,7 @@ module Ameba::Rule::Lint
end
)
subject.catch(s).should_not be_valid
issue = s.issues.first
issue.location.to_s.should eq ":9:3"
subject.catch(s).should be_valid
end
it "doesn't report if there is reachable code after while with break" do