iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don’t treat crystal paths as literals in Lint/LiteralsComparison

Browse source
This commit is contained in:
Sijawusz Pur Rahnama 2022-12-08 13:55:29 +01:00
parent 150ba6c70f
commit 2cb8c1381f
2 changed files with 3 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spec/ameba/rule/lint/literals_comparison_spec.cr
View file

@ -41,26 +41,13 @@ module Ameba::Rule::Lint
CRYSTAL
end
it "reports if there is a static path comparison evaluating to false" do
expect_issue subject, <<-CRYSTAL
String == Nil
# ^^^^^^^^^^^ error: Comparison always evaluates to false
CRYSTAL
end
context "macro" do
pending "reports in macro scope" do
it "reports in macro scope" do
expect_issue subject, <<-CRYSTAL
{{ "foo" == "foo" }}
# ^^^^^^^^^^^^^^ error: Comparison always evaluates to true
CRYSTAL
end
it "passes for free variables comparisons in macro scope" do
expect_no_issues subject, <<-CRYSTAL
{{ T == Nil }}
CRYSTAL
end
end
it "reports rule, pos and message" do