Revert "Merge pull request #394 from stufro/388-raise-on-invalid-file-path"

This reverts commit 18d193bd08, reversing
changes made to 7b8316f061.
This commit is contained in:
Sijawusz Pur Rahnama 2023-12-27 22:47:02 +01:00
parent 47088b10ca
commit 26d9bc0bd0
7 changed files with 22 additions and 63 deletions

View file

@ -5,7 +5,7 @@ module Ameba::Cli
describe "Cmd" do
describe ".run" do
it "runs ameba" do
r = Cli.run %w[-f silent -c spec/fixtures/config.yml spec/fixtures/source.cr]
r = Cli.run %w[-f silent file.cr]
r.should be_nil
end
end
@ -43,12 +43,12 @@ module Ameba::Cli
end
it "defaults rules? flag to false" do
c = Cli.parse_args %w[spec/fixtures/source.cr]
c = Cli.parse_args %w[file.cr]
c.rules?.should be_false
end
it "defaults skip_reading_config? flag to false" do
c = Cli.parse_args %w[spec/fixtures/source.cr]
c = Cli.parse_args %w[file.cr]
c.skip_reading_config?.should be_false
end
@ -58,7 +58,7 @@ module Ameba::Cli
end
it "defaults all? flag to false" do
c = Cli.parse_args %w[spec/fixtures/source.cr]
c = Cli.parse_args %w[file.cr]
c.all?.should be_false
end
@ -95,35 +95,35 @@ module Ameba::Cli
describe "-e/--explain" do
it "configures file/line/column" do
c = Cli.parse_args %w[--explain spec/fixtures/source.cr:3:5]
c = Cli.parse_args %w[--explain src/file.cr:3:5]
location_to_explain = c.location_to_explain.should_not be_nil
location_to_explain[:file].should eq "spec/fixtures/source.cr"
location_to_explain[:file].should eq "src/file.cr"
location_to_explain[:line].should eq 3
location_to_explain[:column].should eq 5
end
it "raises an error if location is not valid" do
expect_raises(Exception, "location should have PATH:line:column") do
Cli.parse_args %w[--explain spec/fixtures/source.cr:3]
Cli.parse_args %w[--explain src/file.cr:3]
end
end
it "raises an error if line number is not valid" do
expect_raises(Exception, "location should have PATH:line:column") do
Cli.parse_args %w[--explain spec/fixtures/source.cr:a:3]
Cli.parse_args %w[--explain src/file.cr:a:3]
end
end
it "raises an error if column number is not valid" do
expect_raises(Exception, "location should have PATH:line:column") do
Cli.parse_args %w[--explain spec/fixtures/source.cr:3:&]
Cli.parse_args %w[--explain src/file.cr:3:&]
end
end
it "raises an error if line/column are missing" do
expect_raises(Exception, "location should have PATH:line:column") do
Cli.parse_args %w[--explain spec/fixtures/source.cr]
Cli.parse_args %w[--explain src/file.cr]
end
end
end