iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Detect shadowing outer local vars

Browse source
This commit is contained in:
Vitalii Elenhaupt 2018-05-28 11:48:07 +03:00 • committed by V. Elenhaupt
parent 3887da1438
commit 15bb8f5331
6 changed files with 216 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/ameba/formatter/disabled_formatter_spec.cr
View file

@ -15,9 +15,9 @@ module Ameba::Formatter
Colorize.enabled = false
path = "source.cr"
s = Source.new("", path).tap do |s|
s.error(ErrorRule.new, 1, 2, "ErrorRule", :disabled)
s.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
s = Source.new("", path).tap do |source|
source.error(ErrorRule.new, 1, 2, "ErrorRule", :disabled)
source.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
end
subject.finished [s]
log = output.to_s
@ -29,9 +29,9 @@ module Ameba::Formatter
end
it "does not write not-disabled rules" do
s = Source.new("", "source.cr").tap do |s|
s.error(ErrorRule.new, 1, 2, "ErrorRule")
s.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
s = Source.new("", "source.cr").tap do |source|
source.error(ErrorRule.new, 1, 2, "ErrorRule")
source.error(NamedRule.new, 2, 2, "NamedRule", :disabled)
end
subject.finished [s]
output.to_s.should_not contain ErrorRule.name

6
spec/ameba/formatter/dot_formatter_spec.cr
View file

@ -39,9 +39,9 @@ module Ameba::Formatter
context "when errors found" do
it "writes each error" do
s = Source.new("").tap do |s|
s.error(DummyRule.new, 1, 1, "DummyRuleError")
s.error(NamedRule.new, 1, 2, "NamedRuleError")
s = Source.new("").tap do |source|
source.error(DummyRule.new, 1, 1, "DummyRuleError")
source.error(NamedRule.new, 1, 2, "NamedRuleError")
end
subject.finished [s]
log = output.to_s