iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Backward compatibility to Crystal 1.3

Browse source
This commit is contained in:
Vitalii Elenhaupt 2022-04-03 19:17:47 +03:00
parent 7192b64df0
commit 087f470f15
No known key found for this signature in database
GPG key ID: CD0BF17825928BC0
7 changed files with 94 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/ameba/ast/util_spec.cr
View file

@ -1,5 +1,4 @@
require "../../spec_helper"
require "semantic_version"
module Ameba::AST
struct Test
@ -77,12 +76,7 @@ module Ameba::AST
CRYSTAL
node = as_nodes(s).nil_literal_nodes.first
source = subject.node_source node, s.split("\n")
if SemanticVersion.parse(Crystal::VERSION) <= SemanticVersion.parse("0.35.1")
source.should be_nil
else
source.should eq "nil"
end
source.should eq "nil"
end
end

4
spec/ameba/rule/lint/empty_ensure_spec.cr
View file

@ -61,7 +61,9 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
# TODO: refactor this in next release
# Crystal 1.4 changes the start location of Crystal::ExceptionHandler
# issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:6:3"
issue.message.should eq "Empty `ensure` block detected"
end

4
spec/ameba/rule/lint/shadowed_exception_spec.cr
View file

@ -166,7 +166,9 @@ module Ameba::Rule::Lint
issue = s.issues.first
issue.rule.should_not be_nil
issue.location.to_s.should eq "source.cr:1:1"
# TODO: refactor this in next release
# Crystal 1.4 changes the start location of Crystal::ExceptionHandler
# issue.location.to_s.should eq "source.cr:2:3"
issue.end_location.to_s.should eq "source.cr:4:3"
issue.message.should eq(
"Exception handler has shadowed exceptions: IndexError"