iv-org-mirror/shard-ameba
1
0
Fork 0
mirror of https://gitea.invidious.io/iv-org/shard-ameba.git synced 2024-08-15 00:53:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Performance/FirstLastAfterFilter: ignore .first/.last with args

Browse source 
closes #104
This commit is contained in:
Vitalii Elenhaupt 2019-06-03 18:25:27 +03:00
parent 9e2061cbf6
commit 037d1dde74
No known key found for this signature in database
GPG key ID: 7558EF3A4056C706
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
spec/ameba/rule/performance/first_last_after_filter_spec.cr
View file

@ -36,6 +36,13 @@ module Ameba::Rule::Performance
subject.catch(source).should_not be_valid subject.catch(source).should_not be_valid
end end
it "does not report if there is selected followed by first with arguments" do
source = Source.new %(
[1, 2, 3].select { |n| n % 2 == 0 }.first(2)
)
subject.catch(source).should be_valid
end
it "reports if there is select followed by first?" do it "reports if there is select followed by first?" do
source = Source.new %( source = Source.new %(
[1, 2, 3].select { |e| e > 2 }.first? [1, 2, 3].select { |e| e > 2 }.first?

1
src/ameba/rule/performance/first_last_after_filter.cr
View file

@ -45,6 +45,7 @@ module Ameba::Rule::Performance
def test(source, node : Crystal::Call) def test(source, node : Crystal::Call)
return unless CALL_NAMES.includes?(node.name) && (obj = node.obj) return unless CALL_NAMES.includes?(node.name) && (obj = node.obj)
return if node.args.any?
if node.block.nil? && obj.is_a?(Crystal::Call) && if node.block.nil? && obj.is_a?(Crystal::Call) &&
filter_names.includes?(obj.name) && !obj.block.nil? filter_names.includes?(obj.name) && !obj.block.nil?