2017-11-07 18:44:38 +00:00
|
|
|
require "../../spec_helper"
|
|
|
|
|
|
|
|
module Ameba
|
2017-11-07 21:50:25 +00:00
|
|
|
subject = Rule::EmptyExpression.new
|
2017-11-07 18:44:38 +00:00
|
|
|
|
|
|
|
def it_detects_empty_expression(code)
|
|
|
|
it "detects empty expression" do
|
|
|
|
s = Source.new code
|
2017-11-07 21:50:25 +00:00
|
|
|
rule = Rule::EmptyExpression.new
|
2017-11-07 18:44:38 +00:00
|
|
|
rule.catch(s).should_not be_valid
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-11-07 21:50:25 +00:00
|
|
|
describe Rule::EmptyExpression do
|
2017-11-07 18:44:38 +00:00
|
|
|
it "passes if there is no empty expression" do
|
|
|
|
s = Source.new %(
|
|
|
|
def method()
|
|
|
|
end
|
|
|
|
|
|
|
|
method()
|
|
|
|
method(1, 2, 3)
|
|
|
|
method(nil)
|
|
|
|
|
|
|
|
a = nil
|
|
|
|
a = ""
|
|
|
|
a = 0
|
2017-11-17 16:32:40 +00:00
|
|
|
|
|
|
|
nil
|
|
|
|
:any.nil?
|
|
|
|
|
|
|
|
begin "" end
|
|
|
|
[nil] << nil
|
2017-11-07 18:44:38 +00:00
|
|
|
)
|
|
|
|
subject.catch(s).should be_valid
|
|
|
|
end
|
|
|
|
|
|
|
|
it_detects_empty_expression %(())
|
|
|
|
it_detects_empty_expression %(((())))
|
|
|
|
it_detects_empty_expression %(a = ())
|
|
|
|
it_detects_empty_expression %((();()))
|
|
|
|
it_detects_empty_expression %(if (); end)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
if foo
|
|
|
|
1
|
|
|
|
elsif ()
|
|
|
|
2
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
case foo
|
|
|
|
when :foo then ()
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
case foo
|
|
|
|
when :foo then 1
|
|
|
|
else
|
|
|
|
()
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
case foo
|
|
|
|
when () then 1
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
def method
|
|
|
|
a = 1
|
|
|
|
()
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
def method
|
|
|
|
rescue
|
|
|
|
()
|
|
|
|
end
|
|
|
|
)
|
2017-11-17 16:32:40 +00:00
|
|
|
it_detects_empty_expression %(
|
|
|
|
def method
|
|
|
|
begin
|
|
|
|
end
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
begin; end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
begin
|
|
|
|
nil
|
|
|
|
end
|
|
|
|
)
|
|
|
|
it_detects_empty_expression %(
|
|
|
|
begin
|
|
|
|
()
|
|
|
|
end
|
|
|
|
)
|
2017-11-07 18:44:38 +00:00
|
|
|
|
2017-11-07 20:02:51 +00:00
|
|
|
it "reports rule, location and message" do
|
2017-11-07 18:44:38 +00:00
|
|
|
s = Source.new %(
|
|
|
|
if ()
|
|
|
|
end
|
2017-11-07 20:02:51 +00:00
|
|
|
), "source.cr"
|
2017-11-07 18:44:38 +00:00
|
|
|
subject.catch(s).should_not be_valid
|
2018-06-10 21:15:12 +00:00
|
|
|
issue = s.issues.first
|
|
|
|
issue.rule.should_not be_nil
|
|
|
|
issue.location.to_s.should eq "source.cr:2:12"
|
|
|
|
issue.message.should eq "Avoid empty expressions"
|
2017-11-07 18:44:38 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|