2018-06-16 11:50:59 +00:00
|
|
|
require "../../../spec_helper"
|
2017-10-31 20:11:49 +00:00
|
|
|
|
2018-06-16 11:50:59 +00:00
|
|
|
module Ameba::Rule::Style
|
2017-10-31 20:11:49 +00:00
|
|
|
subject = UnlessElse.new
|
|
|
|
|
|
|
|
describe UnlessElse do
|
|
|
|
it "passes if unless hasn't else" do
|
|
|
|
s = Source.new %(
|
|
|
|
unless something
|
|
|
|
:ok
|
|
|
|
end
|
|
|
|
)
|
2017-11-01 20:05:41 +00:00
|
|
|
subject.catch(s).should be_valid
|
2017-10-31 20:11:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "fails if unless has else" do
|
|
|
|
s = Source.new %(
|
|
|
|
unless something
|
|
|
|
:one
|
|
|
|
else
|
|
|
|
:two
|
|
|
|
end
|
|
|
|
)
|
2017-11-01 20:05:41 +00:00
|
|
|
subject.catch(s).should_not be_valid
|
2017-10-31 20:11:49 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it "reports rule, pos and message" do
|
|
|
|
s = Source.new %(
|
|
|
|
unless something
|
|
|
|
:one
|
|
|
|
else
|
|
|
|
:two
|
|
|
|
end
|
2017-11-07 20:02:51 +00:00
|
|
|
), "source.cr"
|
2017-11-01 20:05:41 +00:00
|
|
|
subject.catch(s).should_not be_valid
|
2017-10-31 20:11:49 +00:00
|
|
|
|
2018-06-10 21:15:12 +00:00
|
|
|
issue = s.issues.first
|
|
|
|
issue.should_not be_nil
|
|
|
|
issue.rule.should_not be_nil
|
|
|
|
issue.location.to_s.should eq "source.cr:2:9"
|
|
|
|
issue.message.should eq "Favour if over unless with else"
|
2017-10-31 20:11:49 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|