shard-ameba/spec/ameba/rule/lint/useless_condition_in_when_s...

46 lines
1.1 KiB
Crystal
Raw Normal View History

require "../../../spec_helper"
module Ameba::Rule::Lint
subject = UselessConditionInWhen.new
describe UselessConditionInWhen do
it "passes if there is not useless condition" do
s = Source.new %(
case
when utc?
io << " UTC"
when local?
Format.new(" %:z").format(self, io) if utc?
end
)
subject.catch(s).should be_valid
end
it "fails if there is useless if condition" do
s = Source.new %(
case
when utc?
io << " UTC" if utc?
end
)
subject.catch(s).should_not be_valid
end
it "reports rule, location and message" do
s = Source.new %(
case
when String
puts "hello"
when can_generate?
generate if can_generate?
end
), "source.cr"
subject.catch(s).should_not be_valid
2018-06-10 21:15:12 +00:00
issue = s.issues.first
issue.rule.should_not be_nil
2018-09-07 12:07:03 +00:00
issue.location.to_s.should eq "source.cr:5:15"
2018-06-10 21:15:12 +00:00
issue.message.should eq "Useless condition in when detected"
end
end
end