shard-ameba/spec/ameba/rule/method_names_spec.cr

56 lines
1.3 KiB
Crystal
Raw Normal View History

2017-11-04 20:54:27 +00:00
require "../../spec_helper"
module Ameba
2017-11-07 21:50:25 +00:00
subject = Rule::MethodNames.new
2017-11-04 20:54:27 +00:00
private def it_reports_method_name(code, expected)
2017-11-04 20:54:27 +00:00
it "reports method name #{expected}" do
s = Source.new code
2017-11-07 21:50:25 +00:00
Rule::MethodNames.new.catch(s).should_not be_valid
2017-11-04 20:54:27 +00:00
s.errors.first.message.should contain expected
end
end
2017-11-07 21:50:25 +00:00
describe Rule::MethodNames do
2017-11-04 20:54:27 +00:00
it "passes if method names are underscore-cased" do
s = Source.new %(
class Person
def first_name
end
def date_of_birth
end
def homepage_url
end
def valid?
end
def name
end
end
)
subject.catch(s).should be_valid
end
it_reports_method_name %(def firstName; end), "first_name"
it_reports_method_name %(def date_of_Birth; end), "date_of_birth"
it_reports_method_name %(def homepageURL; end), "homepage_url"
it "reports rule, pos and message" do
s = Source.new %(
def bad_Name
end
), "source.cr"
2017-11-04 20:54:27 +00:00
subject.catch(s).should_not be_valid
error = s.errors.first
error.rule.should_not be_nil
error.location.to_s.should eq "source.cr:2:9"
2017-11-04 20:54:27 +00:00
error.message.should eq(
"Method name should be underscore-cased: bad_name, not bad_Name"
)
end
end
end