shard-ameba/src/ameba/rule/style/method_names.cr

59 lines
1.1 KiB
Crystal
Raw Normal View History

module Ameba::Rule::Style
2017-11-04 20:54:27 +00:00
# A rule that enforces method names to be in underscored case.
#
# For example, these are considered valid:
#
# ```
# class Person
# def first_name
# end
#
# def date_of_birth
# end
#
# def homepage_url
# end
# end
# ```
#
# And these are invalid method names:
#
# ```
# class Person
# def firstName
# end
#
# def date_of_Birth
# end
#
# def homepageURL
# end
# end
# ```
#
# YAML configuration example:
#
# ```
# Style/MethodNames:
# Enabled: true
# ```
2021-01-18 15:45:35 +00:00
class MethodNames < Base
2021-11-16 21:30:33 +00:00
include AST::Util
2017-11-22 06:44:29 +00:00
properties do
description "Enforces method names to be in underscored case"
2017-11-22 06:44:29 +00:00
end
MSG = "Method name should be underscore-cased: %s, not %s"
2017-11-04 20:54:27 +00:00
def test(source, node : Crystal::Def)
return if (expected = node.name.underscore) == node.name
2022-12-08 13:06:16 +00:00
2021-11-16 21:30:33 +00:00
return unless location = name_location(node)
return unless end_location = name_end_location(node)
2017-11-04 20:54:27 +00:00
2021-11-16 21:30:33 +00:00
issue_for location, end_location, MSG % {expected, node.name}
2017-11-04 20:54:27 +00:00
end
end
end