shard-ameba/spec/ameba/rule/style/variable_names_spec.cr

63 lines
1.6 KiB
Crystal
Raw Normal View History

require "../../../spec_helper"
2017-11-04 21:13:38 +00:00
module Ameba
subject = Rule::Style::VariableNames.new
2017-11-04 21:13:38 +00:00
private def it_reports_var_name(code, expected)
2017-11-04 21:13:38 +00:00
it "reports method name #{expected}" do
s = Source.new code
Rule::Style::VariableNames.new.catch(s).should_not be_valid
2018-06-10 21:15:12 +00:00
s.issues.first.message.should contain expected
2017-11-04 21:13:38 +00:00
end
end
describe Rule::Style::VariableNames do
2017-11-04 21:13:38 +00:00
it "passes if var names are underscore-cased" do
s = Source.new %(
class Greeting
@@default_greeting = "Hello world"
def initialize(@custom_greeting = nil)
end
def print_greeting
greeting = @custom_greeting || @@default_greeting
puts greeting
end
end
)
subject.catch(s).should be_valid
end
it_reports_var_name %(myBadNamedVar = 1), "my_bad_named_var"
it_reports_var_name %(wrong_Name = 'y'), "wrong_name"
it_reports_var_name %(
class Greeting
def initialize(@badNamed = nil)
end
end
), "bad_named"
it_reports_var_name %(
class Greeting
@@defaultGreeting = "Hello world"
end
), "default_greeting"
it "reports rule, pos and message" do
s = Source.new %(
badName = "Yeah"
), "source.cr"
2017-11-04 21:13:38 +00:00
subject.catch(s).should_not be_valid
2018-06-10 21:15:12 +00:00
issue = s.issues.first
issue.rule.should_not be_nil
2018-09-07 12:07:03 +00:00
issue.location.to_s.should eq "source.cr:1:1"
2018-11-24 17:38:13 +00:00
issue.end_location.to_s.should eq "source.cr:1:7"
2018-06-10 21:15:12 +00:00
issue.message.should eq(
2017-11-04 21:13:38 +00:00
"Var name should be underscore-cased: bad_name, not badName"
)
end
end
end