2018-06-16 11:50:59 +00:00
|
|
|
require "../../../spec_helper"
|
2017-11-04 20:54:27 +00:00
|
|
|
|
|
|
|
module Ameba
|
2023-11-08 23:16:29 +00:00
|
|
|
subject = Rule::Naming::MethodNames.new
|
2017-11-04 20:54:27 +00:00
|
|
|
|
2022-12-21 16:23:56 +00:00
|
|
|
private def it_reports_method_name(name, expected, *, file = __FILE__, line = __LINE__)
|
|
|
|
it "reports method name #{expected}", file, line do
|
2023-11-08 23:16:29 +00:00
|
|
|
rule = Rule::Naming::MethodNames.new
|
2022-12-21 16:23:56 +00:00
|
|
|
expect_issue rule, <<-CRYSTAL, name: name, file: file, line: line
|
2021-10-27 22:58:58 +00:00
|
|
|
def %{name}; end
|
|
|
|
# ^{name} error: Method name should be underscore-cased: #{expected}, not %{name}
|
|
|
|
CRYSTAL
|
2017-11-04 20:54:27 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2023-11-08 23:16:29 +00:00
|
|
|
describe Rule::Naming::MethodNames do
|
2017-11-04 20:54:27 +00:00
|
|
|
it "passes if method names are underscore-cased" do
|
2021-10-27 22:58:58 +00:00
|
|
|
expect_no_issues subject, <<-CRYSTAL
|
2017-11-04 20:54:27 +00:00
|
|
|
class Person
|
|
|
|
def first_name
|
|
|
|
end
|
|
|
|
|
|
|
|
def date_of_birth
|
|
|
|
end
|
|
|
|
|
|
|
|
def homepage_url
|
|
|
|
end
|
|
|
|
|
|
|
|
def valid?
|
|
|
|
end
|
|
|
|
|
|
|
|
def name
|
|
|
|
end
|
|
|
|
end
|
2021-10-27 22:58:58 +00:00
|
|
|
CRYSTAL
|
2017-11-04 20:54:27 +00:00
|
|
|
end
|
|
|
|
|
2021-10-27 22:58:58 +00:00
|
|
|
it_reports_method_name "firstName", "first_name"
|
|
|
|
it_reports_method_name "date_of_Birth", "date_of_birth"
|
|
|
|
it_reports_method_name "homepageURL", "homepage_url"
|
2017-11-04 20:54:27 +00:00
|
|
|
end
|
|
|
|
end
|