mirror of
https://gitea.invidious.io/iv-org/lsquic.cr
synced 2024-08-15 00:43:31 +00:00
Update recieve function to read full data from socket at once
The existing code reads each message from the socket individually and calls engine_process_conns after each message. This seems inefficient as it leads to excess calls engine_process_conns. This changes the code that reads from the socket to read all available messages before calling engine_process_conns based off of the logic in the reference implementation. reference: https://github.com/litespeedtech/lsquic/blob/master/bin/test_common.c#L737
This commit is contained in:
parent
c965e0a380
commit
a3d2458c28
1 changed files with 26 additions and 4 deletions
|
@ -226,17 +226,39 @@ module QUIC
|
|||
diff = 0
|
||||
# check advisory time
|
||||
if LibLsquic.engine_earliest_adv_tick(engine, pointerof(diff)) != 0
|
||||
Thread.current.scheduler.@current.resume_event.add(diff.microseconds)
|
||||
Crystal::Scheduler.current_fiber.resume_event.add(diff.microseconds)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
begin
|
||||
buffer = Bytes.new(0x600)
|
||||
buffers = [] of Bytes
|
||||
bytes_read = [] of Int32
|
||||
loop do
|
||||
bytes_read = socket.read buffer
|
||||
# wait until the socket has something.
|
||||
socket.wait_readable
|
||||
# read available messages from the socket into the buffers.
|
||||
buffers_read = 0
|
||||
loop do
|
||||
if (buffers_read >= buffers.size)
|
||||
buffers.push(Bytes.new(0x600))
|
||||
bytes_read.push(0)
|
||||
end
|
||||
bytes_read[buffers_read] = LibC.recv(socket.fd, buffers[buffers_read], buffers[buffers_read].size, 0).to_i32
|
||||
if bytes_read[buffers_read] == -1
|
||||
if Errno.value == Errno::EAGAIN || Errno.value == Errno::EWOULDBLOCK
|
||||
# no more messages are currently available to read from the socket.
|
||||
break
|
||||
else
|
||||
raise IO::Error.from_errno("failed to read from socket")
|
||||
end
|
||||
end
|
||||
buffers_read += 1
|
||||
end
|
||||
break if !@engine_open
|
||||
LibLsquic.engine_packet_in(engine, buffer[0, bytes_read], bytes_read, socket.local_address, socket.remote_address, Box.box(socket), 0) if bytes_read != 0
|
||||
buffers[0, buffers_read].zip(bytes_read) do |buffer, bytes|
|
||||
LibLsquic.engine_packet_in(engine, buffer[0, bytes], bytes, socket.local_address, socket.remote_address, Box.box(socket), 0) if bytes != 0
|
||||
end
|
||||
client_process_conns(engine)
|
||||
end
|
||||
@socket.try &.close
|
||||
|
|
Loading…
Reference in a new issue