From ef80a65ff802a4a25be018a632339fa86183e62c Mon Sep 17 00:00:00 2001 From: Dmitri Tikhonov Date: Wed, 29 Jul 2020 12:00:21 -0400 Subject: [PATCH] Release 2.19.1 -- fix crash in IETF client (DPLPMTUD regression) --- CHANGELOG | 2 +- docs/conf.py | 2 +- include/lsquic.h | 2 +- src/liblsquic/lsquic_full_conn_ietf.c | 7 ++++--- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index e2a7b0a..134f8b2 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,5 @@ 2020-07-29 - - 2.19.0 + - 2.19.1 - [FEATURE] DPLPMTUD support. IETF connections now search for the maximum packet size, improving throughput. - [DEBUG] Record event in stream history when on_close() is called diff --git a/docs/conf.py b/docs/conf.py index f82e1e0..2999663 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -26,7 +26,7 @@ author = u'LiteSpeed Technologies' # The short X.Y version version = u'2.19' # The full version, including alpha/beta/rc tags -release = u'2.19.0' +release = u'2.19.1' # -- General configuration --------------------------------------------------- diff --git a/include/lsquic.h b/include/lsquic.h index 36133e4..f36c967 100644 --- a/include/lsquic.h +++ b/include/lsquic.h @@ -25,7 +25,7 @@ extern "C" { #define LSQUIC_MAJOR_VERSION 2 #define LSQUIC_MINOR_VERSION 19 -#define LSQUIC_PATCH_VERSION 0 +#define LSQUIC_PATCH_VERSION 1 /** * Engine flags: diff --git a/src/liblsquic/lsquic_full_conn_ietf.c b/src/liblsquic/lsquic_full_conn_ietf.c index c1098e9..ef55ddf 100644 --- a/src/liblsquic/lsquic_full_conn_ietf.c +++ b/src/liblsquic/lsquic_full_conn_ietf.c @@ -1237,6 +1237,10 @@ lsquic_ietf_full_conn_client_new (struct lsquic_engine_public *enpub, } esfi = select_esf_iquic_by_ver(ver); + if (0 != ietf_full_conn_init(conn, enpub, flags, + enpub->enp_settings.es_ecn)) + goto err2; + if (base_plpmtu) conn->ifc_paths[0].cop_path.np_pack_size = base_plpmtu - TRANSPORT_OVERHEAD(!is_ipv4); @@ -1244,9 +1248,6 @@ lsquic_ietf_full_conn_client_new (struct lsquic_engine_public *enpub, conn->ifc_paths[0].cop_path.np_pack_size = calc_base_packet_size(conn, !is_ipv4); - if (0 != ietf_full_conn_init(conn, enpub, flags, - enpub->enp_settings.es_ecn)) - goto err2; if (token) { if (0 != lsquic_send_ctl_set_token(&conn->ifc_send_ctl, token,