Decide on timeline endpoint #35

New issue

Open

opened 2022-10-16 22:28:42 +00:00 by heartles · 1 comment

heartles commented

2022-10-16 22:28:42 +00:00

Owner

Ideas for timeline endpoint layouts:

GET /timelines/global
- Simple from user perspective
- Needs lots of endpoints w/ duplicated code
GET /notes?timeline=global
- More complicated from user perspective
- Probably easier from backend perspective
- the /notes endpoint will probably serve as a more generalized search too
  - but, searching for posts probably shouldn't be allowed in most circumstances
  - Would need lots of permissions logic

Ideas for timeline endpoint layouts: - `GET /timelines/global` * Simple from user perspective * Needs lots of endpoints w/ duplicated code - `GET /notes?timeline=global` * More complicated from user perspective * Probably easier from backend perspective * the `/notes` endpoint will probably serve as a more generalized search too + *but*, searching for posts probably shouldn't be allowed in most circumstances + Would need lots of permissions logic

heartles added the

endpoint

label 2022-10-16 22:28:42 +00:00

heartles commented

2022-10-16 22:34:25 +00:00

Author

Owner

I think for now it might be a good idea to just implement the former. We can reconsider when we actually put the GET /notes endpoint together, because post search is helpful for moderation purposes.

That also raises another question of when post search should be allowed. My thoughts are
Allowed:

When searching as a moderator (should require some action on the user's end to go "i am doing this in an official capacity")
When searching your own posts

Unsure but leaning towards "no":

Searching posts from people you follow
Searching posts that you've interacted with

Not allowed:

General post search as a user

I think for now it might be a good idea to just implement the former. We can reconsider when we actually put the `GET /notes` endpoint together, because post search is helpful for moderation purposes. That also raises another question of when post search should be allowed. My thoughts are Allowed: - When searching as a moderator (should require some action on the user's end to go "i am doing this in an official capacity") - When searching your own posts Unsure but leaning towards "no": - Searching posts from people you follow - Searching posts that you've interacted with Not allowed: - General post search as a user