heartles/egirlskey
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

2fa broken with secureApiMode enabled #2

New issue
Open
opened 2024-03-18 05:27:37 +00:00 by heartles · 0 comments
heartles commented 2024-03-18 05:27:37 +00:00
Owner
Copy link

the frontend uses the user/show endpoint to determine whether or not to show a 2fa prompt. we lock off that endpoint during secureApiMode, meaning that enabling 2fa effectively prevents a user from logging in.

potential fixes:

  • open up user/show endpoint (not viable)
  • add a toggle for the frontend to show a 2fa thing (bad ux)
  • add new sign in endpoints (not viable)
  • use special error code from signin endpoint to indicate 2fa required? (weird)

also look into passwordless logins and how we can serve that usecase

the frontend uses the user/show endpoint to determine whether or not to show a 2fa prompt. we lock off that endpoint during secureApiMode, meaning that enabling 2fa effectively prevents a user from logging in. potential fixes: - open up user/show endpoint (not viable) - add a toggle for the frontend to show a 2fa thing (bad ux) - add new sign in endpoints (not viable) - use special error code from signin endpoint to indicate 2fa required? (weird) also look into passwordless logins and how we can serve that usecase
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
egirls-sharkey
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: heartles/egirlskey#2
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?