heartles/egirlskey
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

perf(backend): reduce needless populateMyReaction calls

Browse source
This commit is contained in:
syuilo 2023-10-19 07:56:25 +09:00
parent de6e15e36d
commit fcc4864080
8 changed files with 29 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/backend/src/core/entities/NoteEntityService.ts
View file

@ -357,7 +357,7 @@ export class NoteEntityService implements OnModuleInit {
poll: note.hasPoll ? this.populatePoll(note, meId) : undefined, poll: note.hasPoll ? this.populatePoll(note, meId) : undefined,
...(meId ? { ...(meId && Object.keys(note.reactions).length > 0 ? {
myReaction: this.populateMyReaction(note.id, meId, options?._hint_), myReaction: this.populateMyReaction(note.id, meId, options?._hint_),
} : {}), } : {}),
} : {}), } : {}),

6
packages/backend/src/server/api/stream/channels/channel.ts
View file

@ -46,8 +46,10 @@ class ChannelChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/global-timeline.ts
View file

@ -72,8 +72,10 @@ class GlobalTimelineChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/hashtag.ts
View file

@ -51,8 +51,10 @@ class HashtagChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/home-timeline.ts
View file

@ -74,8 +74,10 @@ class HomeTimelineChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/hybrid-timeline.ts
View file

@ -88,8 +88,10 @@ class HybridTimelineChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/local-timeline.ts
View file

@ -71,8 +71,10 @@ class LocalTimelineChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);

6
packages/backend/src/server/api/stream/channels/user-list.ts
View file

@ -103,8 +103,10 @@ class UserListChannel extends Channel {
if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return; if (note.renote && !note.text && isUserRelated(note, this.userIdsWhoMeMutingRenotes)) return;
if (this.user && note.renoteId && !note.text) { if (this.user && note.renoteId && !note.text) {
const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id); if (note.renote && Object.keys(note.renote.reactions).length > 0) {
note.renote!.myReaction = myRenoteReaction; const myRenoteReaction = await this.noteEntityService.populateMyReaction(note.renoteId, this.user.id);
note.renote!.myReaction = myRenoteReaction;
}
} }
this.connection.cacheNote(note); this.connection.cacheNote(note);