From 055863144d1630b7b491a4b9217cbeeadfa58f52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Acid=20Chicken=20=28=E7=A1=AB=E9=85=B8=E9=B6=8F=29?= Date: Thu, 7 Feb 2019 14:46:17 +0900 Subject: [PATCH 1/2] Update issue templates (#4038) * WIP: Update issue templates * Update client-side-feature-request.md * Update bug_report.md * Update feature_request.md * Update server-side-bug-report.md * Update server-side-feature-request.md * Update bug_report.md --- .github/ISSUE_TEMPLATE/bug_report.md | 10 +++++- .../ISSUE_TEMPLATE/client-side-bug-report.md | 31 +++++++++++++++++++ .../client-side-feature-request.md | 12 +++++++ .github/ISSUE_TEMPLATE/feature_request.md | 9 +++--- .../ISSUE_TEMPLATE/server-side-bug-report.md | 31 +++++++++++++++++++ .../server-side-feature-request.md | 12 +++++++ 6 files changed, 100 insertions(+), 5 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/client-side-bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/client-side-feature-request.md create mode 100644 .github/ISSUE_TEMPLATE/server-side-bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/server-side-feature-request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index e4e5282e56..0ed461256d 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -1,22 +1,30 @@ --- name: Bug Report about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + --- # Summary + # Expected Behavior + # Actual Behavior + # Steps to Reproduce + 1. 2. 3. # Environment + - diff --git a/.github/ISSUE_TEMPLATE/client-side-bug-report.md b/.github/ISSUE_TEMPLATE/client-side-bug-report.md new file mode 100644 index 0000000000..a8b111d4de --- /dev/null +++ b/.github/ISSUE_TEMPLATE/client-side-bug-report.md @@ -0,0 +1,31 @@ +--- +name: Client-side Bug Report +about: Create a report to help us improve +title: '' +labels: bug, client-side +assignees: '' + +--- + +# Summary + + + +# Expected Behavior + + + +# Actual Behavior + + + +# Steps to Reproduce + +1. +2. +3. + +# Environment + + + diff --git a/.github/ISSUE_TEMPLATE/client-side-feature-request.md b/.github/ISSUE_TEMPLATE/client-side-feature-request.md new file mode 100644 index 0000000000..0a0958662e --- /dev/null +++ b/.github/ISSUE_TEMPLATE/client-side-feature-request.md @@ -0,0 +1,12 @@ +--- +name: Client-side Feature Request +about: Suggest an idea for this project +title: '' +labels: client-side, feature +assignees: '' + +--- + +# Summary + + diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 018e68df97..3c7e26232e 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -1,11 +1,12 @@ --- name: Feature Request about: Suggest an idea for this project +title: '' +labels: feature +assignees: '' + --- # Summary - -# Environment - - + diff --git a/.github/ISSUE_TEMPLATE/server-side-bug-report.md b/.github/ISSUE_TEMPLATE/server-side-bug-report.md new file mode 100644 index 0000000000..6dd9d57cb7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/server-side-bug-report.md @@ -0,0 +1,31 @@ +--- +name: Server-side Bug Report +about: Create a report to help us improve +title: '' +labels: bug, server-side +assignees: '' + +--- + +# Summary + + + +# Expected Behavior + + + +# Actual Behavior + + + +# Steps to Reproduce + +1. +2. +3. + +# Environment + + + diff --git a/.github/ISSUE_TEMPLATE/server-side-feature-request.md b/.github/ISSUE_TEMPLATE/server-side-feature-request.md new file mode 100644 index 0000000000..da6dee2906 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/server-side-feature-request.md @@ -0,0 +1,12 @@ +--- +name: Server-side Feature Request +about: Suggest an idea for this project +title: '' +labels: feature, server-side +assignees: '' + +--- + +# Summary + + From dd9c94e47e20ea402c158aa63b439ac07161af8f Mon Sep 17 00:00:00 2001 From: syuilo Date: Thu, 7 Feb 2019 14:54:14 +0900 Subject: [PATCH 2/2] Update CONTRIBUTING.md --- CONTRIBUTING.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 4dd9b6ad02..473e92b505 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -44,3 +44,15 @@ Stands for _**S**ervice**W**orker_. #### Denyaize Nyaizeを解除すること + +## Code style +### Don't use `export default` +Bad: +``` ts +export default function(foo: string): string { +``` + +Good: +``` ts +export function something(foo: string): string { +```