fix(frontend): 「アニメーション画像を再生しない」がオンのときにバナー画像・サーバー背景画像がアニメーションしないように (#14243)
* fix: stop animating banner and backgrounds when stop showing animated images is enabled (cherry picked from commit8fe2596316) * chore: nest ternary (cherry picked from commit2783fe5f5b) * chore: flip ternary (cherry picked from commitb9d66f824c) * update changelog --------- Co-authored-by: Marie <marie@kaifa.ch>
This commit is contained in:
		
							parent
							
								
									6942a920c8
								
							
						
					
					
						commit
						3331f3972a
					
				
					 4 changed files with 16 additions and 4 deletions
				
			
		| 
						 | 
					@ -30,6 +30,8 @@
 | 
				
			||||||
- Fix: ショートカットキーが連打できる問題を修正  
 | 
					- Fix: ショートカットキーが連打できる問題を修正  
 | 
				
			||||||
  (Cherry-picked from https://github.com/taiyme/misskey/pull/234)
 | 
					  (Cherry-picked from https://github.com/taiyme/misskey/pull/234)
 | 
				
			||||||
- Fix: MkSignin.vueのcredentialRequestからReactivityを削除(ProxyがPasskey認証処理に渡ることを避けるため)
 | 
					- Fix: MkSignin.vueのcredentialRequestからReactivityを削除(ProxyがPasskey認証処理に渡ることを避けるため)
 | 
				
			||||||
 | 
					- Fix: 「アニメーション画像を再生しない」がオンのときでもサーバーのバナー画像・背景画像がアニメーションしてしまう問題を修正  
 | 
				
			||||||
 | 
					  (Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/574)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
### Server
 | 
					### Server
 | 
				
			||||||
- Feat: レートリミット制限に引っかかったときに`Retry-After`ヘッダーを返すように (#13949)
 | 
					- Feat: レートリミット制限に引っかかったときに`Retry-After`ヘッダーを返すように (#13949)
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -5,7 +5,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 | 
				
			||||||
 | 
					
 | 
				
			||||||
<template>
 | 
					<template>
 | 
				
			||||||
<div class="_panel" :class="$style.root">
 | 
					<div class="_panel" :class="$style.root">
 | 
				
			||||||
	<div :class="$style.banner" :style="user.bannerUrl ? `background-image: url(${user.bannerUrl})` : ''"></div>
 | 
						<div :class="$style.banner" :style="user.bannerUrl ? `background-image: url(${defaultStore.state.disableShowingAnimatedImages ? getStaticImageUrl(user.bannerUrl) : user.bannerUrl})` : ''"></div>
 | 
				
			||||||
	<MkAvatar :class="$style.avatar" :user="user" indicator/>
 | 
						<MkAvatar :class="$style.avatar" :user="user" indicator/>
 | 
				
			||||||
	<div :class="$style.title">
 | 
						<div :class="$style.title">
 | 
				
			||||||
		<MkA :class="$style.name" :to="userPage(user)"><MkUserName :user="user" :nowrap="false"/></MkA>
 | 
							<MkA :class="$style.name" :to="userPage(user)"><MkUserName :user="user" :nowrap="false"/></MkA>
 | 
				
			||||||
| 
						 | 
					@ -41,6 +41,8 @@ import { userPage } from '@/filters/user.js';
 | 
				
			||||||
import { i18n } from '@/i18n.js';
 | 
					import { i18n } from '@/i18n.js';
 | 
				
			||||||
import { $i } from '@/account.js';
 | 
					import { $i } from '@/account.js';
 | 
				
			||||||
import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
					import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
				
			||||||
 | 
					import { getStaticImageUrl } from '@/scripts/media-proxy.js';
 | 
				
			||||||
 | 
					import { defaultStore } from '@/store.js';
 | 
				
			||||||
 | 
					
 | 
				
			||||||
defineProps<{
 | 
					defineProps<{
 | 
				
			||||||
	user: Misskey.entities.UserDetailed;
 | 
						user: Misskey.entities.UserDetailed;
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -13,7 +13,7 @@ SPDX-License-Identifier: AGPL-3.0-only
 | 
				
			||||||
>
 | 
					>
 | 
				
			||||||
	<div v-if="showing" :class="$style.root" class="_popup _shadow" :style="{ zIndex, top: top + 'px', left: left + 'px' }" @mouseover="() => { emit('mouseover'); }" @mouseleave="() => { emit('mouseleave'); }">
 | 
						<div v-if="showing" :class="$style.root" class="_popup _shadow" :style="{ zIndex, top: top + 'px', left: left + 'px' }" @mouseover="() => { emit('mouseover'); }" @mouseleave="() => { emit('mouseleave'); }">
 | 
				
			||||||
		<div v-if="user != null">
 | 
							<div v-if="user != null">
 | 
				
			||||||
			<div :class="$style.banner" :style="user.bannerUrl ? `background-image: url(${user.bannerUrl})` : ''">
 | 
								<div :class="$style.banner" :style="user.bannerUrl ? `background-image: url(${defaultStore.state.disableShowingAnimatedImages ? getStaticImageUrl(user.bannerUrl) : user.bannerUrl})` : ''">
 | 
				
			||||||
				<span v-if="$i && $i.id != user.id && user.isFollowed" :class="$style.followed">{{ i18n.ts.followsYou }}</span>
 | 
									<span v-if="$i && $i.id != user.id && user.isFollowed" :class="$style.followed">{{ i18n.ts.followsYou }}</span>
 | 
				
			||||||
			</div>
 | 
								</div>
 | 
				
			||||||
			<svg viewBox="0 0 128 128" :class="$style.avatarBack">
 | 
								<svg viewBox="0 0 128 128" :class="$style.avatarBack">
 | 
				
			||||||
| 
						 | 
					@ -67,6 +67,7 @@ import { i18n } from '@/i18n.js';
 | 
				
			||||||
import { defaultStore } from '@/store.js';
 | 
					import { defaultStore } from '@/store.js';
 | 
				
			||||||
import { $i } from '@/account.js';
 | 
					import { $i } from '@/account.js';
 | 
				
			||||||
import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
					import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
				
			||||||
 | 
					import { getStaticImageUrl } from '@/scripts/media-proxy.js';
 | 
				
			||||||
 | 
					
 | 
				
			||||||
const props = defineProps<{
 | 
					const props = defineProps<{
 | 
				
			||||||
	showing: boolean;
 | 
						showing: boolean;
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -173,6 +173,7 @@ import { confetti } from '@/scripts/confetti.js';
 | 
				
			||||||
import { misskeyApi } from '@/scripts/misskey-api.js';
 | 
					import { misskeyApi } from '@/scripts/misskey-api.js';
 | 
				
			||||||
import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
					import { isFollowingVisibleForMe, isFollowersVisibleForMe } from '@/scripts/isFfVisibleForMe.js';
 | 
				
			||||||
import { useRouter } from '@/router/supplier.js';
 | 
					import { useRouter } from '@/router/supplier.js';
 | 
				
			||||||
 | 
					import { getStaticImageUrl } from '@/scripts/media-proxy.js';
 | 
				
			||||||
 | 
					
 | 
				
			||||||
function calcAge(birthdate: string): number {
 | 
					function calcAge(birthdate: string): number {
 | 
				
			||||||
	const date = new Date(birthdate);
 | 
						const date = new Date(birthdate);
 | 
				
			||||||
| 
						 | 
					@ -220,8 +221,14 @@ watch(moderationNote, async () => {
 | 
				
			||||||
 | 
					
 | 
				
			||||||
const style = computed(() => {
 | 
					const style = computed(() => {
 | 
				
			||||||
	if (props.user.bannerUrl == null) return {};
 | 
						if (props.user.bannerUrl == null) return {};
 | 
				
			||||||
	return {
 | 
						if (defaultStore.state.disableShowingAnimatedImages) {
 | 
				
			||||||
		backgroundImage: `url(${ props.user.bannerUrl })`,
 | 
							return {
 | 
				
			||||||
 | 
								backgroundImage: `url(${ getStaticImageUrl(props.user.bannerUrl) })`,
 | 
				
			||||||
 | 
							};
 | 
				
			||||||
 | 
						} else {
 | 
				
			||||||
 | 
							return {
 | 
				
			||||||
 | 
								backgroundImage: `url(${ props.user.bannerUrl })`,
 | 
				
			||||||
 | 
							};
 | 
				
			||||||
	};
 | 
						};
 | 
				
			||||||
});
 | 
					});
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue