From cc52e56e47e80d91a433be460ae61e6d16d8408f Mon Sep 17 00:00:00 2001
From: Dan Church <amphetamachine@gmail.com>
Date: Tue, 11 Jul 2023 11:54:52 -0500
Subject: [PATCH 1/4] Fix uninitialized string warning

---
 make-block.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/make-block.pl b/make-block.pl
index 425eafb..182050e 100755
--- a/make-block.pl
+++ b/make-block.pl
@@ -117,7 +117,7 @@ MAIN: {
         } @block_ip;
     } sort keys %domains;
 
-    printf STDERR "%d domains written to %s from\n", $written, $out;
+    printf STDERR "%d domains written to %s from\n", $written, $out // 'STDOUT';
     printf STDERR " - %d .domains files\n", (scalar @domain_lists);
     printf STDERR " - %d .hosts files\n", (scalar @hosts_lists);
     printf STDERR "(%d duplicates)\n", $dupes if $dupes;

From 06e9f5948902af0c439f01aa20b3a699a3884405 Mon Sep 17 00:00:00 2001
From: Dan Church <amphetamachine@gmail.com>
Date: Tue, 11 Jul 2023 12:51:14 -0500
Subject: [PATCH 2/4] Remove vim modelines

We have .editorconfig for that.
---
 make-block.pl | 1 -
 update.sh     | 1 -
 2 files changed, 2 deletions(-)

diff --git a/make-block.pl b/make-block.pl
index 182050e..315dfd8 100755
--- a/make-block.pl
+++ b/make-block.pl
@@ -1,5 +1,4 @@
 #!/usr/bin/perl
-# vi: et sts=4 sw=4 ts=4
 
 ###############################################################################
 # You Don't Need Pi-hole
diff --git a/update.sh b/update.sh
index 5cb1729..9a1c0c0 100755
--- a/update.sh
+++ b/update.sh
@@ -1,5 +1,4 @@
 #!/bin/bash
-# vi: et sts=4 sw=4 ts=4
 
 ###############################################################################
 # You Don't Need Pi-hole

From 942465cc224f282232975236fd28159f3db7eb23 Mon Sep 17 00:00:00 2001
From: Dan Church <amphetamachine@gmail.com>
Date: Tue, 11 Jul 2023 12:54:22 -0500
Subject: [PATCH 3/4] Remove 'set -e'

Makes scripts less able to handle errors properly.
---
 update.sh | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/update.sh b/update.sh
index 9a1c0c0..74f1d7c 100755
--- a/update.sh
+++ b/update.sh
@@ -13,8 +13,6 @@
 # You may NOT use this software for commercial purposes.
 ###############################################################################
 
-set -e
-
 WORKDIR=${0%/*}
 CFG=$WORKDIR/update.cfg
 
@@ -26,7 +24,7 @@ OUT=()
 URL=()
 DNSMASQ_RESTART_COMMAND=()
 if [[ -f $CFG ]]; then
-    . "$CFG"
+    . "$CFG" || exit
 fi
 
 TEMP_DIR=$(mktemp -d -t "${0##*/}.XXXXXX")
@@ -37,9 +35,9 @@ trap 'cleanup' EXIT
 
 copy_perms() {
     local -r FROM=$1 TO=$2
-    chmod --reference="$FROM" -- "$TO"
+    chmod --reference="$FROM" -- "$TO" || exit
     if [[ $UID -eq 0 ]]; then
-        chown --reference="$FROM" -- "$TO"
+        chown --reference="$FROM" -- "$TO" || exit
     fi
 }
 
@@ -50,12 +48,12 @@ replace_with() {
         if [[ -f $ORIG ]]; then
             copy_perms "$ORIG" "$NEW"
             if [[ -n $BACKUPSUFFIX ]]; then
-                mv -- "$ORIG" "$ORIG$BACKUPSUFFIX"
+                mv -- "$ORIG" "$ORIG$BACKUPSUFFIX" || exit
             fi
         else
-            mkdir -p -- "${ORIG%/*}"
+            mkdir -p -- "${ORIG%/*}" || exit
         fi
-        mv -- "$NEW" "$ORIG"
+        mv -- "$NEW" "$ORIG" || exit
     else
         printf 'File "%s" not modified\n' \
             "$ORIG" \
@@ -66,7 +64,7 @@ replace_with() {
 (cd "$WORKDIR" &&
     git submodule update --init 'repos-noupdates/*' &&
     git submodule update --init --remote 'repos/*'
-)
+) || exit
 
 for (( I = 0 ; I < ${#OUT[@]} ; ++I )); do
     MY_URL=${URL[$I]}
@@ -84,13 +82,13 @@ for (( I = 0 ; I < ${#OUT[@]} ; ++I )); do
 
     wget \
         -O "$TEMP_OUT" \
-        "$MY_URL"
+        "$MY_URL" || exit
 
     replace_with "$MY_OUT" "$TEMP_OUT"
 done
 
 TEMP_BLOCKLIST=$(mktemp -p "$TEMP_DIR")
-"$WORKDIR/make-block.pl" --out="$TEMP_BLOCKLIST"
+"$WORKDIR/make-block.pl" --out="$TEMP_BLOCKLIST" || exit
 
 # Blocklist generation succeeded, install it!
 
@@ -102,11 +100,11 @@ if [[ ! -e $BLOCKLIST ]]; then
     # whatever file permissions 'mktemp' sets.
     umask 0022
     touch -- "$BLOCKLIST"
-    )
+    ) || exit
 fi
 
 replace_with "$BLOCKLIST" "$TEMP_BLOCKLIST"
 
 if [[ ${#DNSMASQ_RESTART_COMMAND[@]} -gt 0 ]]; then
-    "${DNSMASQ_RESTART_COMMAND[@]}"
+    "${DNSMASQ_RESTART_COMMAND[@]}" || exit
 fi

From dc38b1a3764030d5f8a02db46abeb7446cc4c7b0 Mon Sep 17 00:00:00 2001
From: Dan Church <amphetamachine@gmail.com>
Date: Tue, 11 Jul 2023 12:55:25 -0500
Subject: [PATCH 4/4] Remove unused variable

---
 update.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/update.sh b/update.sh
index 74f1d7c..e6ac0fa 100755
--- a/update.sh
+++ b/update.sh
@@ -19,7 +19,6 @@ CFG=$WORKDIR/update.cfg
 # Config defaults
 BACKUPSUFFIX=
 BLOCKLIST=$WORKDIR/block.list
-LIST_DIR=$WORKDIR/lists
 OUT=()
 URL=()
 DNSMASQ_RESTART_COMMAND=()