From e0c91b46475bcc0bf3d134ba66ac521f76ad0dc9 Mon Sep 17 00:00:00 2001 From: Dan Church Date: Thu, 20 Jul 2023 15:00:46 -0500 Subject: [PATCH] Fix overly-complex 'map' (PBP) --- lib/Directory/Simplify/Utils.pm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lib/Directory/Simplify/Utils.pm b/lib/Directory/Simplify/Utils.pm index 54d395f..37bea38 100644 --- a/lib/Directory/Simplify/Utils.pm +++ b/lib/Directory/Simplify/Utils.pm @@ -39,12 +39,11 @@ sub hr_size { sub shell_quote { # shell-escape argument for inclusion in non-interpolated single quotes my @words = @_; - my @transformed = map { - (my $out = $_) - =~ s/'/'\\''/g; - "'$out'"; - } @words; - return wantarray ? @transformed : $transformed[0]; + foreach my $word (@words) { + $word =~ s/'/'\\''/g; + $word = "'$word'"; + } + return wantarray ? @words : $words[0]; } 1;