From 0e90c885d12b7294ef051fb8b4324ae10d813fab Mon Sep 17 00:00:00 2001 From: Linda_pp Date: Mon, 30 Sep 2019 19:17:18 +0900 Subject: [PATCH] remove host workaround for emoji URLs since github-emoji v1.1.1 fixed it (#94) --- package.json | 2 +- populate.js | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 5042b96..e1b831b 100644 --- a/package.json +++ b/package.json @@ -38,7 +38,7 @@ "commander": "^2.20.0", "ejs": "^2.6.2", "express": "^4.17.0", - "github-emoji": "^1.1.0", + "github-emoji": "^1.1.1", "got": "^9.6.0", "handlebars": "^4.1.2", "jsdom": "^15.1.0", diff --git a/populate.js b/populate.js index 9132717..262a46b 100644 --- a/populate.js +++ b/populate.js @@ -18,14 +18,9 @@ function convertToEmoji(text) { }); for (i = 0; i < str.length; i++) { if (emoji.URLS[str[i]] != undefined) { - var output = emoji.of(str[i]); - var emojiImage = output.url.replace( - "assets-cdn.github", - "github.githubassets" - ); text = text.replace( `:${str[i]}:`, - `` + `` ); } }