cd76eb7b8c
wallet: fix unused lambda capture warning
2021-08-28 15:18:32 +02:00
e52802baef
Wallet2: fix optimize-coinbase for p2pool payouts
...
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.
When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.
With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.
Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
2021-08-26 11:50:15 +02:00
8b9eea92f1
Merge pull request #7849
...
6f15a0c
2021-08-20 16:49:59 -04:00
1b079e5195
Merge pull request #7845
...
e1af8dc
2021-08-20 16:45:15 -04:00
5812b757e0
Merge pull request #7821
...
da2955f
2021-08-20 16:33:53 -04:00
24d3d65d42
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir
2021-08-20 08:54:41 -05:00
e1af8dc02c
Protect client from divide by 0 caused by integer truncation
2021-08-19 14:56:36 -07:00
da2955feae
Apply gamma distr from chain tip when selecting decoys
...
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
2021-08-19 14:51:20 -07:00
62844a776d
Merge pull request #7786
...
9c6e094fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
2021-08-11 22:30:11 -04:00
6f15a0c8d3
Make sure node returns to wallet that real output is unlocked
2021-08-11 07:28:10 -07:00
13a8a576ed
trezor: try empty passphrase first
...
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
thus this commit fixes the behaviour).
2021-08-03 13:54:04 +02:00
ed506006d2
Merge pull request #7796
...
0c6e1d3
2021-08-02 18:54:46 -04:00
eeda76570c
Merge pull request #7790
...
bc8d764
2021-08-02 18:53:05 -04:00
8c41d14ad5
Merge pull request #7788
...
f5eb2ce
2021-08-02 18:50:25 -04:00
9aa2d4c16e
Merge pull request #7747
...
8cf95c8
2021-08-02 18:42:32 -04:00
2d5b8a6ff7
Merge pull request #7740
...
8cea9d8
2021-07-27 16:55:14 -04:00
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits
2021-07-15 17:25:07 +00:00
f5eb2ce968
wallet2: Don't auto lock device on process parsed blocks
2021-07-14 13:02:54 +02:00
bc8d7644d2
wallet: rephrase error message on invalid device address
2021-07-14 11:02:29 +02:00
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor
2021-07-14 10:46:16 +02:00
7499837a6f
Merge pull request #7661
...
08e4497
2021-06-10 12:00:54 -05:00
a1a3e970f7
Merge pull request #7662
...
4da1112
2021-06-10 11:34:20 -05:00
8cf95c8f29
wallet2: refresh: check error and throw before potentially breaking out of loop
2021-06-04 18:37:06 +02:00
8cea9d8605
wallet: Reset RPC Pay ID on node switch
...
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
2021-06-04 13:58:09 +02:00
628c04499b
Merge pull request #7682
...
bbdb612
2021-05-12 15:30:34 -05:00
bbdb612b51
Wallet2: Update 'approximate_testnet_rolled_back_blocks'
2021-04-25 10:20:39 +02:00
c57ef7f807
wallet2: Fix rescan_bc keep_ki option
2021-04-23 09:11:45 -06:00
9bba3f4767
Merge pull request #7651
...
c8ff1d4
2021-04-22 01:35:20 -04:00
dc81e23e60
Split epee/string_tools.h and encapsulate boost::lexical_cast
2021-04-16 20:54:20 +02:00
4da1112967
rpc: send confirmations in get_transactions result
...
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
2021-04-15 15:31:52 +00:00
c8ff1d4d23
monero-wallet-cli: improve error message when tx amount is zero
2021-04-07 10:10:16 -04:00
2098941ca0
Merge pull request #7635
...
447bfae
2021-04-06 12:23:45 -05:00
447bfae2a4
wallet2: fix unlocked mixup in light wallet mode
2021-03-25 09:33:40 +00:00
f9b5b521e8
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:42:33 +00:00
6556c33f13
Merge pull request #7355
...
bd129841572df9
2021-02-18 14:06:47 -05:00
ce5800a225
Merge pull request #7346
...
85db173
2021-02-18 14:03:31 -05:00
0e35d46f5e
Merge pull request #7341
...
b587ffa
2021-02-18 14:02:13 -05:00
3f55f7df31
Merge pull request #7312
...
186271e
2021-02-18 14:00:35 -05:00
186271e5d1
monero-wallet-cli: Added command scan_tx
...
To implement this feature, the wallet2::scan_tx API was implemented.
2021-02-17 20:25:55 +01:00
4ee301c687
Merge pull request #6986
...
ee58f4f
2021-02-15 21:36:48 -05:00
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
1572df9e26
Removing unused namespace alias
2021-01-28 23:40:57 -05:00
520ce1ca81
Attempt to carve the fee from a partial payment early
...
Do this for both the estimate and actual fee.
#7337
2021-01-25 12:01:27 +13:00
b587ffa1fd
Stop adding more outputs than bulletproof allows
...
If more outputs are requested, they are split across
multiple transactions.
#7322
2021-01-25 10:01:38 +13:00
08e4497c6e
Improve cryptonote (block and tx) binary read performance
2021-01-23 06:23:39 +00:00
d2fda6c25f
restrict public node checks a little
...
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
ee58f4f766
Balance includes unconfirmed payments
2020-11-06 15:08:43 -05:00
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00
6b8db83149
Merge pull request #7043
...
17c537039
2020-12-04 13:25:01 -08:00
89bbb802c0
wallet2: set propagation timeout to current max timeout
2020-12-03 02:18:58 +01:00
438442ace0
Merge pull request #6890
...
ec14e4b8c
2020-12-01 14:18:22 -08:00
17c5370398
wallet2: check imported multisig curve points are in main subgroup
2020-11-24 16:25:35 +00:00
fc2f97177b
wallet2: wait for propagation timeout before marking tx as failed
2020-10-18 14:00:56 +00:00
ec14e4b8cd
wallet2: skip reorgs exceeding max-reorg-depth wallet setting
2020-10-13 15:23:35 +00:00
b6c4f8cd54
fix a couple bugs found by OSS-fuzz
...
- index out of bounds when importing outputs
- accessing invalid CLSAG data
2020-09-24 15:30:38 +00:00
2b1488ef6f
Merge pull request #6793
...
de9a9fb
2020-09-15 19:56:49 -05:00
80e535c95a
wallet2: adapt to deterministic unlock time
2020-09-15 11:40:31 +00:00
9bba1a24ea
Merge pull request #6815
...
ef4325f
2020-09-14 11:47:06 -05:00
ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs
2020-09-12 17:51:41 +00:00
a3844e257e
Fix typo in command line argument description
2020-09-09 10:18:32 -04:00
fd657c7706
Merge pull request #6798
...
4e44306
2020-09-07 14:30:41 -05:00
4e4430603f
enable CLSAG support for Trezor client
2020-09-04 01:24:58 +02:00
ee0b02d0db
Merge pull request #6757
...
6a37da8
2020-09-03 12:25:59 -05:00
de9a9fb340
update error message "No unlocked balance in the specified account"
2020-09-01 17:30:00 -04:00
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
fa06c39d97
Bind signature to full address and signing mode
2020-08-28 19:38:00 -04:00
743608ec16
wallet: allow signing a message with spend or view key
2020-08-28 19:25:17 -04:00
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
4fe2858b4d
Merge pull request #6746
...
20f603c6b
2020-08-27 02:58:53 -07:00
a06c83db73
Merge pull request #6752
...
85899230de916201f1
2020-08-27 02:58:23 -07:00
42519b48a7
Merge pull request #6731
...
db5d6e460
2020-08-27 02:55:48 -07:00
bad5d8d6f0
Merge pull request #6690
...
7175dcb10
2020-08-27 02:54:30 -07:00
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption"
...
This reverts commit 921dd8dde5
2020-08-17 14:08:59 -05:00
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
01b512f3a9
Merge pull request #6716
...
76c16822d
2020-08-16 12:52:21 -07:00
f40b9e34e0
Merge pull request #6715
...
3d6bc0a68
2020-08-16 12:51:57 -07:00
8f02e7a7fc
Merge pull request #6632
...
ef694d028
2020-08-16 12:44:59 -07:00
6d29ee6c52
Merge pull request #6493
...
921dd8dde
2020-08-16 12:39:59 -07:00
85899230d1
simplewallet: allow setting tx keys when sending to a subaddress
...
The tx key derivation is different then
2020-08-10 21:25:51 +00:00
921dd8dde5
Use domain-separated ChaCha20 for in-memory key encryption
2020-08-09 19:11:54 -04:00
6bfcd31015
Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.
2020-08-09 18:42:15 -04:00
e916201f12
wallet2: fix setting tx keys when another is already set
...
insert doesn't actually insert if another element with the
same key is already in the map
2020-08-08 14:40:03 +00:00
20f603c6be
Fix broken multisig pubkey sorting
...
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal. This means:
- it isn't actually sorting.
- it can (and does) segfault for some inputs.
2020-08-05 12:42:27 -03:00
db5d6e4602
wallet2: fix wrong name when checking RPC cost
2020-07-31 14:17:23 +00:00
76c16822d0
wallet2_api: implement runtime proxy configuration
2020-07-20 13:45:12 +00:00
3d6bc0a680
wallet2: throw a error on wallet initialization failure
2020-07-20 04:40:34 +00:00
a0d179e528
Merge pull request #6512
...
5ef0607da
2020-07-19 03:32:59 -07:00
340e1943ac
Merge pull request #6587
...
94befec
2020-07-08 17:14:09 -05:00
c4f4091dd4
Merge pull request #6561
...
c17fe81
2020-06-08 14:21:33 -05:00
3a577f1ce7
Merge pull request #6525
...
86cf811
2020-06-08 14:07:45 -05:00
ef694d028f
fix warning by removing std::move() on temporary http_client object
2020-06-06 11:38:32 -04:00
7aeb503547
Fix boost <1.60 compilation and fix boost 1.73+ warnings
2020-05-31 21:18:11 -04:00
94befecb05
fix typo in pick_preferred_rct_inputs
2020-05-25 03:39:54 +07:00
c17fe815a2
wallet2: fix multisig data clearing stomping on a vector
2020-05-19 10:45:40 +00:00
86cf811a39
simplewallet: don't complain about incoming payment ids on change
2020-05-13 23:28:31 +00:00
4c2f78aeeb
Merge pull request #6506
...
42e1484
2020-05-07 10:43:05 -05:00
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
3de804f1e9
Merge pull request #6485
...
7a8c1ee
2020-05-06 00:31:51 -05:00
9e3f72c375
Merge pull request #6480
...
4f489fa
2020-05-06 00:28:18 -05:00
6d1f3c9acd
Merge pull request #6467
...
8b655de
2020-05-05 23:40:44 -05:00
b4023dcfc5
Merge pull request #6441
...
613071f
2020-05-05 23:39:32 -05:00
42e14840fb
wallet2: fix keys file deserialization exception handling
2020-05-05 16:34:50 +00:00
c9b800a787
Merge pull request #6446
...
e509ede
2020-05-01 15:32:52 -05:00
7a8c1eece9
wallet2: fix subaddress expansion when receiving monero
2020-04-27 16:48:19 +00:00
e509ede2aa
trezor: adapt to new passphrase mechanism
...
- choice where to enter passphrase is now made on the host
- use wipeable string in the comm stack
- wipe passphrase memory
- protocol optimizations, prepare for new firmware version
- minor fixes and improvements
- tests fixes, HF12 support
2020-04-27 18:17:56 +02:00
4f489fa6a2
wallet2: check_connection return false on get_version status != OK
2020-04-26 13:08:17 +00:00
8b655de8ed
simplewallet: report timestamp based expected unlock time on balance
2020-04-22 13:34:58 +00:00
87d75584e8
Allow wallet2.h to run in WebAssembly
...
- Add abstract_http_client.h which http_client.h extends.
- Replace simple_http_client with abstract_http_client in wallet2,
message_store, message_transporter, and node_rpc_proxy.
- Import and export wallet data in wallet2.
- Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
2020-04-15 13:22:46 -04:00
613071f4fa
use memwipe on secret k/alpha values
...
Reported by UkoeHB_ and sarang
2020-04-15 01:16:31 +00:00
bce050ee78
Merge pull request #6394
...
69b5992
2020-04-10 16:06:10 -05:00
69b5992296
simplewallet: new "address one-off <major> <minor>" command
2020-04-07 16:25:01 +00:00
cfc0f4a7fa
Merge pull request #6351
...
81c59435fcc23a3387f0e
2020-04-04 12:55:02 -05:00
081d49c59f
Merge pull request #6338
...
80d5320
2020-04-04 12:44:45 -05:00
ab802b4b80
Merge pull request #6321
...
1a6e7bd
2020-04-04 12:37:26 -05:00
80d5320fff
Hash domain separation
2020-04-01 08:31:00 -04:00
6d6af701ec
cryptonote_basic: drop unused verification_context::m_not_rct field
2020-03-31 21:58:25 +00:00
f9de65b546
Merge pull request #6304
...
2e9d1e6
2020-03-31 15:13:19 -05:00
d0065f3063
Merge pull request #6302
...
dab604e
2020-03-31 15:12:48 -05:00
72262b348a
Merge pull request #6299
...
9c1f970b
2020-03-27 12:33:15 -07:00
5780594202
Merge pull request #6296
...
50e59cfa
2020-03-27 12:31:59 -07:00
8cb005b39c
Merge pull request #6289
...
ffe7165e
2020-03-27 12:28:29 -07:00
5ba6eef272
Merge pull request #6288
...
0349347e7b882087f507a43a
2020-03-27 12:23:59 -07:00
d500bbe68f
Merge pull request #6268
...
a6c24412
2020-03-12 01:02:31 -07:00
5fcc23ae0a
Move hex->bin conversion to monero copyright files and with less includes
2020-03-09 05:23:59 +00:00
9c1f970b82
wallet2: remember daemon address overrides when loading a new wallet
2020-03-07 18:09:31 +00:00
da617ac1b0
Merge pull request #6238
...
f717d593
2020-02-28 20:21:06 -08:00
a6cf4b09e7
Merge pull request #6235
...
5cbb17b9
2020-02-28 19:48:41 -08:00
2de1137e60
Merge pull request #6194
...
316ab7b
2020-02-19 22:23:46 -05:00
22a0367398
Merge pull request #6190
...
096a9db
2020-02-19 22:22:36 -05:00
1a6e7bd40f
wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg
2020-02-07 10:02:27 +00:00
995f34b538
Merge pull request #6103
...
4b384003
2020-02-06 00:33:18 -08:00
3b224bb99d
Merge pull request #6069
...
d64e5aa7
2020-02-06 00:29:32 -08:00
dd8c6b1703
wallet: do not split integrated addresses in address book api
2020-01-26 00:03:53 +00:00
dab604e010
wallet2_api: implement estimateTransactionFee
2020-01-25 05:34:51 +00:00
159c78758a
Merge pull request #6154
...
3b419333
2020-01-24 20:07:01 -08:00
2e9d1e6e1f
wallet2: fix store-tx-info loading
...
The backward compatibility code was always setting it to 1
in modern wallets since store_tx_keys was not present and thus
assumed to be 1 by default.
Reported by SeventhAlpaca
2020-01-24 16:34:07 +00:00
50e59cfada
wallet2: reject zero keys in json input
...
Because the user might do this for reasons unknown.
Values beyond l-1 will be reduced, so are accepted.
Reported by who-biz.
2020-01-16 19:58:21 +00:00
ffe7165ebf
wallet: reroll fake outs selection on local tx_sanity_check failure
2020-01-14 22:56:23 +00:00
d024695772
Merge pull request #6105
...
0de8a0d3
2020-01-11 18:04:49 -08:00
096a9dbdf9
Wallet: Distingush amounts for a single subaddress
...
Adding a new `amounts` field ot the output of `get_transfers` RPC
method. This field specifies individual payments made to a single
subaddress in a single transaction, e.g., made by this command:
transfer <addr1> <amount1> <addr1> <amount2>
2020-01-11 11:48:27 +01:00
f507a43a23
wallet2: do not remove known rings when a tx fails
...
Even if it fails, the ring composition is known to a potential
adversary, and so we should reuse the same ring next time
2020-01-09 17:32:21 +00:00
d64e5aa719
wallet: allow message sign/verify for subaddresses
2019-12-31 08:44:36 +00:00
a6c24412e5
wallet: fix exceptions getting the hash of a pruned tx
2019-12-30 15:14:57 +00:00
f717d5936c
wallet2: guard against race with multiple decrypt_keys users
...
If more than one thread wants to make sure of the spend secret key,
then we decrypt on the first caller and reencrypt on the last caller,
otherwise we could use an invalid secret key.
2019-12-17 01:38:29 +00:00
5cbb17b946
wallet2: fix hang in wallet refresh
...
If the hashes received would move the current blockchain past the
stop point, the short history would not be updated, since we do
not expect another loop, but the daemon might return earlier hashes,
causing the end index to not be enough to reach the threshold and
this require another loop, which will download the same hashes and
cause an infinite loop.
2019-12-14 16:24:04 +00:00
b4e1dc83d2
Merge pull request #6057
...
3b8dcc2
2019-12-12 13:49:58 -06:00
316ab7b56e
wallet2: better error when restoring a wallet with the wrong keys
2019-11-28 18:22:29 +00:00
3b41933335
wallet: don't issue node rpc proxy requests in '--offline' mode
2019-11-19 03:26:42 +00:00
0de8a0d37d
wallet_rpc_server: new estimate_tx_size_and_weight RPC
2019-11-06 15:18:21 +00:00
4b38400336
wallet2: don't try to lock an empty filename
2019-11-05 15:33:01 +00:00
selsta
SChernykh
luigi1111
Kermit Alexander II
j-berman
Dusan Klinec
moneromooo-monero
tobtoht
rbrunner7
Nathan Dorfman
mj-xmr
Elliot Wirrick
Horia Mihai David
Kevin Barbour
Lee Clagett
Alex Opie
woodser
Alexander Blair
Crypto City
xiphon
TheCharlatan
Reinaldulin
Sarang Noether
Jason Rhinelander
Denis Smirnov
SomaticFanatic
Tadeas Moravec