moneromooo-monero
2112060d03
wallet2: fix duplicate tx notifications for pool txes
2019-01-13 14:47:42 +00:00
moneromooo-monero
11227e0ba2
mnemonics: compare canonical words (lowercase)
2019-01-11 16:45:48 +00:00
selsta
6c060e6aaa
device: proper handling of user input
...
(1) If the user denies something on the Ledger,
a proper error message is now shown.
(2) Ledger doesn't time out anymore while waiting
on user input.
(3) Lower the timeout to 2 seconds, this is enough for
normal Ledger <-> System communication.
2019-01-09 15:45:06 +01:00
moneromooo-monero
8258a9e7a9
wallet: do not check txpool in background mode
...
This avoids the constant message about needed to run refresh
to enter a password.
Also mention the txpool when asking for the password if the
reason is a pool tx.
2019-01-09 11:21:39 +00:00
selsta
93c2164434
device_ledger: remove full_name variable
...
This variable was never set, resulting in the
device name always showing as "disconnected".
2019-01-09 05:33:49 +01:00
moneromooo-monero
584126d15b
i18n: filter LANG/LC_LANG for valid characters, and handle @
...
If there are more valid characters, add them in, I did not find
an actual list.
2019-01-08 16:03:30 +00:00
stoffu
07cb574ca4
ringct: remove duplicate rv.mixRing = mixRing; in genRctSimple
2019-01-08 11:51:35 +09:00
Riccardo Spagni
094b0c4d00
Merge pull request #5045
...
050ee521
2019-01-07 21:27:34 +02:00
Riccardo Spagni
4902b2ad3d
Merge pull request #5016
...
434a147b
2019-01-07 21:27:14 +02:00
Riccardo Spagni
53fba1455c
Merge pull request #5007
...
68f095f0
2019-01-07 21:26:52 +02:00
moneromooo-monero
0a29660f5c
message_store: init me field
...
Coverity 190651
2019-01-07 16:41:34 +00:00
moneromooo-monero
a67b77a9eb
blockchain: don't propagate exception past dtor
...
Coverity 190660
2019-01-07 16:32:50 +00:00
moneromooo-monero
050ee52162
wallet_api: fix usage of LOG_ERROR
2019-01-07 11:57:10 +00:00
moneroexamples
ec68cf822f
Make get_output_key method const
...
get_output_key method is commonly used when working with txs and their key images. Because the method is not const, passing blockchain object though const& or pointers to const is not possible in this context. This is especially problematic in external projects (e.g., projects in moneroexamples) that use monero C++ api to operate on the blockchain and txs.
Thus, having get_output_key method will simplify moving blockchain object around through const references and pointers to const objects.
2019-01-07 05:53:14 +08:00
Riccardo Spagni
b67eb481a7
Merge pull request #4956
...
2d7b0236
2019-01-06 20:40:06 +02:00
Riccardo Spagni
be625a95af
Merge pull request #4954
...
93c59b296a507dabc1581a5b
2019-01-06 20:39:29 +02:00
Riccardo Spagni
577a8f5c84
Merge pull request #4952
...
570dd369
2019-01-06 20:39:07 +02:00
Riccardo Spagni
13b006137c
Merge pull request #4949
...
5464725a85807dfb
2019-01-06 20:37:51 +02:00
Riccardo Spagni
ad1eb3338c
Merge pull request #4938
...
a13eb0a13a3858dc
2019-01-06 20:36:46 +02:00
rbrunner7
c108109102
simplewallet: Show new address after going multisig
2019-01-04 16:33:02 +01:00
selsta
13785ec96b
wallet api/device: set estimated restore height if none is provided
2019-01-02 11:25:49 +01:00
moneromooo-monero
53fcd15953
simplewallet: don't subtract 1 to estimate blockchain height
...
in case it returns 0, and other uses don't, plus it's a estimation anyway.
2019-01-02 00:55:19 +00:00
moneromooo-monero
5ee6f03742
blockchain: fix wrong hf version when popping multiple blocks
...
Since we keep track of the hf version in the db, we pick it up
from there instead of doing the full reorg call, which is quite
expensive
2019-01-01 18:28:01 +00:00
moneromooo-monero
634d359a84
blockchain: use the version passed as parameter, not a new one
2019-01-01 18:28:01 +00:00
moneromooo-monero
94a375d559
hardfork: remove batch transactions setup
...
This is now default, so it spares us the warnings
2019-01-01 18:28:01 +00:00
moneromooo-monero
5dc590cbdb
wallet2: speedup output tracking
...
It can get heavy for large wallets
2018-12-31 23:57:54 +00:00
moneromooo-monero
db3f2a91fa
wallet: optionally keep track of owned outputs uses
2018-12-31 23:57:51 +00:00
luigi1111
e344d93ce7
Merge pull request #4960
...
b56b5b5
2018-12-31 16:32:12 -06:00
luigi1111
53760ee044
Merge pull request #4957
...
0e2f5cb
2018-12-31 16:30:47 -06:00
luigi1111
1aaa82cb1a
Merge pull request #4955
...
25e5a85
2018-12-31 16:28:49 -06:00
luigi1111
61c0083105
Merge pull request #4953
...
dbbb3ce
2018-12-31 16:26:22 -06:00
luigi1111
a872a2a41a
Merge pull request #4948
...
1d892ec
2018-12-31 16:10:30 -06:00
luigi1111
69e8567c0e
Merge pull request #4946
...
6644b9bce594f583326985511563d1efe3d9cc68a2
2018-12-31 16:06:50 -06:00
luigi1111
9c2d671397
Merge pull request #4945
...
e37154a
2018-12-31 15:53:59 -06:00
luigi1111
6e4e228461
Merge pull request #4944
...
1505dd3db57374
2018-12-31 15:52:17 -06:00
luigi1111
c7af379d29
Merge pull request #4940
...
9e64a71
2018-12-31 15:44:49 -06:00
luigi1111
3adac4ee2b
Merge pull request #4929
...
5a76933
2018-12-31 15:31:01 -06:00
luigi1111
6d3caaff70
Merge pull request #4928
...
affff94
2018-12-31 15:28:25 -06:00
luigi1111
a7ff63ec77
Merge pull request #4898
...
e6f026e
2018-12-31 15:15:46 -06:00
luigi1111
c93c638199
Merge pull request #4864
...
707c2f8
2018-12-31 15:13:59 -06:00
moneromooo-monero
d1b3990d40
p2p: don't stop the idle thread when no gray peers are found
2018-12-30 19:32:38 +00:00
moneromooo-monero
9092fc4bfd
wallet: do not display daemon controlled text if untrusted
2018-12-30 01:32:57 +00:00
moneromooo-monero
8bd716777e
simplewallet: remove ability to transfer with detached short payment ids
...
It seemed like a good idea at the time
2018-12-27 00:45:04 +00:00
moneromooo-monero
65ce387c93
daemon: add a +hex option to print_block
2018-12-26 17:55:28 +00:00
moneromooo-monero
d24c325c7d
daemon: print human friendly timestamp too
2018-12-26 14:01:18 +00:00
moneromooo-monero
434a147b57
blocks: fix checkpoint code generation on OpenBSD
...
Its od outputs small decimals with leading 0, which means octal in C
2018-12-25 19:11:39 +00:00
moneromooo-monero
6f2081f867
cryptonote_core: revert extra_tx_map
...
While the lookups are faster, the zeroCommit calls have to be
done again when storing the new outputs in the db, which ends
up making the whole thing slower after all, and the ways this
can be cached aren't very nice code wise, so let's forget it
since the gains aren't very large anyway.
2018-12-25 15:19:41 +00:00
moneromooo-monero
d7354c7864
wallet_rpc_server: add all field to export_key_images
...
To use if you want all key images, not just the ones for
recently imported outputs
2018-12-24 13:00:29 +00:00
Tadeas Moravec
e6f026e530
Simplewallet: Unify usage messages.
...
Help messages describe the commands usage. When users run the command
with wrong arguments, it usually helpfully offers the usage, too.
Unfortunately, these two usage messages were duplicated in the code and
started to get out of sync.
Fixing with constant strings.
2018-12-23 20:12:50 +00:00
moneromooo-monero
85665003a7
epee: better network buffer data structure
...
avoids pointless allocs and memcpy
2018-12-23 16:46:07 +00:00
moneromooo-monero
5e10dee3ea
simplewallet: fix show_transfers colouring, and add red for failed
...
Also add the type back, as it was somehow weirdly split into
two different fields, one being a union...
2018-12-23 15:15:55 +00:00
Lee Clagett
a5ffc2d5ad
Remove boost::lexical_cast for uuid and unused uuid function
2018-12-23 11:11:30 +00:00
moneromooo-monero
68f095f059
message_store: fix error message adding const char * with offset
2018-12-22 15:52:10 +00:00
stoffu
7c58421c79
blockchain_blackball: make log file name consistent with executable
2018-12-22 14:46:35 +09:00
moneromooo-monero
de9dcdd179
wallet2: finalize_multisig now rejects non N-1/N multisig wallets
2018-12-21 23:41:16 +00:00
doy-lee
99765b218e
Remove unused hash in export_key_images
2018-12-19 14:45:13 +11:00
Dusan Klinec
c5e0539cb5
device/trezor: store tx_prefix_hash in tx key aux
...
- tx_prefix_hash is required in the key derivation for decryption of the tx keys
2018-12-18 22:20:18 +01:00
moneromooo-monero
b8342dd52c
blockchain: fix block rate check for empty blockchains
2018-12-18 18:47:54 +00:00
Dusan Klinec
e37154a879
build: protobuf dependency fixes, libusb build
...
- docker protobuf dependencies, cross-compilation
- device/trezor protobuf build fixes, try_compile
- libusb built under all platforms, used by trezor for direct connect
2018-12-18 16:50:19 +01:00
moneromooo-monero
008647d7eb
blockchain_db: speedup tx output gathering
...
We know all the data we'll want for getblocks.bin is contiguous
2018-12-18 11:55:21 +00:00
moneromooo-monero
808a1f1e8a
wallet2: cut down on the number of useless derivation threads
2018-12-16 18:31:10 +00:00
moneromooo-monero
841a6acda2
wallet2: fix accessing unwound stack on exception
2018-12-16 18:30:02 +00:00
Howard Chu
60b35c91b9
Add --restore-date param
...
Estimate restore height from given date
Check date format early, error out early if invalid
2018-12-14 19:11:35 +00:00
naughtyfox
219548f299
Sync hashchain bug fixed
2018-12-14 17:42:11 +03:00
Tadeas Moravec
611db08a00
Wallet: Initialize members without default ctor.
...
Found by Coverity (188336 in Anonimal's Coverity account).
2018-12-14 13:45:41 +00:00
rbrunner7
1ebcd7b9b0
MMS (Multisig Messaging System): Initial version
2018-12-12 21:49:20 +01:00
moneromooo-monero
aaafa8a946
ringct: avoid repeated point conversion
2018-12-12 12:48:10 +00:00
Riccardo Spagni
6bc0c7e685
Merge pull request #4927
...
6456cb41
2018-12-12 12:01:31 +02:00
Riccardo Spagni
5e9225e637
Merge pull request #4925
...
ab783b179b69a0ae4d71d463
2018-12-12 12:01:18 +02:00
Riccardo Spagni
51874e5a40
Merge pull request #4924
...
0c5dd316
2018-12-12 12:00:50 +02:00
Riccardo Spagni
fe3c8c9682
Merge pull request #4923
...
aba9a9c2
2018-12-12 12:00:37 +02:00
Riccardo Spagni
e9aa886d9e
Merge pull request #4921
...
ac665418
2018-12-12 11:59:56 +02:00
Riccardo Spagni
e19a205ff4
Merge pull request #4920
...
e98ae34e
2018-12-12 11:59:43 +02:00
Riccardo Spagni
83684ea515
Merge pull request #4909
...
756684bb
2018-12-12 11:59:25 +02:00
Riccardo Spagni
4556f0e2b8
Merge pull request #4908
...
5ca4994c
2018-12-12 11:59:04 +02:00
Riccardo Spagni
0fccc78e39
Merge pull request #4903
...
dc1c1252
2018-12-12 11:58:37 +02:00
Riccardo Spagni
d855f9bb92
Merge pull request #4901
...
a48f2dab17b45725
2018-12-12 11:57:31 +02:00
Riccardo Spagni
85262ca8cd
Merge pull request #4899
...
2be31b4c
2018-12-12 11:56:21 +02:00
Riccardo Spagni
c73ac91af8
Merge pull request #4897
...
9b5efad2
2018-12-12 11:55:13 +02:00
Riccardo Spagni
0b31baf6e4
Merge pull request #4839
...
d71f89e265b9bca79cf636afd21dad70318cc784
2018-12-12 11:53:42 +02:00
Riccardo Spagni
dde1e69723
Merge pull request #4787
...
3dba7f25
2018-12-12 11:53:10 +02:00
Jethro Grassie
b56b5b52eb
ignore child process when exec
2018-12-08 20:52:54 -05:00
moneromooo-monero
0e2f5cb5fc
perf_timer: make all logs Info level
...
and make them not default at log level 1
2018-12-08 10:53:09 +00:00
moneromooo-monero
2d7b0236eb
wallet2: clear all payments on soft rescan_bc
...
They'll get duplicated otherwise
2018-12-08 10:39:54 +00:00
moneromooo-monero
3a3858dc90
epee: avoid string allocation when parsing a pod from string
2018-12-08 02:00:34 +00:00
moneromooo-monero
25e5a8539c
singleton: fix missing *this return value in operator=
...
while there, disable both operator= and copy ctor, since they
are not supposed to be around for a singleton
2018-12-07 16:56:59 +00:00
moneromooo-monero
93c59b29a8
perf_timer: check allowed categories before logging
2018-12-07 14:23:47 +00:00
moneromooo-monero
6a507dab6f
perf_timer: add a way to get and reset the current time
2018-12-07 14:23:47 +00:00
moneromooo-monero
c1581a5bb8
perf_timer: only log to file
2018-12-07 14:23:47 +00:00
moneromooo-monero
dbbb3ce9d8
cryptonote: don't serialize for blob size if already known
2018-12-07 14:07:26 +00:00
moneromooo-monero
570dd3690e
p2p: use vector instead of list for peer lists
2018-12-07 13:20:34 +00:00
moneromooo-monero
5464725a29
protocol: change standby mode to not wait sleeping
2018-12-07 12:53:11 +00:00
selsta
1d892ec881
simplewallet: donate command validate amount
2018-12-07 13:43:21 +01:00
moneromooo-monero
db5737413e
util: use fcntl instead of flock, for compatibility
...
in particular with NFS
2018-12-06 12:59:29 +00:00
moneromooo-monero
9cc68a2f74
tx_pool: add a few std::move where it can make a difference
2018-12-05 21:13:37 +00:00
moneromooo-monero
d1efe3d91c
cryptonote: set tx hash on newly parsed txes when known
2018-12-05 21:13:29 +00:00
moneromooo-monero
5511563e92
db_lmdb: avoid pointless division
2018-12-05 21:13:24 +00:00
moneromooo-monero
833269834d
db_lmdb: inline check_open, it's trivial and called everywhere
2018-12-05 21:13:21 +00:00
moneromooo-monero
ce594f5af7
blockchain_db: allocate known size vector only once
2018-12-05 21:13:18 +00:00
moneromooo-monero
6644b9b7b7
blockchain_db: remove a couple unused functions
2018-12-05 21:13:13 +00:00
moneromooo-monero
1505dd38c9
util: set MONERO_DEFAULT_LOG_CATEGORY
...
Otherwise it'd end up with whatever was included last
2018-12-05 14:53:30 +00:00
moneromooo-monero
9e64a71e7d
blockchain: call deinit in dtor
...
This ensures the io service that runs in another thread cannot
access data after it's deleted
2018-12-05 00:13:28 +00:00
Dusan Klinec
d71f89e2a2
device/trezor: device/trezor: correct device initialization, status check
...
- checks if the device is in the correct usable state
- implements check for the v2.0.9 firmware which does not support payment IDs
- simple transacttion check, payment id fmt consistency
- minor fixes, refactoring, webusb session counting fix
2018-12-04 20:12:03 +01:00
Dusan Klinec
65b9bca70e
device/trezor: python2 compatibility - bundle dependencies
2018-12-04 18:38:18 +01:00
Dusan Klinec
9cf636af69
device/trezor: ask for KI sync on first refresh
...
When doing a first refresh on HW-token based wallet KI sync is required if money were received. Received money may indicate wallet was already used before the restore I.e., some transaction could have been already sent from the wallet. The spent UTXO would not be detected as spent which could lead to double spending errors on submitting a new transaction.
Thus if the wallet is HW-token based with the cold signing protocol and the first refresh detected received money the user is asked to perform the key image sync.
2018-12-04 18:38:17 +01:00
Dusan Klinec
d21dad70dd
device: enable to use multiple independent device wallets
...
- adds a new option `--hw-device-deriv-path` to the simple wallet. Enables to specify wallet derivation path / wallet code (path avoided so it can be misinterpreted as a file path).
- devices can use different derivation mechanisms. Trezor uses standard SLIP-10 mechanism with fixed SLIP-44 prefix for Monero
- Trezor: when empty, the default derivation mechanism is used with 44'/128'/0'. When entered the derivation path is 44'/128'/PATH.
- Trezor: the path is always taken as elements are hardened (1<<31 bit turned on)
2018-12-04 18:38:16 +01:00
Riccardo Spagni
7e957c162a
Merge pull request #4879
...
243f010e
2018-12-04 17:34:57 +02:00
Riccardo Spagni
5ed45acaec
Merge pull request #4906
...
506472e0
2018-12-04 17:33:53 +02:00
Riccardo Spagni
81418cb281
Merge pull request #4894
...
aee7a4e31a0733e50dac3c645d9915abd4f50cb16116397130023074
2018-12-04 17:33:19 +02:00
Riccardo Spagni
6d1c2a9304
Merge pull request #4892
...
c28e3d2d
2018-12-04 17:32:42 +02:00
moneromooo-monero
243f010edc
rpc: mask values that are nobody else's business in restricted RPC
2018-12-04 15:32:21 +00:00
Riccardo Spagni
0e0777e4d1
Merge pull request #4888
...
b0d9d605
2018-12-04 17:31:43 +02:00
Riccardo Spagni
6e74aa9a6c
Merge pull request #4885
...
b5573fc2
2018-12-04 17:31:27 +02:00
Riccardo Spagni
1bebe99496
Merge pull request #4884
...
56e616e8
2018-12-04 17:31:15 +02:00
Riccardo Spagni
302fd80826
Merge pull request #4882
...
6bfcc573
2018-12-04 17:30:30 +02:00
Riccardo Spagni
e799fc87ae
Merge pull request #4866
...
9c923badec1a62b5
2018-12-04 17:30:11 +02:00
Riccardo Spagni
d4a0fb2b89
Merge pull request #4880
...
96e6b439
2018-12-04 17:29:46 +02:00
Riccardo Spagni
e282e9fa40
Merge pull request #4878
...
517f25ef
2018-12-04 17:28:24 +02:00
Riccardo Spagni
868630c1db
Merge pull request #4877
...
c25260f5
2018-12-04 17:16:52 +02:00
moneromooo-monero
ec1a62b50d
move int-util.h to epee
2018-12-04 15:14:29 +00:00
Riccardo Spagni
a605c0da08
Merge pull request #4872
...
fc99f177
2018-12-04 17:13:21 +02:00
Riccardo Spagni
e7d30780de
Merge pull request #4869
...
60f36386
2018-12-04 17:12:47 +02:00
Riccardo Spagni
eba668c6ad
Merge pull request #4862
...
3998a9373900fb77
2018-12-04 17:09:40 +02:00
Riccardo Spagni
11d86f6008
Merge pull request #4859
...
6f2497bc
2018-12-04 17:09:21 +02:00
Riccardo Spagni
c00ac446fd
Merge pull request #4854
...
bd98e99c
2018-12-04 17:08:42 +02:00
Riccardo Spagni
398f7076bb
Merge pull request #4853
...
2b3595d0
2018-12-04 17:07:51 +02:00
Riccardo Spagni
94288d7d1d
Merge pull request #4845
...
6732fc7f
2018-12-04 17:06:04 +02:00
TheCharlatan
5a76933903
Add glibc back compat code
...
To ensure that the binaries compiled by gitian run across many linux
distributions, enforce 2.17 as the minimum libc version supported.
2018-12-04 02:21:06 +01:00
moneromooo-monero
affff949f9
blockchain: fix race between two external mining threads
2018-12-02 13:08:41 +00:00
Tadeas Moravec
6456cb415a
Bulletproof: Initialize members in default construtor.
...
Fixing a build warning on g++ 7.3.0
2018-12-01 13:03:32 +00:00
moneromooo-monero
9b69a0ae01
daemon: print monero version at startup when calling a detached daemon
...
So people who want a timstamp get a timestamp
2018-11-30 17:55:16 +00:00
moneromooo-monero
0c5dd3161b
cryptonote: add a set_null for transaction_prefix
...
Since it's all inline, I suspect the compiler will merge the
duplicate stores anyway.
2018-11-30 15:11:43 +00:00
moneromooo-monero
aba9a9c277
daemon: stop miner before we bring the whole thing down
...
This avoids the miner erroring out trying to submit blocks
to a core that's already shut down (and avoids pegging
the CPU while we're busy shutting down).
2018-11-30 15:10:25 +00:00
moneromooo-monero
ac665418f0
ringct: fix dummy bulletproofs on ledger in fake mode
...
Ledger does some basic checks on them
2018-11-30 13:33:29 +00:00
Dusan Klinec
318cc78457
device/trezor: passphrase entry on host
...
- simple device callback object added. Device can request passphrase/PIN entry via the callback or notify user some action is required
- callback is routed to wallet2, which routes the callback to i_wallet_callback so CLI or GUI wallets can support passphrase entry for HW tokens
- wallet: device open needs wallet callback first - passphrase protected device needs wallet callback so user can enter passphrase
2018-11-29 04:33:41 +01:00
Jason Wong
dc1c12528d
add command pop_blocks
...
add new public method to Blockchain and update according to code review
update after review: better lock/unlock, try catch and coding style
2018-11-28 12:20:28 +01:00
moneromooo-monero
a48f2dab00
blockchain_prune_known_spent_data: blackball file is now optional
...
If not present, the tool will scan the blockchain, since scanning
for this is fairly fast.
2018-11-27 15:45:47 +00:00
moneromooo-monero
17b45725af
Outputs where all amounts are known spent can now be pruned
...
Only for pre rct for obvious reasons.
Note: DO NOT use a known spent list which includes outputs
which are not known spent. If the list includes any output
that's just strongly thought to be spent, but not provably
so, you risk finding yourself unable to sync past the point
where that output is spent.
I estimate only 200 MB saved on current mainnet though,
unless the new blackballing rule unearths a good amount of
large-amount-set extra spent outs.
2018-11-27 15:45:42 +00:00
moneromooo-monero
756684bb28
blockchain: avoid unnecessary DB lookups when syncing
...
Some of the inputs for block in a span will be from other earlier
blocks in that span. Keep track of those outputs so we don't have
to look them up again after those early blocks are added to the
blockchain.
2018-11-27 14:03:06 +00:00
moneromooo-monero
5ca4994c9c
rpc: speed up the common get_output_distribution case while syncing
2018-11-27 14:01:40 +00:00
moneromooo-monero
e98ae34e4b
core: fix adding new pre-hoh block when a tx is already in the pool
2018-11-26 23:45:01 +00:00
stoffu
0e2a5d75de
simplewallet: use is_transfer_unlocked instead of is_tx_spendtime_unlocked for show_transfers
...
Followup on #4728
2018-11-27 07:50:16 +09:00
Riccardo Spagni
58ce16d4d9
Merge pull request #4821
...
fc98f7a0
2018-11-26 21:51:27 +02:00
moneromooo-monero
fc98f7a0a1
rpc: speedup get_outs.bin
2018-11-26 18:56:23 +00:00
Riccardo Spagni
3e2abc9eaa
Merge pull request #4834
...
2c7195d8
2018-11-26 20:30:15 +02:00
Riccardo Spagni
4a64303d71
Merge pull request #4831
...
c5ee14ae
2018-11-26 20:29:06 +02:00
Riccardo Spagni
c4fd8ce97e
Merge pull request #4830
...
dffec258
2018-11-26 20:28:49 +02:00
Riccardo Spagni
eccb9b08c4
Merge pull request #4825
...
b9b307d1
2018-11-26 20:28:02 +02:00
Riccardo Spagni
b37ce24cdd
Merge pull request #4824
...
2ffe53d9
2018-11-26 20:27:29 +02:00
Riccardo Spagni
cc1ea0b651
Merge pull request #4816
...
1a4d1603
2018-11-26 20:25:39 +02:00
moneromooo-monero
506472e0c6
protocol: fix use after free when dropping a connection
2018-11-26 17:19:25 +00:00
Dusan Klinec
2ffe53d9e6
device/trezor: webusb transport added, cmake fixes
...
- webusb transport based on libusb added. Provides direct access to Trezor via USB, no need for Trezor bridge.
- trezor protocol message handler improved, no recursion used. Ready for upcoming integration tests.
- libusb (for docker) bumped from v1.0.9 to v1.0.22, newer version required for webusb transport, for device enumeration.
- cmake improvements and fixes. Cmake Trezor checks are moved to a dedicated CheckTrezor.cmake file. In case of a problem Trezor is excluded from build.
- ifdefs made consistent to Ledger.
- UDP Transport enumeration disabled by default in release mode
2018-11-25 11:57:19 +01:00
moneromooo-monero
2be31b4c9c
blockchain_blackball: spot when all outputs of an amount are spent
2018-11-24 11:07:15 +00:00
stoffu
9b5efad294
simplewallet: enable donation on testnet/stagenet for easier testing
2018-11-24 08:25:38 +09:00
moneromooo-monero
aee7a4e364
wallet_rpc_server: do not use RPC data if the call failed
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
moneromooo-monero
1a0733e534
windows_service: fix memory leak
...
Found by codacy.com
2018-11-23 15:38:00 +00:00
moneromooo-monero
5d9915ab9e
cryptonote: fix get_unit for non default settings
...
Found by codacy.com
2018-11-23 15:37:39 +00:00
moneromooo-monero
d4f50cb109
remove some unused code
...
Found by codacy.com
2018-11-23 15:37:36 +00:00
moneromooo-monero
611639710d
a few minor (but easy) performance tweaks
...
Found by codacy.com
2018-11-23 15:36:48 +00:00
moneromooo-monero
3002307418
tests: slow_memmem now returns size_t
...
Makes more sense than uint64_t for an offset, and agrees with
the %zu used to print results.
Found by codacy.com
2018-11-23 15:36:48 +00:00
stoffu
c28e3d2dae
rctOps: add braces to suppress warnings
2018-11-23 12:28:04 +09:00
moneromooo-monero
b0d9d6051f
cn_deserialize: allow parsing partially valid tx extra
2018-11-22 11:15:57 +00:00
stoffu
b5573fc231
wallet2: resume processing when tx extra is partially broken
...
Motivated by https://monero.stackexchange.com/questions/10483
Some exchanges appear to have customized the wallet software
in an inappropriate way, making the tx extra field partially
unreadable. PR #3716 changed the wallet behavior disallowing
such partially valid tx extra.
An example tx reported by the user is
e87c675a85f34ecac58a8846613d25062f1813e1023c552b705afad32b972c38
where the normal tx pubkey appears again with the aditional
tx pubkeys tag `04` which is inappropriate.
2018-11-22 14:51:35 +09:00
moneromooo-monero
56e616e855
wallet2: add n_vouts to capture list
2018-11-22 01:45:45 +00:00
Jethro Grassie
517f25efd1
rpc: add version to get_info
2018-11-21 12:56:34 -05:00
moneromooo-monero
6bfcc57395
scoped_message_writer: protect all std::cout usage from readline
2018-11-21 12:48:43 +00:00
moneromooo-monero
96e6b43970
blockchain_stats: don't use gmtime_r on Windows
...
In some cases, it doesn't like it (I don't know the details).
Factor into a new epee function
2018-11-21 00:50:53 +00:00
moneromooo-monero
c25260f51c
protocol: fix incorrect tx hash in log
2018-11-20 18:35:58 +00:00
naughtyfox
6732fc7fde
Fix issue 4793 - M/N multisig transaction signature
2018-11-20 16:50:41 +03:00
moneromooo-monero
b9b307d11a
rpc: speedup get_output_distribution
...
and decrease the amount of data carried around
2018-11-20 10:11:25 +00:00
Riccardo Spagni
84dd674cd0
Merge pull request #4781
...
2a48c2a2b39fdf8e
2018-11-20 12:34:41 +09:00
xiphon
fc99f177f3
lmdb: fix gcc 7.3.0 'implicit-fallthrough' warning
2018-11-19 22:36:10 +00:00
moneromooo-monero
60f36386e4
Avoid unnecessary temp block and copy ctor
...
block already has a default ctor, and the extra object
churn due to its innards (vectors, etc) is pointless.
2018-11-19 17:57:17 +00:00
moneromooo-monero
707c2f836b
Remove -Werror
...
It is an annoying piece of garbage
2018-11-17 13:15:03 +00:00
moneromooo-monero
31d80027b5
tests: add unit tests for get_output_distribution
2018-11-16 19:21:45 +00:00
Tadeas Moravec
3998a937e5
Enhance help text for print_ring.
2018-11-16 15:15:35 +00:00
Tadeas Moravec
3900fb779f
Enhance help text for incoming_transfers.
2018-11-16 14:53:31 +00:00
moneromooo-monero
0936dae8a4
blockchain: remove "0 is height" shortcut from get_output_distribution
...
This prevents asking for just 0, and the RPC layer already does this
2018-11-16 10:03:02 +00:00
moneromooo-monero
872c7eb26a
Revert "blockchain: simplify output distribution code"
...
This reverts commit b2bb9312a7
2018-11-16 10:02:59 +00:00
xiphon
2a48c2a286
slow-hash: some more big endian fixes
2018-11-16 09:58:41 +00:00
moneromooo-monero
b39fdf8ebe
slow-hash: fix for big endian
2018-11-16 09:58:38 +00:00
Riccardo Spagni
c37c70f459
Merge pull request #4806
...
ac23b10f3b14d972
2018-11-16 11:16:49 +02:00
Riccardo Spagni
0295055bcb
Merge pull request #4805
...
6a1062f5
2018-11-16 11:16:12 +02:00
Riccardo Spagni
cec336ecbc
Merge pull request #4804
...
00907c39
2018-11-16 11:15:56 +02:00
Riccardo Spagni
056abf980e
Merge pull request #4801
...
7ae36e91
2018-11-16 11:13:09 +02:00
Riccardo Spagni
3a40d94998
Merge pull request #4800
...
79b4dae6
2018-11-16 11:12:43 +02:00
Riccardo Spagni
45f597c564
Merge pull request #4799
...
f4988454
2018-11-16 11:12:09 +02:00
Riccardo Spagni
46f989bc49
Merge pull request #4795
...
5d7c2316
2018-11-16 11:11:10 +02:00
Riccardo Spagni
f9c60736b8
Merge pull request #4794
...
e198b06e
2018-11-16 11:10:20 +02:00
Riccardo Spagni
40bb7a304a
Merge pull request #4792
...
5d4f3df8
2018-11-16 11:09:41 +02:00
Riccardo Spagni
86395e5bd6
Merge pull request #4791
...
5878fe95
2018-11-16 11:08:34 +02:00
Riccardo Spagni
9aff9a5372
Merge pull request #4790
...
177a9d76
2018-11-16 11:08:07 +02:00
Riccardo Spagni
20bf9b93dd
Merge pull request #4789
...
0afdb00b
2018-11-16 11:07:40 +02:00
Riccardo Spagni
c8cc65f30a
Merge pull request #4788
...
8f3963d2
2018-11-16 11:07:21 +02:00
Riccardo Spagni
279a0a4d8a
Merge pull request #4786
...
c22e85fe
2018-11-16 11:06:32 +02:00
Riccardo Spagni
4561119846
Merge pull request #4784
...
1c04c21d
2018-11-16 11:05:31 +02:00
Riccardo Spagni
140defd89f
Merge pull request #4778
...
71eb32a9
2018-11-16 11:02:28 +02:00
Riccardo Spagni
b1ba96e159
Merge pull request #4777
...
c17a1d43
2018-11-16 11:01:33 +02:00
Riccardo Spagni
46d0dc2808
Merge pull request #4776
...
03fc731b14a5c206
2018-11-16 11:01:19 +02:00
Riccardo Spagni
d7bac99f6f
Merge pull request #4770
...
2bd46065
2018-11-16 10:59:38 +02:00
Riccardo Spagni
9827958f5e
Merge pull request #4768
...
cf552c75
2018-11-16 10:59:25 +02:00
Riccardo Spagni
e90ee7548c
Merge pull request #4765
...
09dbd9cb
2018-11-16 10:58:42 +02:00
Riccardo Spagni
95d96d139d
Merge pull request #4764
...
1598f01c
2018-11-16 10:58:29 +02:00
Riccardo Spagni
1910aab5f4
Merge pull request #4236
...
a9357141
2018-11-16 10:57:43 +02:00
doy-lee
6f2497bc7a
Don't cache nettype in core_rpc_server use m_core
...
This can go out of sync with m_core's nettype if you run in fakechain
mode since entering fakechain mode is done through code not the command
line and core_rpc_server only looks at the command line to figure out
the nettype.
2018-11-16 15:32:05 +11:00
moneromooo-monero
c5ee14ae6e
json_archive: initialize inner_array_size in ctor
...
Coverity 136581
2018-11-15 16:33:51 +00:00
Martijn Otto
bd98e99c80
Removed a lot of unnecessary includes
2018-11-15 17:29:34 +01:00
moneromooo-monero
2b3595d0fe
various: do not propagate exception through dtor
...
Coverity 189689, 189690, 189692, 189695
2018-11-15 15:53:21 +00:00
stoffu
79b4dae66f
simplewallet: slightly adjust wording when printing multisig seed
2018-11-15 23:51:19 +09:00
Riccardo Spagni
0cc3fc3756
Merge pull request #4769
...
5808530f1426209a6f7a5fd499fbe100bf31447e4f005a77593ef5986ecc99ad00cc1a16
2018-11-14 21:35:03 +02:00
Riccardo Spagni
33ad6fb4c1
Merge pull request #4761
...
6e1282b6
2018-11-14 21:34:51 +02:00
Riccardo Spagni
92c5a892b5
Merge pull request #4757
...
db24a2e5
2018-11-14 21:34:09 +02:00
Riccardo Spagni
8ba3f89b44
Merge pull request #4755
...
42d8d508
2018-11-14 21:33:38 +02:00
Riccardo Spagni
59e8a4c306
Merge pull request #4753
...
157054b82362baf7d9400f69cbe0122b
2018-11-14 21:33:02 +02:00
Riccardo Spagni
23fc891555
Merge pull request #4750
...
e61062b6
2018-11-14 21:32:21 +02:00
Riccardo Spagni
ff347c98a1
Merge pull request #4747
...
dad5bbfd
2018-11-14 21:32:10 +02:00
Riccardo Spagni
dd42b642ee
Merge pull request #4746
...
f3019efe
2018-11-14 21:31:08 +02:00
Riccardo Spagni
2312aacf18
Merge pull request #4847
...
6d3311acf0459abb
2018-11-14 21:30:19 +02:00
stoffu
f0459abbb9
cmake: move Boost_LOCALE_LIBRARY out of ICU_LIBRARIES
2018-11-15 00:18:31 +09:00
xiphon
d01bdaca12
common: fix base58 gcc -Werror=implicit-fallthrough
2018-11-13 12:15:18 +00:00
sachaaaaa
a93571410e
Add new command "export_transfers" to save transfers to csv
2018-11-12 12:03:11 +11:00
moneromooo-monero
2c7195d80c
bulletproofs: avoid std::vector allocations for slice
2018-11-09 19:58:11 +00:00
moneromooo-monero
dffec2587f
db_lmdb: error out if the db needs migration in read only mode
2018-11-09 09:39:22 +00:00
Riccardo Spagni
8534f71eed
Merge pull request #4814
...
840bf155
2018-11-07 15:02:56 +02:00
stoffu
ba2055a220
api/wallet: fix compile errors made in #4720
2018-11-07 15:12:24 +09:00
stoffu
1a4d160311
wallet2: remove redundant chacha key generation in store_keys
2018-11-07 10:47:10 +09:00
xiphon
840bf155a0
build: fix Ubuntu 16.04 (GCC 5.4.0) compilation
2018-11-06 21:45:00 +00:00
Riccardo Spagni
a9e03ebc6a
Merge pull request #4809
...
1fd017cf
2018-11-06 21:35:08 +02:00
Riccardo Spagni
148ac1a898
Merge pull request #4744
...
b3e8677c
2018-11-06 21:33:52 +02:00
Riccardo Spagni
a369a13928
Merge pull request #4743
...
9335d5a2
2018-11-06 21:33:22 +02:00
Riccardo Spagni
da26bc92e9
Merge pull request #4742
...
0a95cdaa
2018-11-06 21:32:54 +02:00
Riccardo Spagni
d210d6fb45
Merge pull request #4738
...
107f3398
2018-11-06 21:31:32 +02:00
Riccardo Spagni
299d75b209
Merge pull request #4735
...
73e504c1a5ca7f4f
2018-11-06 21:31:14 +02:00
Riccardo Spagni
0991aa8964
Merge pull request #4733
...
b3067962
2018-11-06 21:30:52 +02:00
Riccardo Spagni
164ba3ef1c
Merge pull request #4731
...
f26ce08c
2018-11-06 21:30:12 +02:00
moneromooo-monero
3dba7f252e
protocol: option to pad transaction relay to the next kB
...
To help protect one's privacy from traffic volume analysis
for people using Tor or I2P. This will really fly once we
relay txes on a timer rather than on demand, though.
Off by default for now since it's wasteful and doesn't bring
anything until I2P's in.
2018-11-06 15:47:05 +00:00
Riccardo Spagni
b789f7e10d
Merge pull request #4729
...
e86af52e
2018-11-06 15:09:45 +02:00
Riccardo Spagni
1667d41064
Merge pull request #4728
...
1f35de23
2018-11-06 14:54:17 +02:00
Riccardo Spagni
b60078d1b3
Merge pull request #4726
...
91eaea9c
2018-11-06 14:53:40 +02:00
Riccardo Spagni
236c0dd48c
Merge pull request #4720
...
5f614ba98d71b2b1769ae42a
2018-11-06 14:52:24 +02:00
Riccardo Spagni
267b5d8807
Merge pull request #4711
...
c4fbfd78
2018-11-06 14:51:23 +02:00
Riccardo Spagni
cb4d5c2d4b
Merge pull request #4707
...
97cad7e9
2018-11-06 14:50:08 +02:00
buricl
1fd017cf77
Fix build of monero-gui by adding device_trezor to wallet_merged
2018-11-06 00:17:22 +01:00
moneromooo-monero
6e1282b600
wallet2: fix off by one in output picking
...
and take into account wallet level minimum spend age
2018-11-05 20:13:00 +00:00
moneromooo-monero
ac23b10f15
blockchain: fix innocuous difficulty cache inconsistency
...
This inconsistent state would not actually be used in practice
2018-11-05 14:47:52 +00:00
moneromooo-monero
3b14d9727b
blockchain: use uint64_t for block height, not size_t
...
for consistency
2018-11-05 14:47:48 +00:00
moneromooo-monero
6a1062f560
bulletproofs: reserve vector memory when known in advance
2018-11-05 14:32:32 +00:00
moneromooo-monero
00907c3987
rct: speedup commit a little
...
saves a conversion, and uses a double scalarmult instead of
two scalarmults
2018-11-05 14:25:11 +00:00
stoffu
7ae36e91f6
wallet_rpc_server: account for watch-only/non-deterministic/multisig when querying seed
...
Followup on #4653
2018-11-05 12:13:15 +09:00
moneromooo-monero
f49884543c
perf_timer: remove stray debug addition
2018-11-05 00:34:16 +00:00
xiphon
b3067962fa
cryptonote_core: avoid gratuitous recalculations in check_block_rate()
2018-11-05 00:13:51 +00:00
Dusan Klinec
e178bf234a
rpc: fix linking error of 6097472a, get_output_distribution
...
Undefined symbols for architecture x86_64:
"cryptonote::core::get_output_distribution(unsigned long long, unsigned long long, unsigned long long, unsigned long long&, std::__1::vector<unsigned long long, std::__1::allocator<unsigned long long> >&, unsigned long long&) const", referenced from:
cryptonote::rpc::RpcHandler::get_output_distribution(cryptonote::core&, unsigned long long, unsigned long long, unsigned long long, bool) in rpc_handler.cpp.o
2018-11-04 23:38:52 +01:00
moneromooo-monero
5f614ba968
simplewallet: print the number of show/all transfers
2018-11-04 22:27:05 +00:00
moneromooo-monero
8d71b2b1b3
wallet2: only export necessary outputs and key images
...
and disable annoying test that requires ridiculous amounts
of skullduggery every time some format changes
2018-11-04 22:27:01 +00:00
moneromooo-monero
769ae42a7b
wallet2: faster output and key image import/export
2018-11-04 22:26:59 +00:00
Riccardo Spagni
7e2483e1d5
Merge pull request #4702
...
70877b1d
2018-11-04 20:47:25 +02:00
Riccardo Spagni
68e2efa8f2
Merge pull request #4694
...
a43daebf
2018-11-04 20:47:06 +02:00
Riccardo Spagni
6d3d8635be
Merge pull request #4693
...
74fb3d88a6d2e246a110e6aa8b4767226f9ae5b610e5a9278629a42cfc9f7d9c4061960abf8e4b98c415df97a281b950484155d0a621d6c8a49a17614564a5d1
2018-11-04 20:46:42 +02:00
Riccardo Spagni
5141f6e8e8
Merge pull request #4692
...
cb4aafd2
2018-11-04 20:46:21 +02:00
Riccardo Spagni
ae919a1e15
Merge pull request #4691
...
7f0dd094
2018-11-04 20:45:59 +02:00
Riccardo Spagni
617deb3329
Merge pull request #4689
...
ba0faae7ed36335c
2018-11-04 20:45:40 +02:00
Riccardo Spagni
adf4eb8d50
Merge pull request #4688
...
5a2e54a1
2018-11-04 20:45:06 +02:00
Riccardo Spagni
0c7086bf7f
Merge pull request #4687
...
6097472a
2018-11-04 20:44:49 +02:00
Riccardo Spagni
d394c50f7b
Merge pull request #4686
...
cf646e3a
2018-11-04 20:44:27 +02:00
Riccardo Spagni
9cf0e67978
Merge pull request #4685
...
76681b9b
2018-11-04 20:44:00 +02:00
Riccardo Spagni
5251496662
Merge pull request #4684
...
4a003bb5
2018-11-04 20:43:28 +02:00
Riccardo Spagni
5918ef93f8
Merge pull request #4683
...
3a85af40
2018-11-04 20:43:08 +02:00
Riccardo Spagni
69b646494b
Merge pull request #4241
...
29ffb6bb
2018-11-04 20:42:46 +02:00
Riccardo Spagni
dc7de3312f
Merge pull request #4779
...
233f00c6
2018-11-04 20:41:19 +02:00
Hasan Pekdemir
e198b06e7a
Fix: out_of_hashchain_bounds_error in refresh
...
15:43 < hahsun> Im on stagenet and I suddenly get this exception: 2018-11-04 14:42:52.416 [RPC0] ERROR wallet.wallet2 src/wallet/wallet2.cpp:2070 !m_blockchain.is_in_bounds(current_index). THROW EXCEPTION: error::out_of_hashchain_bounds_error
16:01 <+moneromooo> OK, possibly because the blckchain is always seeded with the genesis block hash...
16:02 <+moneromooo> So that case should be allowed, assuming it doesn't break the code around it.
16:05 <+moneromooo> OK if stop_height == size || (size==1 && stop_heigt ==0)
16:05 <+moneromooo> Throw if not that.
16:06 < hahsun> k
2018-11-04 17:07:30 +01:00
moneromooo-monero
5d7c231604
rct: add a zeroCommit cache for common pre-rct case
...
This is called for every pre-rct output at blockchain sync time,
and a lot of them wil hit the cache, saving a scalarmult each.
2018-11-04 15:44:56 +00:00
moneromooo-monero
5808530f54
blockchain: remove unused output_scan_worker parameter
2018-11-04 13:23:05 +00:00
moneromooo-monero
1426209a10
blockchain: don't run threads if we have just one function to run
2018-11-04 13:23:02 +00:00
moneromooo-monero
6f7a5fd4f7
db_lmdb: slight speedup getting array data from the blockchain
2018-11-04 13:23:00 +00:00
stoffu
5d4f3df887
simplewallet: reorganize SCOPED_WALLET_UNLOCK a bit more
...
Followup on #4555
2018-11-04 10:51:14 +09:00
stoffu
5878fe95ce
simplewallet: don't skip asking for password when watch-only
2018-11-04 10:50:03 +09:00
moneromooo-monero
177a9d76f9
wallet: warn if lockable memory limit is too low
2018-11-03 20:09:28 +00:00
moneromooo-monero
f26ce08c8a
wallet: add a non destructive blockchain rescan
2018-11-03 15:04:37 +00:00
moneromooo-monero
8f3963d200
wallet2: demote a few uninteresting recurring logs to TRACE
2018-11-03 11:51:03 +00:00
moneromooo-monero
0afdb00b9d
wallet2: fix print_ring printing double entries for transactions
...
When a tx gets from unconfirmed to conirmed, the rings for that
transaction were being added twice
2018-11-03 11:50:38 +00:00
cryptochangements34
e61062b6f2
use current height - 1 for top block height in err msgs
2018-11-02 19:31:31 -04:00
Dusan Klinec
29ffb6bba8
device/trezor: trezor support added
2018-11-02 21:36:39 +01:00
stoffu
c22e85fe1a
simplewallet: remove redundant messages on daemon connection failure
...
try_connect_to_daemon with silent=false already prints failure message
2018-11-02 23:25:27 +09:00
stoffu
1c04c21d6e
wallet_rpc_server: include additional tx keys in sign_transfer response
...
Followup on #4552
2018-11-02 21:42:02 +09:00
moneromooo-monero
97cad7e979
db_lmdb: log which output was not found in get_output_key
2018-11-02 11:49:39 +00:00
xiphon
233f00c601
cryptonote_core: fix build error gcc 5.4.0 'sign-compare'
2018-11-01 22:57:08 +00:00
moneromooo-monero
71eb32a976
dns_utils: do not exit if DNS records are corrupt
2018-11-01 22:53:48 +00:00
moneromooo-monero
c17a1d431b
daemon: use msg_writer, not cout, to display information
2018-11-01 22:53:10 +00:00
moneromooo-monero
03fc731bf2
p2p: less frequent incoming connections check
2018-11-01 22:00:35 +00:00
Riccardo Spagni
9a4b15c631
Merge pull request #4664
...
61304151
2018-11-01 22:34:20 +02:00
Riccardo Spagni
7d05e6eab3
Merge pull request #4663
...
d6937e37
2018-11-01 22:34:02 +02:00
Riccardo Spagni
a0cd602e56
Merge pull request #4658
...
ca9b996d
2018-11-01 22:33:38 +02:00
Riccardo Spagni
3ceeac50da
Merge pull request #4653
...
ade369f9
2018-11-01 22:33:20 +02:00
Riccardo Spagni
fde24c80c2
Merge pull request #4648
...
a7bffead
2018-11-01 22:33:02 +02:00
Riccardo Spagni
e7a475e4e6
Merge pull request #4645
...
6f88c03d
2018-11-01 22:32:41 +02:00
Riccardo Spagni
4f7cdd90fd
Merge pull request #4639
...
ec301390
2018-11-01 22:24:11 +02:00
moneromooo-monero
99fbe1008b
db_lmdb: save some string copies for readonly db keys/values
2018-11-01 17:26:09 +00:00
moneromooo-monero
14a5c2068f
p2p: tone down "no incoming connections" warning to info if in peers is 0
...
Also add an info if not offline, since it weakens the network
2018-11-01 16:43:06 +00:00
moneromooo-monero
bf31447e9b
tx_pool: speed up take_tx for transactions from blocks
...
This happens for every historical tx when syncing, and the
unnecessary parsing is actually showing up on profile.
Since these are kept cached for just one block, this does
not increase memory usage after syncing.
2018-11-01 15:51:28 +00:00
moneromooo-monero
4f005a77c2
tx_pool: remove unnecessary get_transaction_hash
2018-11-01 15:51:24 +00:00
