moneromooo-monero
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
2019-05-11 13:05:06 +00:00
dsc
4c666141e3
expose set/get walletcache attribute functionality in wallet api
2019-05-10 19:24:45 +02:00
moneromooo-monero
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
2019-05-10 14:44:13 +00:00
Riccardo Spagni
97cb1c9436
Merge pull request #5508
...
1c44e658
wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
2019-05-07 17:35:28 +02:00
Riccardo Spagni
c20221f290
Merge pull request #5503
...
ccc1e311
wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
2019-05-07 17:34:16 +02:00
Riccardo Spagni
ebb1c03e8c
Merge pull request #5501
...
b4ca72dd
wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
2019-05-07 17:32:33 +02:00
moneromooo-monero
e4d100b062
wallet2: don't wait a day before using new version fees
...
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
2019-05-02 18:00:25 +00:00
moneromooo-monero
bc94ba4d14
wallet: distinguish between empty and absent attributes
2019-05-02 13:00:08 +00:00
Riccardo Spagni
77f9bfa4d5
Merge pull request #5493
...
5e0da6fb
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
2019-05-02 11:30:28 +02:00
Riccardo Spagni
52eb454d7b
Merge pull request #5491
...
98fb98f9
wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero)
9074c0d8
wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero)
968848a7
wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
2019-05-02 11:30:11 +02:00
Riccardo Spagni
efd2412e77
Merge pull request #5489
...
64983fce
wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
2019-05-02 11:29:25 +02:00
moneromooo-monero
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API
2019-05-01 18:41:39 +00:00
moneromooo-monero
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book
2019-04-30 21:07:37 +00:00
moneromooo-monero
1a66a86f94
remove unused code
2019-04-29 20:52:40 +00:00
moneromooo-monero
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case
...
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
2019-04-29 10:02:20 +00:00
moneromooo-monero
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256
...
SHA1 is too close to bruteforceable
2019-04-26 11:37:15 +00:00
moneromooo-monero
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon
2019-04-25 23:35:37 +00:00
moneromooo-monero
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
moneromooo-monero
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
Riccardo Spagni
581994b61c
Merge pull request #5486
...
4be18df3
tx_sanity_check: relax uniqueness check a bit (moneromooo-monero)
b386ae57
wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
2019-04-24 22:41:40 +02:00
Riccardo Spagni
2e2ee3d823
Merge pull request #5485
...
c519d1df
wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
2019-04-24 22:41:18 +02:00
Riccardo Spagni
edcb0cfff2
Merge pull request #5477
...
97e1c927
wallet: fix key image computation signaling to the device (Dusan Klinec)
2019-04-24 22:38:36 +02:00
moneromooo-monero
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero
...
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
2019-04-24 12:25:43 +00:00
moneromooo-monero
df83ed74e4
consensus: from v12, enforce >= 2 outputs
2019-04-23 22:09:35 +00:00
moneromooo-monero
b386ae5725
wallet2: add missing "sanity check failed" reason message
2019-04-23 21:59:57 +00:00
moneromooo-monero
c519d1df34
wallet2: fix wrong change being recorded in sweep_all
...
leading to the sanity check triggering
2019-04-23 21:58:55 +00:00
Dusan Klinec
97e1c9278c
wallet: fix key image computation signaling to the device
2019-04-22 16:14:50 +02:00
moneromooo-monero
31a9aa83af
wallet_rpc_server: add block_height and frozen to incoming_transfers
2019-04-20 08:44:09 +00:00
Riccardo Spagni
950f79dc03
Merge pull request #5389
...
588e6700
simplewallet: fix output representation offset (moneromooo-monero)
35e0a968
wallet2: "output lineup" fake out selection (moneromooo-monero)
2019-04-18 22:01:51 +02:00
Riccardo Spagni
2e342d8df6
Merge pull request #5458
...
84047cb7
wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
2019-04-18 22:01:22 +02:00
moneromooo-monero
588e670089
simplewallet: fix output representation offset
2019-04-18 15:14:41 +00:00
moneromooo-monero
35e0a968bd
wallet2: "output lineup" fake out selection
...
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
2019-04-18 15:14:38 +00:00
moneromooo-monero
84047cb729
wallet_rpc_server: add unlocked field to incoming_transfers output
2019-04-17 15:30:49 +00:00
moneromooo-monero
3b9ce453a9
wallet_rpc_server: remove unused variable
2019-04-17 11:25:33 +00:00
moneromooo-monero
7110226794
wallet_rpc_server: set suggested_confirmations_threshold for pool txes
2019-04-16 20:59:57 +00:00
moneromooo-monero
294e858d57
wallet_rpc_server: add set_log_level/set_log_categories
2019-04-16 20:50:15 +00:00
Riccardo Spagni
c8ce4217cf
Merge pull request #5445
...
b18f0b10
wallet: new --offline option (moneromooo-monero)
2019-04-16 22:46:53 +02:00
Riccardo Spagni
f376cd5605
Merge pull request #5446
...
7d79222f
daemon: remove debug info (moneromooo-monero)
8fec0f98
functional_tests: add sweep_single test (moneromooo-monero)
9880d61b
wallet_rpc_server: remove unused code (moneromooo-monero)
8a61b33d
rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero)
56508524
rpc: add relayed in get_transaction output (moneromooo-monero)
82e510f1
rpc: set default log category in core_rpc_server.h (moneromooo-monero)
2019-04-16 22:46:29 +02:00
Riccardo Spagni
1f01070a0c
Merge pull request #5434
...
ccb996af
rpc: new sanity check on relayed transactions (moneromooo-monero)
2019-04-16 22:41:40 +02:00
Riccardo Spagni
35b3d754e8
Merge pull request #5429
...
bcb86ae6
wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
2019-04-16 22:39:37 +02:00
Riccardo Spagni
8966ac314c
Merge pull request #5422
...
2c221d1b
wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)
2019-04-16 22:38:11 +02:00
Riccardo Spagni
96696d1e75
Merge pull request #5418
...
374f388d
wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
2019-04-16 22:37:52 +02:00
moneromooo-monero
b18f0b1051
wallet: new --offline option
...
It will avoid connecting to a daemon (so useful for cold signing
using a RPC wallet), and not perform DNS queries.
2019-04-15 09:14:12 +00:00
moneromooo-monero
9880d61b98
wallet_rpc_server: remove unused code
2019-04-15 09:13:12 +00:00
Riccardo Spagni
8bf0a3f123
Merge pull request #5396
...
b40392fb
wallet2: add --no-dns flag (moneromooo-monero)
2019-04-15 09:17:26 +02:00
Riccardo Spagni
98f4c8af98
Merge pull request #5395
...
15f27c80
wallet2: support multi out txes without change in sanity check (moneromooo-monero)
2019-04-15 09:17:07 +02:00
Riccardo Spagni
89b8ecfc7c
Merge pull request #5392
...
a2195b9b
crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)
2019-04-15 09:14:28 +02:00
Riccardo Spagni
37aea526a9
Merge pull request #5355
...
c68fe787
device/trezor: add button pressed request (Dusan Klinec)
827f52ad
wallet: API changes to enable passphrase entry (Dusan Klinec)
2019-04-15 09:12:20 +02:00
moneromooo-monero
ccb996afc6
rpc: new sanity check on relayed transactions
...
This will weed out some transactions with silly rings
2019-04-12 20:22:09 +00:00
moneromooo-monero
bcb86ae651
wallet_rpc_server: fix inconsistent wallet caches on reload
...
Loading the same wallet as the currently loaded one would autosave
the current state after loading it, leading to some kind of rollback
effect. We now save before loading to avoid this. If loading fails,
it means the current wallet will be saved (or maybe not, depending
on where the failure occurs: most of the sanity checks occur before
saving). There is a new autosave_current flag to open/restore calls
so the (enabled by default) autosave can be skipped.
2019-04-12 13:40:42 +00:00
moneromooo-monero
2c221d1b6c
wallet2: update estimate_rct_tx_size for smaller rct proofs
2019-04-11 17:31:18 +00:00
Riccardo Spagni
5db72d12b4
Merge pull request #5388
...
0be5b2ee
simplewallet: new unset_ring command (moneromooo-monero)
2019-04-11 13:05:43 +02:00
Riccardo Spagni
5c02316598
Merge pull request #5382
...
c12b43cb
wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero)
3f1e9e84
wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
36c037ec
wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
cd1eaff2
wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
2019-04-11 13:03:55 +02:00
Riccardo Spagni
3a4008f0fc
Merge pull request #5374
...
a2561653
wallet: new option to start background mining (moneromooo-monero)
2019-04-11 13:01:30 +02:00
moneromooo-monero
9f8dc4ce51
simplewallet: new net_stats command
...
displays total sent and received bytes
2019-04-11 10:46:41 +00:00
moneromooo-monero
374f388de2
wallet_rpc_server: add a all flag to export_outputs
...
if we don't want to export new outputs only
2019-04-10 10:37:34 +00:00
Lee Clagett
2e578b8214
Enabling daemon-rpc SSL now requires non-system CA verification
...
If `--daemon-ssl enabled` is set in the wallet, then a user certificate,
fingerprint, or onion/i2p address must be provided.
2019-04-07 13:02:43 -04:00
Dusan Klinec
c68fe7873b
device/trezor: add button pressed request
2019-04-07 13:35:49 +02:00
Lee Clagett
d58f368289
Require manual override for user chain certificates.
...
An override for the wallet to daemon connection is provided, but not for
other SSL contexts. The intent is to prevent users from supplying a
system CA as the "user" whitelisted certificate, which is less secure
since the key is controlled by a third party.
2019-04-07 00:44:37 -04:00
Lee Clagett
21eb1b0725
Pass SSL arguments via one class and use shared_ptr instead of reference
2019-04-07 00:44:37 -04:00
Lee Clagett
1f5ed328aa
Change default SSL to "enabled" if user specifies fingerprint/certificate
...
Currently if a user specifies a ca file or fingerprint to verify peer,
the default behavior is SSL autodetect which allows for mitm downgrade
attacks. It should be investigated whether a manual override should be
allowed - the configuration is likely always invalid.
2019-04-06 23:47:07 -04:00
Lee Clagett
a3b0284837
Change SSL certificate file list to OpenSSL builtin load_verify_location
...
Specifying SSL certificates for peer verification does an exact match,
making it a not-so-obvious alias for the fingerprints option. This
changes the checks to OpenSSL which loads concatenated certificate(s)
from a single file and does a certificate-authority (chain of trust)
check instead. There is no drop in security - a compromised exact match
fingerprint has the same worse case failure. There is increased security
in allowing separate long-term CA key and short-term SSL server keys.
This also removes loading of the system-default CA files if a custom
CA file or certificate fingerprint is specified.
2019-04-06 23:47:06 -04:00
Riccardo Spagni
c7e536db23
Merge pull request #5350
...
050bb337
wallet2: factor the watchonly/multisig/etc fields on creation (moneromooo-monero)
2019-04-06 16:00:40 +02:00
Riccardo Spagni
cd8fe937ad
Merge pull request #5347
...
d45b85e1
wallet2: skip derivation precalc for blocks we know we'll skip (moneromooo-monero)
2019-04-06 15:59:56 +02:00
Riccardo Spagni
4ac78e1612
Merge pull request #5346
...
c84ea299
cryptonote_basic: some more minor speedups (moneromooo-monero)
e40eb2ad
cryptonote_basic: speedup calculate_block_hash (moneromooo-monero)
547a9708
cryptonote: block parsing + hash calculation speedup (moneromooo-monero)
11604b6d
blockchain: avoid unneeded block copy (moneromooo-monero)
8461df04
save some database calls when getting top block hash and height (moneromooo-monero)
3bbc3661
Avoid repeated (de)serialization when syncing (moneromooo-monero)
2019-04-06 15:59:43 +02:00
Riccardo Spagni
7e5651c346
Merge pull request #5345
...
678262ab
wallet_rpc_server: allow english/local language names in create_wallet (moneromooo-monero)
2019-04-06 15:59:10 +02:00
Riccardo Spagni
9e72f785d6
Merge pull request #5343
...
cafa15b9
wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
2019-04-06 15:58:25 +02:00
Riccardo Spagni
e1f0e6da5c
Merge pull request #5340
...
16eda54b
wallet: use original user address if we have a short payment id (moneromooo-monero)
2019-04-06 15:56:52 +02:00
Dusan Klinec
827f52add0
wallet: API changes to enable passphrase entry
2019-04-05 22:17:50 +02:00
moneromooo-monero
a2561653cb
wallet: new option to start background mining
...
The setup-background-mining option can be used to select
background mining when a wallet loads. The user will be asked
the first time the wallet is created.
2019-04-04 18:10:45 +00:00
moneromooo-monero
b40392fb02
wallet2: add --no-dns flag
2019-04-04 14:32:40 +00:00
stoffu
a2195b9b7f
crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)
2019-04-04 22:38:19 +09:00
moneromooo-monero
15f27c80b9
wallet2: support multi out txes without change in sanity check
2019-04-03 20:58:21 +00:00
selsta
8bb253b0db
libwallet_merged: add missing net target
2019-04-02 21:22:51 +02:00
moneromooo-monero
0be5b2ee78
simplewallet: new unset_ring command
...
Useful when debugging, though not much for users
2019-04-02 14:18:07 +00:00
stoffu
d3018d0f0b
api/wallet: fix some wrong namespace
2019-04-02 10:11:49 +09:00
moneromooo-monero
c12b43cb5a
wallet: add number of blocks required for the balance to fully unlock
2019-04-01 19:31:19 +00:00
moneromooo-monero
3f1e9e84c0
wallet2: set confirmations to 0 for pool txes in proofs
...
It makes more sense than (uint64_t)-1, which is going to look
like very much confirmed when not checking in_pool
2019-04-01 19:31:10 +00:00
moneromooo-monero
36c037ec47
wallet_rpc_server: error out on getting the spend key from a hot wallet
2019-04-01 19:31:01 +00:00
moneromooo-monero
cd1eaff29e
wallet_rpc_server: always fill out subaddr_indices in get_transfers
...
It was not filled out for in and pool types
2019-04-01 19:30:27 +00:00
Riccardo Spagni
b6726aaa6c
Merge pull request #5319
...
f825055d
wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero)
67aa4adc
wallet_rpc_server: add a set_daemon RPC (moneromooo-monero)
705acbac
wallet2: init some variables to default values if loading old wallets (moneromooo-monero)
f82bc29e
wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
01efdc6a
wallet_rpc_server: set confirmations to 0 for pending/pool txes (moneromooo-monero)
2019-04-01 20:56:52 +02:00
moneromooo-monero
f825055d22
wallet_rpc_server: error out on getting the spend key from a hot wallet
2019-04-01 16:03:29 +00:00
moneromooo-monero
67aa4adcfc
wallet_rpc_server: add a set_daemon RPC
2019-04-01 16:03:25 +00:00
moneromooo-monero
705acbac4d
wallet2: init some variables to default values if loading old wallets
2019-04-01 16:03:23 +00:00
moneromooo-monero
f82bc29ec2
wallet_rpc_server: always fill out subaddr_indices in get_transfers
...
It was not filled out for in and pool types
2019-04-01 16:03:20 +00:00
moneromooo-monero
01efdc6a7e
wallet_rpc_server: set confirmations to 0 for pending/pool txes
2019-04-01 16:03:17 +00:00
Riccardo Spagni
286dec012d
Merge pull request #5333
...
18faa6da
wallet: add freeze/thaw/frozen commands (moneromooo-monero)
2019-04-01 17:36:16 +02:00
Riccardo Spagni
b8ab510f23
Merge pull request #5332
...
7c440915
Add get_tx_proof support, needed for new sanity check (cslashm)
98fdcb2a
Add support for V11 protocol with BulletProofV2 and short amount. New scheme key destination contrfol Fix dummy decryption in debug mode (cslashm)
3a981a33
Add application version compatibility check. (cslashm)
2019-04-01 17:35:12 +02:00
Riccardo Spagni
3b52940471
Merge pull request #5349
...
f1a3796a
wallet2: fix tx sanity check change test for the sweep_all case (moneromooo-monero)
2019-04-01 17:34:43 +02:00
Riccardo Spagni
3b1fa543ca
Merge pull request #5329
...
023f2c77
wallet_rpc_server: remove mixin from transfer RPCs (moneromooo-monero)
2019-04-01 17:32:20 +02:00
Riccardo Spagni
8b57e33789
Merge pull request #5305
...
4500236f
wallet2: make use_fork_rules handle chain heights lower than leeway (moneromooo-monero)
2019-04-01 17:26:23 +02:00
Riccardo Spagni
30a3a73609
Merge pull request #5303
...
0a6cb30d
wallet: flush output cache upon reorg (moneromooo-monero)
2019-04-01 17:26:10 +02:00
Riccardo Spagni
94880540e7
Merge pull request #5302
...
23fb056a
wallet_rpc_server: new auto_refresh RPC (moneromooo-monero)
2019-04-01 17:25:53 +02:00
Riccardo Spagni
b09f1bdb8f
Merge pull request #5299
...
4ee15655
wallet_rpc_server: fix buffer read overflow in string assignment (moneromooo-monero)
2019-04-01 17:24:33 +02:00
Riccardo Spagni
4a06b3ee62
Merge pull request #5298
...
8fd7452b
wallet: move light wallet RPC out of core RPC (moneromooo-monero)
2019-04-01 17:24:13 +02:00
Riccardo Spagni
f13d38350a
Merge pull request #5297
...
a8b98a0b
wallet: fix memory only wallets (moneromooo-monero)
2019-04-01 17:23:37 +02:00
Riccardo Spagni
6cb0a26d9d
Merge pull request #5292
...
328d291f
wallet2: set seed language when creating from json (moneromooo-monero)
2019-04-01 17:22:22 +02:00
Riccardo Spagni
a6b798e72f
Merge pull request #5291
...
a52366c1
wallet2: fix generation from json when restore height is not set (moneromooo-monero)
2019-04-01 17:21:14 +02:00
cslashm
7c44091541
Add get_tx_proof support, needed for new sanity check
...
Enhance debug info
2019-03-28 18:26:15 +01:00
moneromooo-monero
050bb337d7
wallet2: factor the watchonly/multisig/etc fields on creation
...
There's half a dozen calls, and it's easy to miss some when
adding a new field.
2019-03-27 08:51:16 +00:00