Commit Graph

6989 Commits

Author SHA1 Message Date
tobtoht def58196da
wallet_api: add seed_offset param to seed() 2021-04-22 04:32:41 +02:00
Ben Evanoff 73959c623c
wallet_api: store fee for incoming txs in history 2021-04-22 04:32:32 +02:00
benevanoff 712f362150
wallet api: allow wallet to fetch all key images via api 2021-04-22 04:32:24 +02:00
dsc 153d08d026
Allow tx note edits via TransactionHistory object in wallet/api 2021-04-22 04:32:14 +02:00
xiphon 2abd7b174b
wallet_api: TransactionHistory - fill unconfirmed out payments dests 2021-04-22 04:32:06 +02:00
dsc 9a50bef3cd
Extend TransactionInfo with coinbase and description attributes in wallet/api 2021-04-22 04:31:44 +02:00
dsc 22bb6a654d
Allow AddressBook description edits via wallet/api interface 2021-04-22 04:31:36 +02:00
luigi1111 298208d92b
Merge pull request #7350
4a9ae3e fix serialization being different on mac (moneromooo-monero)
2021-04-06 12:21:28 -05:00
luigi1111 f719b74cd1
Merge pull request #7638
c18cdd3 build: prepare v0.17.2.0 (selsta)
2021-03-29 22:00:40 -04:00
luigi1111 daa1376370
Merge pull request #7621
21ab1de cryptonote_protocol_handler: fix race condition (anon)
699e82c cryptonote_protocol_handler: add race condition demo (anon)
2021-03-29 21:56:07 -04:00
luigi1111 eed63cef36
Merge pull request #7615
9ca9f12 Fixed issues found by static analysis (SChernykh)
2021-03-29 21:54:25 -04:00
selsta c18cdd3623
build: prepare v0.17.2.0 2021-03-26 01:53:45 +01:00
anon 21ab1de89f
cryptonote_protocol_handler: fix race condition 2021-03-22 19:42:45 +00:00
luigi1111 9ec4ce36c7
Merge pull request #7419
25588de trezor: simplify recognition of integrated addresses (Dusan Klinec)
2021-03-20 01:54:52 -04:00
SChernykh 9ca9f1214a Fixed issues found by static analysis
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2021-03-18 21:57:13 +01:00
moneromooo-monero 4a9ae3eb8b
fix serialization being different on mac
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.

There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:41:19 +00:00
luigi1111 af46a291ad
Merge pull request #7336
d8137dc device_trezor: add redundant check (anon)
c6e1d7b device_trezor: wipe string fields properly (anon)
2021-03-05 13:53:00 -05:00
Dusan Klinec 25588de40c
trezor: simplify recognition of integrated addresses
now it is possible to simplify integrated addresses recognition using transaction destination info directly
fixes https://github.com/monero-project/monero-gui/issues/3346
2021-03-03 15:39:12 +01:00
moneromooo-monero b5667c9f6c
p2p: allow CIDR notation in DNS blocklist 2021-01-21 01:41:31 +00:00
anon d8137dc523 device_trezor: add redundant check 2021-01-20 22:07:13 +01:00
anon c6e1d7bcdf device_trezor: wipe string fields properly 2021-01-20 22:07:13 +01:00
moneromooo-monero fe6dda9453
p2p: only log to global when a blocked IP is not already blocked 2021-01-08 15:50:10 +00:00
Lee Clagett ba3c627c57 Command max_bytes moved from dynamic map to static switch 2020-12-23 23:53:27 +00:00
luigi1111 83fa752a84
Merge pull request #7267
c2295f5 protocol: handle receiving a block hash we've not added yet (moneromooo-monero)
2021-01-06 21:09:36 -05:00
luigi1111 7ecdc53e11
Merge pull request #7248
3c7eec1 add a max levin packet size by command type (moneromooo-monero)
2021-01-06 21:08:11 -05:00
Alexander Blair f3de67bc21
Merge pull request #7269
1128146c4 blockchain: lock access to m_blocks_hash_of_hashes (moneromooo-monero)
2021-01-03 18:29:39 -08:00
moneromooo-monero 3c7eec152c
add a max levin packet size by command type 2021-01-03 14:07:58 +00:00
moneromooo-monero 1128146c49
blockchain: lock access to m_blocks_hash_of_hashes
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
2021-01-02 22:20:24 +00:00
moneromooo-monero c2295f55b8
protocol: handle receiving a block hash we've not added yet 2021-01-02 22:10:44 +00:00
selsta 31b2572ec7
build: prepare v0.17.1.9 2021-01-02 18:13:47 +01:00
Alexander Blair a4ffad75ac
Merge pull request #7247
57f7c2e53 protocol: more sanity checks in new chain block hashes (moneromooo-monero)
2021-01-01 22:43:46 -08:00
Alexander Blair db686707cb
Merge pull request #7239
e685f52e2 p2p: fix deadlock banning while updating peer lists (moneromooo)
2021-01-01 22:42:17 -08:00
Alexander Blair 5767e6db90
Merge pull request #7235
00253b717 protocol: don't reset last request time on an idle timer (moneromooo-monero)
2021-01-01 22:41:54 -08:00
moneromooo-monero 57f7c2e53f
protocol: more sanity checks in new chain block hashes 2020-12-31 23:34:26 +00:00
moneromooo e685f52e25
p2p: fix deadlock banning while updating peer lists 2020-12-31 03:15:11 +00:00
moneromooo-monero 00253b717c
protocol: don't reset last request time on an idle timer
this prevents losing time of "idle time" for a peer, which could
otherwise be reset by another timed sync command from the peer
2020-12-30 14:21:57 +00:00
Lee Clagett 7d67a2dde0 Add aggressive restrictions to pre-handshake p2p buffer limit 2020-12-29 19:58:53 -05:00
moneromooo-monero 218a109677
rpc: limit the number of txes for get_blocks.bin 2020-12-29 04:32:33 +00:00
Alexander Blair 5804add75b
Merge pull request #7206
8c8f3d73b protocol: fix false positives dropping peers (moneromooo-monero)
2020-12-28 11:40:26 -08:00
Alexander Blair a87eca5e7d
Merge pull request #7197
0443cccb5 cryptonote_basic: guess what got lost porting patches to branches again (moneromooo-monero)
2020-12-28 11:39:58 -08:00
moneromooo-monero 8c8f3d73b5
protocol: fix false positives dropping peers
it'd trigger on reorgs
2020-12-27 14:42:59 +00:00
luigi1111 e42bb297b8
Revert "Reject existing claimed blocks in sync mode" 2020-12-27 00:16:56 -05:00
moneromooo-monero 0443cccb5d
cryptonote_basic: guess what got lost porting patches to branches again 2020-12-26 23:44:34 +00:00
Alexander Blair 138092ddc9
Merge pull request #7189
adcbcd8f8 protocol: drop nodes if they claim new data but only give stale data (moneromooo-monero)
2020-12-26 14:14:16 -08:00
Alexander Blair 4ddde36c50
Merge pull request #7183
ba60541f3 build: prepare v0.17.1.8 (selsta)
2020-12-26 14:00:06 -08:00
Alexander Blair 0873f3193a
Merge pull request #7181
e35bbb1e8 ban lists may now include subnets (moneromooo-monero)
2020-12-26 13:59:51 -08:00
Alexander Blair cbeaeb904b
Merge pull request #7174
5c3e84b6a restrict public node checks a little (moneromooo-monero)
2020-12-26 13:59:09 -08:00
Alexander Blair 355be543c7
Merge pull request #7161
07b50c42d rpc: get_info - add 'synchronized' field (xiphon)
2020-12-26 13:58:19 -08:00
Alexander Blair 6cea8ca895
Merge pull request #7155
42ee30929 protocol: reject claimed block hashes that already are in the chain (moneromooo-monero)
a436c3625 protocol: drop peers we can't download anything from in sync mode (moneromooo-monero)
2020-12-26 13:58:06 -08:00
Alexander Blair e08d37fc7b
Merge pull request #7146
3bb748ad9 p2p: remove peers from grey and anchors lists when blocked (moneromooo-monero)
2020-12-26 13:57:54 -08:00
Alexander Blair 1c14b7b3b2
Merge pull request #7139
fb9ef2426 Optional DNS based blocklist (moneromooo-monero)
2020-12-26 13:57:25 -08:00
moneromooo-monero adcbcd8f8b
protocol: drop nodes if they claim new data but only give stale data
Some joker is spending time actually doing this
2020-12-25 20:31:23 +00:00
xiphon 07b50c42dd rpc: get_info - add 'synchronized' field 2020-12-23 10:43:47 +00:00
selsta ba60541f3e
build: prepare v0.17.1.8 2020-12-23 02:13:16 +01:00
moneromooo-monero 5c3e84b6ae
restrict public node checks a little
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:19 +00:00
moneromooo-monero e35bbb1e88
ban lists may now include subnets 2020-12-22 02:12:58 +00:00
moneromooo-monero fb9ef24267
Optional DNS based blocklist
If enabled, pulls IPs to block on blocklist.moneropulse.*, and
blocks then for 8 days (so IPs dropping from the list will
eventually get unblocked, and DNS failures don't result in
instant clearing of the blocklist).

Enable with --enable-dns-blocklist
2020-12-20 02:34:24 +00:00
luigi1111 e0e2eb2bf5
Merge pull request #7144
a569483 p2p: ignore incoming peer list entries when we have them blocked (moneromooo-monero)
2020-12-19 17:25:11 -06:00
luigi1111 ecedaf2975
Merge pull request #7142
905cc07 daemon: the ban command can now load IPs from a file (ban @filename) (moneromooo-monero)
2020-12-19 17:23:52 -06:00
moneromooo-monero a4cdcd9bd0
rpc: add a busy_syncing field to get_info
true if and pretty much only if new blocks are being added
2020-12-17 18:11:56 +00:00
moneromooo-monero 42ee309292
protocol: reject claimed block hashes that already are in the chain 2020-12-17 03:00:39 +00:00
moneromooo-monero a436c36256
protocol: drop peers we can't download anything from in sync mode
instead of the (incorrect) check for whether we think we might have
a user for it at some point in the near future. We can reconnect.
2020-12-16 20:20:17 +00:00
moneromooo-monero 905cc07c8b
daemon: the ban command can now load IPs from a file (ban @filename) 2020-12-14 12:26:37 +00:00
moneromooo-monero 3bb748ad94
p2p: remove peers from grey and anchors lists when blocked 2020-12-13 23:27:56 +00:00
moneromooo-monero a569483c19
p2p: ignore incoming peer list entries when we have them blocked 2020-12-13 23:14:22 +00:00
luigi1111 54a4071473
Merge pull request #7131
c1d6547 protocol: include first new block in chain entry response (moneromooo-monero)
2020-12-12 22:05:41 -06:00
luigi1111 4f70af3af1
Merge pull request #7128
b6b2c9b protocol: stricter checks on received chain hash list (moneromooo)
2020-12-12 22:03:59 -06:00
moneromooo-monero c1d654708f
protocol: include first new block in chain entry response 2020-12-12 01:36:56 +00:00
moneromooo b6b2c9b8e8
protocol: stricter checks on received chain hash list 2020-12-11 18:47:28 +00:00
moneromooo-monero d6069f7ded
protocol: revert incoming chain height check against local chain
We can actually request a chain that's further away from what we
have as we buffer more and more
2020-12-11 02:37:33 +00:00
Alexander Blair 7a9ba3f154
Merge pull request #7122
3a3370096 protocol: one more sanity check on usable data from a peer (moneromooo-monero)
2020-12-10 17:57:18 -08:00
Alexander Blair 575f6b5f13
Merge pull request #7120
105afa555 protocol: fix asking for pruned blocks for v10 (moneromooo-monero)
2020-12-10 17:57:07 -08:00
Alexander Blair d6b2c676a9
Merge pull request #7118
ef1524ecc protocol: add a sanity check to the number of block hashes sent (moneromooo-monero)
2020-12-10 17:56:53 -08:00
Alexander Blair 5d39df5d92
Merge pull request #7116
a700e6103 build: prepare v0.17.1.7 (selsta)
2020-12-10 17:56:38 -08:00
Alexander Blair f9eee6f193
Merge pull request #7111
d729730d3 protocol: drop origin IP if a block fails to verify in sync mode (moneromooo-monero)
2020-12-10 17:55:59 -08:00
Alexander Blair 37800ceb5b
Merge pull request #7107
f47f1a069 protocol: more restrictive checks on chain entry response (moneromooo-monero)
2020-12-10 17:55:42 -08:00
moneromooo-monero 3a3370096e
protocol: one more sanity check on usable data from a peer 2020-12-10 23:02:38 +00:00
moneromooo-monero 105afa5557
protocol: fix asking for pruned blocks for v10
Old format is still alloewd there, this is a two fork update
2020-12-10 22:56:52 +00:00
moneromooo-monero d729730d38
protocol: drop origin IP if a block fails to verify in sync mode
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
2020-12-10 22:00:01 +00:00
luigi1111 f570ce1349
Merge pull request #7109
e83a220 protocol: fix switchting to adding blocks if noone's adding the next span (moneromooo-monero)
2020-12-10 15:49:20 -06:00
moneromooo-monero ef1524ecca
protocol: add a sanity check to the number of block hashes sent 2020-12-10 19:26:50 +00:00
selsta a700e6103b
build: prepare v0.17.1.7 2020-12-10 20:12:27 +01:00
moneromooo-monero f47f1a0691
protocol: more restrictive checks on chain entry response 2020-12-10 17:24:16 +00:00
moneromooo-monero e83a220603
protocol: fix switchting to adding blocks if noone's adding the next span 2020-12-10 15:46:29 +00:00
luigi1111 f7aa91f70d
Merge pull request #7076
37bb594 Do not use peer_id tracking method over i2p/tor (Lee Clagett)
2020-12-07 10:26:15 -06:00
luigi1111 f9a70e4260
Merge pull request #7073
446b3c8 p2p: drop peers that spam peer lists (moneromooo-monero)
2020-12-07 10:25:38 -06:00
luigi1111 f105a0ef38
Merge pull request #7071
21b3ff2 p2p: fix race condition accessing a deleted context (moneromooo-monero)
2020-12-07 10:23:57 -06:00
luigi1111 1cb3ea0447
Merge pull request #7065
b34d50f build: prepare v0.17.1.6 (selsta)
2020-12-07 10:22:38 -06:00
luigi1111 43788ffd2a
Merge pull request #7063
7982ef5 crypto: fix non zero scalar being 0 after reducing (moneromooo-monero)
2020-12-07 10:20:19 -06:00
luigi1111 6d35b667cf
Merge pull request #7054
ce26c5b protocol: drop peers that don't reply to queries (moneromooo)
9427b5a keep only the last seen node on a given host in the white list (moneromooo)
fa79148 protocol: drop peers that decrease claimed height (moneromooo)
1382b17 protocol: add scoring system to drop peers that don't behave (moneromooo)
2020-12-07 10:04:08 -06:00
moneromooo ce26c5b2dd
protocol: drop peers that don't reply to queries 2020-12-06 15:57:23 +00:00
moneromooo-monero 21b3ff2c90
p2p: fix race condition accessing a deleted context 2020-12-06 12:42:11 +00:00
moneromooo-monero 446b3c865b
p2p: drop peers that spam peer lists
There's always some people who just want to abuse things
2020-12-05 13:41:48 +00:00
moneromooo 9427b5a6d5
keep only the last seen node on a given host in the white list 2020-12-04 01:55:05 +00:00
moneromooo fa79148e0c
protocol: drop peers that decrease claimed height 2020-12-04 01:55:04 +00:00
moneromooo 1382b17aa1
protocol: add scoring system to drop peers that don't behave 2020-12-04 01:55:01 +00:00
moneromooo-monero 7982ef5a73
crypto: fix non zero scalar being 0 after reducing 2020-12-04 01:00:22 +00:00
selsta b34d50fa76
build: prepare v0.17.1.6 2020-12-03 21:37:33 +01:00
selsta 93135907dd wallet2: set propagation timeout to current max timeout 2020-12-03 02:24:52 +01:00
Alexander Blair 065bb292df
Merge pull request #7010
a8cd073fc Add rpc-restricted-bind-ip option (Howard Chu)
2020-12-01 14:22:39 -08:00