Riccardo Spagni
438781afc4
Merge pull request #4221
...
62511df6b219c24c5b6bcca3
2018-09-14 12:38:36 +02:00
moneromooo-monero
ac4f71c200
wallet2: bump testnet rollback to account for coming reorg
2018-09-11 13:38:35 +00:00
moneromooo-monero
a1359ad43c
Check inputs to addKeys are in range
...
Reported by QuarksLab.
2018-09-11 13:38:09 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size
2018-09-11 13:38:07 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests
...
Also constrains bulletproofs to simple rct, for simplicity
2018-09-11 13:37:37 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct
2018-09-11 13:37:28 +00:00
naughtyfox
7a76354c8b
wallet2: import_multisig forward refresh exception
2018-09-10 18:45:37 +03:00
moneromooo-monero
44439c3208
record blackballs as amount/offset, and add export ability
2018-09-10 09:04:18 +00:00
moneromooo-monero
50cb370d5b
ringdb: allow blackballing many outputs at once
...
It cuts down on txn commits, and speeds up blackballing substantially
2018-09-09 12:01:43 +00:00
moneromooo-monero
df0e7c2feb
wallet2: fix secondary partially signed multisig txes
2018-09-08 23:12:06 +00:00
luigi1111
77ed11e627
Merge pull request #4270
...
29dea0376affd9dc6c06976ac5a8
2018-09-04 13:19:58 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268
...
1f2409e
2018-09-04 13:16:04 -05:00
luigi1111
6d4d4ddb68
Merge pull request #4252
...
ac09cfa
2018-09-04 13:05:12 -05:00
stoffu
5f8f56315c
wallet2.get_reserve_proof: throw when specified amount is zero
2018-09-04 13:00:38 +09:00
moneromooo-monero
20171746de
wallet2: factor the creation of a new wallet keys file
2018-09-03 11:27:46 +00:00
moneromooo-monero
be6acfd5be
wallet2: factor new blockchain setup
2018-09-03 11:27:43 +00:00
moneromooo-monero
88fbc4a567
wallet2: fill in v2 height for stagenet
2018-09-03 11:26:28 +00:00
stoffu
8ca1215f25
wallet: store trusted-daemon flag in wallet2
2018-08-23 14:55:09 +09:00
luigi1111
1db7a29e12
Merge pull request #4247
...
10475ab
2018-08-22 21:04:34 -05:00
luigi1111
6e8e4fb3b7
Merge pull request #4202
...
8439306
2018-08-22 20:42:20 -05:00
moneromooo-monero
62511df622
wallet2: fix refresh retry when a block/tx fails to parse
...
It would switch to a new set of blocks and fail, getting out of sync
with the hash chain in the process
2018-08-22 09:57:46 +00:00
moneromooo-monero
b219c24c3a
wallet2: trim hash chain after fast refresh of hashes
...
This ensures it can't end up filled with the actual placeholders
2018-08-22 09:57:42 +00:00
moneromooo-monero
5b6bcca32a
wallet2: fix checking the wrong vector when adding hashes
...
The two vectors should be the same size anyway, so add an assert
to catch any case where they aren't
2018-08-22 09:57:39 +00:00
moneromooo-monero
76ac5a8fbe
wallet2: ask for a binary output distribution, for speed
2018-08-19 15:58:25 +00:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key
2018-08-16 22:26:30 +09:00
moneromooo-monero
ab74dc277a
crypto: make secret_key automatically mlock
2018-08-16 11:57:49 +00:00
moneromooo-monero
e9ffa91257
store secret keys encrypted where possible
...
The secret spend key is kept encrypted in memory, and
decrypted on the fly when needed.
Both spend and view secret keys are kept encrypted in a JSON
field in the keys file. This avoids leaving the keys in
memory due to being manipulated by the JSON I/O API.
2018-08-16 11:57:43 +00:00
moneromooo-monero
ea37614efe
wallet: wipe seed from memory where appropriate
2018-08-16 09:17:52 +00:00
stoffu
a64f57fe42
wallet2: make --restricted-rpc available for wallet RPC only
2018-08-16 09:54:23 +09:00
luigi1111
e69e0e9e34
Merge pull request #4194
...
0f75717
2018-08-15 17:56:23 -05:00
luigi1111
1c55a3756b
Merge pull request #4193
...
4520cfd
2018-08-15 17:54:49 -05:00
luigi1111
8d2e454929
Merge pull request #4188
...
a3fe1c5
2018-08-15 17:47:05 -05:00
luigi1111
7aa2030cee
Merge pull request #4174
...
ff37bd0
2018-08-15 17:40:55 -05:00
luigi1111
564e9c3b5f
Merge pull request #4170
...
1c6cfd3
2018-08-15 17:35:49 -05:00
luigi1111
5e795ee7af
Merge pull request #4153
...
37f0799
2018-08-15 17:23:56 -05:00
luigi1111
2a44c2defd
Merge pull request #4150
...
f2e65c6
2018-08-15 17:22:36 -05:00
luigi1111
017e07a035
Merge pull request #4103
...
bcab579
2018-08-15 17:09:52 -05:00
luigi1111
4cde4cb946
Merge pull request #3528
...
34d4b79
2018-08-15 17:00:32 -05:00
fireice-uk
10475ab23f
node_rpc_proxy: fix fork earliest height caching [RYO backport]
...
xref https://github.com/ryo-currency/ryo-currency/pull/86
2018-08-13 22:16:17 +02:00
moneromooo-monero
ac09cfa6be
wallet2: remove obsolete pruned/unpruned case
...
All daemons will not support pruned blocks
2018-08-13 13:17:27 +00:00
stoffu
bcab579864
wallet: allow adjusting number of rounds for the key derivation function
2018-08-08 01:56:54 +09:00
moneromooo-monero
37f0799284
wallet: distinguish coinbase from other txes in show_transfers
2018-08-03 12:48:16 +00:00
moneromooo-monero
8439306212
wallet2: do not divide by 0 on invalid daemon response
2018-07-31 14:26:00 +00:00
stoffu
1c6cfd34f4
wallet-rpc: add get_address_index command
2018-07-31 21:36:12 +09:00
moneromooo-monero
0f757177fe
wallet2: avoid using arbitrary random values when unknown
2018-07-30 13:34:15 +01:00
moneromooo-monero
4520cfd978
wallet2: guard against bad outputs in import_outputs
...
also some minor speedup
2018-07-30 13:21:58 +01:00
stoffu
a3fe1c56ee
simplewallet: add set_tx_key for importing tx keys from 3rd party wallets
2018-07-30 20:50:05 +09:00
luigi1111
f739a3cbb8
Merge pull request #4109
...
2951436
2018-07-27 14:27:47 -05:00
luigi1111
92b5d6c204
Merge pull request #4091
...
a4272de
2018-07-27 14:22:34 -05:00
moneromooo-monero
ff37bd00bc
wallet2: fix O(n^2) behaviour in import_key_images
...
That takes a lot of time for even not so large wallets
2018-07-24 14:34:19 +01:00
luigi1111
702a41034d
Merge pull request #4088
...
8c4db68
2018-07-19 14:15:16 -05:00
luigi1111
5c102c60dc
Merge pull request #4087
...
d6440ab
2018-07-19 14:14:10 -05:00
luigi1111
be81a27fa4
Merge pull request #4071
...
d6d78f1
2018-07-19 14:06:54 -05:00
luigi1111
9315e12d34
Merge pull request #4033
...
3e46db9
2018-07-19 13:55:37 -05:00
stoffu
f2e65c6e50
wallet2: consider minimum fee when testing if balance is sufficient
2018-07-19 20:31:07 +09:00
moneromooo-monero
d6440ab319
wallet2: recover from index out of hashchain bounds error
...
This can happen when there's a very large reorg on the daemon
(ie, on testnet)
2018-07-16 23:13:56 +01:00
moneromooo-monero
2951436704
wallet: warn when payment IDs are used
...
Subaddresses are better for privacy
2018-07-12 19:37:29 +01:00
moneromooo-monero
fc39d3b23c
wallet2: ensure outputs are processed only once
...
This should be proof against any way one might get to multiple
processing, such as generating the same derivation from the
same pubkey, etc
2018-07-08 12:56:51 +01:00
moneromooo-monero
34d4b798d4
wallet2: use a gamma distribution to pick fake outs
...
as per "An Empirical Analysis of Linkability in the Monero
Blockchain", by Miller et al.
2018-07-03 18:10:48 +01:00
Riccardo Spagni
40f85f478e
Merge pull request #3985
...
58cceaad
2018-07-03 15:51:41 +02:00
Riccardo Spagni
f449dbe8eb
Merge pull request #4041
...
df9d50a8
2018-07-03 15:20:42 +02:00
Riccardo Spagni
97f5a130d6
Merge pull request #4028
...
2a19697b
2018-07-03 15:19:24 +02:00
Riccardo Spagni
27ca6ca594
Merge pull request #4004
...
bc443494
2018-07-03 15:16:37 +02:00
moneromooo-monero
58cceaad71
wallet2: fix double counting outs if the tx pubkey is duplicated
2018-07-03 14:16:30 +01:00
stoffu
a4272de797
wallet2: unlock keys file before calling verify_password (needed for Windows)
...
Also added notes to WalletManager::verifyWalletPassword (which afaik seems unused
by anyone at the moment) regarding the need to unlock the keys file beforehand.
2018-07-03 18:07:20 +09:00
stoffu
d6d78f157b
Allow fractional outputs to be ignored
2018-07-03 18:04:31 +09:00
moneromooo-monero
8c4db68ff7
node_rpc_proxy: factor a few RPC calls using get_info
...
Takes advantage of caching
2018-07-02 17:59:44 +01:00
luigi1111
a9b83f5a6e
Merge pull request #4067
...
9a39b7d
2018-06-27 21:28:34 -05:00
stoffu
3d623a86d1
wallet: prevent the same wallet file from being opened by multiple processes
2018-06-28 09:41:43 +09:00
moneromooo-monero
9a39b7dd7f
wallet2: fix build for windows (std::max again)
2018-06-28 00:47:48 +01:00
luigi1111
2329d2f4c8
Merge pull request #3907
...
dcbc17e
2018-06-27 16:32:33 -05:00
luigi1111
8a27caeb22
Merge pull request #3998
...
8db23df
2018-06-27 16:30:38 -05:00
luigi1111
9453573581
Merge pull request #3995
...
0a5292c
2018-06-27 16:28:57 -05:00
luigi1111
c28a2b0d7d
Merge pull request #3992
...
25c15dc
2018-06-27 16:26:23 -05:00
luigi1111
5eb2e01216
Merge pull request #3991
...
798dfcf
2018-06-27 16:25:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982
...
08b85a80cf80ba
2018-06-27 15:38:23 -05:00
moneromooo-monero
dcbc17e97e
wallet: include a suggested number of confirmations based on amount
...
This is based on how much an attacking miner stands to lose in block
rewardy by mining a private chain which double spends a payment.
This is not foolproof, since mining is based on luck, and breaks
down as the attacking miner nears 50% of the network hash rate,
and the estimation is based on a constant block reward.
2018-06-27 21:38:21 +01:00
luigi1111
a844844cda
Merge pull request #3716
...
a2b557f6795bd0209ec96ed2c81ea830db257ea90231a895eba8331cf7f191741be339f025ae9ef2cb63dcfd2995d3e70227046242771a180e4c7d0
2018-06-27 15:33:01 -05:00
moneromooo-monero
0e4c7d0fae
wallet2: cache ringdb key while refreshing
...
Speeds up syncing with a lot of outgoing outputs as key generation
runs Cryptonight.
2018-06-26 22:15:38 +01:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently
...
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
2018-06-26 22:15:22 +01:00
moneromooo-monero
2704624eae
wallet2: remove unneeded divisions
2018-06-26 22:15:20 +01:00
moneromooo-monero
5d3e70229e
wallet2: remove old blockchain size cache hack
2018-06-26 22:15:18 +01:00
moneromooo-monero
dcfd299239
wallet2: speedup refresh
...
key derivation and checking for incoming outputs are threaded
in batch before adding blocks to the local blockchain. Other
minor bits and bobs are also cached.
2018-06-26 22:15:16 +01:00
moneromooo-monero
f025ae9760
wallet2: avoid re-parsing blocks when refreshing in a loop
2018-06-26 22:15:12 +01:00
moneromooo-monero
41be339655
wallet2: avoid duplicate parsing of tx extra
2018-06-26 22:15:10 +01:00
moneromooo-monero
f7f1917ed4
wallet2: remove useless device locking
2018-06-26 22:14:35 +01:00
moneromooo-monero
ba8331ce41
wallet2: parse blocks in the RPC thread, not the processing thread
...
Processing typically is the bottleneck
2018-06-26 22:14:33 +01:00
moneromooo-monero
31a895e876
wallet2: simplify/speedup process_blocks
2018-06-26 22:14:31 +01:00
moneromooo-monero
57ea90285c
wallet: don't process miner tx if we're refreshing with no-coinbase
2018-06-26 22:14:26 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths
...
also use reserve where appropriate
2018-06-26 22:14:21 +01:00
moneromooo-monero
6795bd0d4e
rpc: add option to skip coinbase info in get_blocks.bin
2018-06-26 22:14:16 +01:00
moneromooo-monero
a2b557fe5c
wallet2: use std::move on containers where appropriate
2018-06-26 22:14:14 +01:00
luigi1111
506be80601
Merge pull request #3955
...
d7a6b72
2018-06-25 15:09:48 -05:00
luigi1111
26562e9f3c
Merge pull request #3941
...
bf26920
2018-06-25 14:54:54 -05:00
moneromooo-monero
df9d50a8a4
wallet2: fix read buffer overflow in import_key_images
2018-06-23 09:22:20 +01:00
moneromooo-monero
3e46db97e5
rpc: add a non binary get_transaction_pool_hashes RPC
2018-06-21 09:02:42 +01:00
stoffu
8fc0cdb96f
wallet2: lower default for subaddress lookahead when restoring with hardware
2018-06-21 12:35:23 +09:00
moneromooo-monero
2a19697bd4
wallet2: fix double header in unsigned transfer file
2018-06-19 22:30:02 +01:00
luigi1111
896512b2b6
Merge pull request #3878
...
5a412b7
2018-06-19 12:57:59 -05:00
luigi1111
9226acca4b
Merge pull request #3804
...
89e51ec
2018-06-16 14:15:52 -05:00
luigi1111
4e7897e57c
Merge pull request #3780
...
9c2a7b4
2018-06-16 14:12:57 -05:00
luigi1111
e3012444fb
Merge pull request #3762
...
eb9f3a3
2018-06-16 14:10:11 -05:00
moneromooo-monero
bc443494f3
wallet2: fix out of sync account tag cache
...
This would cause crashes when trying to tag an account that was
just created
2018-06-15 20:18:12 +01:00
moneromooo-monero
8db23df581
wallet: on first refresh, start off with a quantized height
...
for privacy reasons, so an untrusted node can't easily track
wallets from IP address to IP address, etc. The granularity
is 1024 blocks, which is about a day and a half.
2018-06-13 22:44:27 +01:00
stoffu
798dfcfe79
wallet: allow unspendable unmixable outputs to be discarded
2018-06-13 11:56:40 +09:00
stoffu
0a5292c339
wallet2: use decoded amount when reporting repeated output key
2018-06-13 01:06:44 +09:00
stoffu
25c15dca5c
wallet2: use correct fee for split txes
2018-06-12 12:06:51 +09:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-11 20:17:02 +09:00
luigi1111
00635bd68b
Merge pull request #3598
...
b21bc00
2018-06-08 14:40:06 -05:00
luigi1111
1af890287b
Merge pull request #3890
...
f80b157
2018-06-07 12:12:28 -05:00
moneromooo-monero
d7a6b72c15
wallet2: fix bulletproof cold signing
...
Cold signing was always using Borromean range proofs, causing
a larger tx, and an incorrect fee
2018-06-07 12:29:30 +01:00
stoffu
bf26920f27
wallet2: fix get_approximate_blockchain_height for stagenet
2018-06-06 20:33:01 +09:00
Dusan Klinec
9c2a7b4638
wallet-rpc: watch-only and cold wallet features added
...
- unsigned_txset, signed_txset in transfer / submit_transfer / sign_transfer
- export_outputs, import_outputs
Squashed commits:
[f4d9f3d4] wallet-rpc: do_not_relay removed from submit_transfer
[5b16a86f] wallet-rpc: review-fix - method signature changes, renaming
[b7fbb10a] wallet-rpc: naming fixes (unsigned vs signed), consts renamed
[8c7d2727] wallet-rpc: sign_transfer added
[481d024a] wallet2: sign_tx splitted to work with strings and structs, more granular
[2a474db9] wallet-rpc: wallet2::load_unsigned_tx split to load from str, file
[b1e3a018] wallet-rpc: review fix, load_tx_from_str variable rename
[1f6373be] wallet-rpc: review fix: save_tx_to_{str,file}
[2a08eafc] wallet-rpc: review comments fixes
- redundant this removed from wallet2.cpp
- load_tx_from_str, load_tx_from_file
[43498052] wallet-rpc: submit_transfer added
[9c45d1ad] wallet-rpc: watch_only check, return unsigned_txset
[62831396] wallet2: added string variants to load_tx, save_tx
- analogously to save_multisig_tx
- required for monero-wallet-rpc to support watch-only wallet
2018-06-03 13:21:00 +02:00
luigi1111
3a373c3d3a
Merge pull request #3489
...
47fdb7447fdb74
2018-05-31 14:34:34 -05:00
moneromooo-monero
f80b1571c6
wallet2: don't ask for pruned txes yet, we still parse the entire tx
2018-05-31 16:46:58 +01:00
stoffu
0da5d37bf3
wallet: fix shared ring db path
2018-05-31 08:16:45 +09:00
luigi1111
5b189ce2a8
Merge pull request #3405
...
80d2f80
2018-05-29 12:52:43 -05:00
moneromooo-monero
5a412b7a3f
disable file size sanity check when loading the wallet cache
2018-05-28 14:58:22 +01:00
stoffu
cb9c7972b6
Fix output shuffling for multisig
2018-05-20 09:38:41 +09:00
jcktm
89e51ecd38
simple-wallet-cli: Add warnings about inaccurate balances to to watch-only wallet
2018-05-15 15:28:42 +10:00
moneromooo-monero
a58d9738c9
wallet2: consider 6 outputs or less to be unmixable from v7
2018-05-10 21:19:33 +01:00
itssteven
eb9f3a3294
check_spend_proof
...
My intention is to mitigate #3761 by returning "bad signature", rather than throwing an error, as the error is triggered inappropriately in the case of checking a different txid than the one used to create the signature, which causes issues for monerophp: https://github.com/monero-integrations/monerophp/issues/72 & my temp fix: https://github.com/monero-integrations/monerophp/pull/74
2018-05-06 17:42:27 +01:00
Riccardo Spagni
93e76e14a2
Merge pull request #3685
...
ffeeefde2dae0f20
2018-04-28 16:56:22 +02:00
Riccardo Spagni
35299644b2
Merge pull request #3650
...
5bd7f760
2018-04-28 16:54:37 +02:00
naughtyfox
b21bc00704
Wallet: added methods to sign and verify arbitrary message with multisig public signer's key (libwallet & wallet api)
2018-04-25 17:55:54 +03:00
moneromooo-monero
2dae0f203a
wallet2: add missing parameters to get_output_histogram
2018-04-23 10:54:25 +01:00
Mikhail Mitkevichl
5bd7f760e9
import_multisig_info: fix sanity check crash in detach_blockchain
2018-04-21 23:25:01 +03:00
Riccardo Spagni
03ff3be10e
Merge pull request #3672
...
875c1cab70f232178c7363fb
2018-04-21 21:54:08 +02:00
moneromooo-monero
875c1cabb9
wallet2: increase rpc timeout for get_output_distribution
2018-04-19 16:06:26 +01:00
moneromooo-monero
70f2321763
add top height to get_output_distribution, and cache it for rct
...
This should cache the vast majority of calls for long running wallets
2018-04-19 16:06:22 +01:00
stoffu
b5d6c723e9
wallet2: store subaddress lookahead settings
2018-04-12 22:23:53 +09:00
cslashm
94b899db26
Use 'boost' mutex instead of 'std' mutex
2018-04-12 13:58:57 +02:00
cslashm
2c274e05fe
Fix sub-address tx scan.
...
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
2018-04-12 13:58:57 +02:00
Riccardo Spagni
5e08fd89ea
Merge pull request #3549
...
73951cbd25fe67e4
2018-04-12 13:49:33 +02:00
Riccardo Spagni
14c870ee5f
Merge pull request #3615
...
24acb66e
2018-04-12 13:47:54 +02:00
Riccardo Spagni
3b8704b0fa
Merge pull request #3555
...
0b26c4d5
2018-04-12 13:47:39 +02:00
Riccardo Spagni
5d8439e310
Merge pull request #3534
...
eecfb57d
2018-04-12 13:47:20 +02:00
moneromooo-monero
24acb66eac
wallet2: fix misc issues when the ringdb can't be initialized
2018-04-12 11:07:07 +01:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502
...
11c933e1
2018-04-12 11:14:43 +02:00
Riccardo Spagni
96b2fee721
Merge pull request #3536
...
c77d2bfa100b7bc1641dfc99
2018-04-12 11:12:33 +02:00
Riccardo Spagni
1b4dc46129
Merge pull request #3473
...
eaa8bfe70a619f78
2018-04-12 11:05:31 +02:00
Riccardo Spagni
ebb55f797b
Merge pull request #3468
...
0098ed33
2018-04-12 11:00:47 +02:00
moneromooo-monero
73951cbd39
wallet2: request transactions in slices when scanning for known rings
...
This avoid massive memory consumption for huge wallets
2018-04-07 08:31:46 +01:00
moneromooo-monero
25fe67e4cf
rpc: allow getting pruned blocks from gettransactions
...
and get them pruned in find_and_save_rings, since it does not need
the pruned data in the first place.
Also set decode_to_json to false where missing, we don't need this
either.
2018-04-07 08:29:11 +01:00
moneromooo-monero
0b26c4d57c
wallet2: move segregation height to v7
...
since people seem to really want to use things the wrong way.
2018-04-05 12:49:38 +01:00
cslashm
c77d2bfaa0
Add the possibility to export private view key for fast scan.
...
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
2018-03-31 18:00:33 +02:00
moneromooo-monero
eecfb57df9
wallet: warn if not using the default ring size
2018-03-31 15:47:02 +01:00
naughtyfox
5a96056600
WalletApi: getMultisigInfo entry for gui wallets
...
WalletApi: makeMultisig call introduced
WalletApi: finalizeMultisig call introduced
WalletApi: new calls exportMultisigImages and importMultisigImages
WalletApi: method to return multisig wallet creation state
WalletApi: create multisig transaction, sign multisig transaction, commit transaction and get multisig data are added
WalletApi: identation and style fixes
2018-03-28 18:22:13 +03:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd
2018-03-27 14:48:36 +01:00
stoffu
eaa8bfe7c0
wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly
...
The previous expression
req_t.from_height = X ? Y >= Z : 0;
forces the parameter to take the value of either 0 or 1.
2018-03-22 20:02:25 +09:00
