Riccardo Spagni
1c91963dcd
Merge pull request #4308
...
9907ea06
2018-10-26 22:18:28 +02:00
doy-lee
5a2e54a1cb
Fix prune using receive time as tx_weight
2018-10-23 10:03:45 +11:00
xiphon
fd62b6e79f
blocks: use auto-generated .c files instead of 'LD -r -b binary'
2018-10-22 01:12:00 +03:00
moneromooo-monero
3a85af403d
core: fix handle_incoming_tx* comment about return value
2018-10-21 17:09:21 +00:00
Riccardo Spagni
5c418c0522
Merge pull request #4522
...
a39c0358
2018-10-20 20:40:16 +02:00
Riccardo Spagni
a38299801f
Merge pull request #4666
...
cf75ee72
2018-10-20 20:38:37 +02:00
Riccardo Spagni
93f2c13a39
Merge pull request #4637
...
c39e0a17
2018-10-20 20:36:33 +02:00
moneromooo-monero
cf75ee722a
blockchain: move two new verification errors to the verify category
...
Lest we get people get scared again
2018-10-19 21:11:12 +00:00
stoffu
776aefdac1
tx_pool: revert #4592 and move bin2hex conversion to on_get_transaction_pool
2018-10-18 08:01:56 +09:00
moneromooo-monero
c39e0a1706
core: don't verify range proofs multiple times
2018-10-17 16:23:10 +00:00
Riccardo Spagni
c531df734f
Merge pull request #4389
...
6844ae1b
2018-10-15 13:36:15 +02:00
stoffu
a677492f1b
tx_pool: store hex string instead of raw binary to tx_blob of get_transaction_pool RPC
...
Inspired by https://github.com/masari-project/masari/issues/93
2018-10-15 11:57:02 +09:00
Riccardo Spagni
ac5674524a
Revert "Merge pull request #4472 "
...
This reverts commit 79d46c4d55c9fc61dbb5
2018-10-08 21:39:54 +02:00
moneromooo-monero
a39c035846
blockchain: add check test options are given for fakechain mode
...
Coverity 188616
2018-10-08 11:37:58 +00:00
moneromooo-monero
6844ae1b8d
tx_pool: avoid parsing a whole tx if only the prefix is needed
2018-10-08 10:18:01 +00:00
moneromooo-monero
9907ea0694
cryptonote: sort tx_extra fields
...
This removes some small amount of fingerprinting entropy.
There is no consensus rule to require this since this field
is technically free form, and a transaction is free to have
custom data in it.
2018-10-07 11:13:22 +00:00
xiphon
02d3ef7bda
blocks: use auto-generated .c files instead of 'LD -r -b binary'
2018-10-04 00:01:09 +00:00
Riccardo Spagni
d1d64327b6
Merge pull request #4476
...
fa9e54b6
2018-10-02 22:38:32 +02:00
Riccardo Spagni
e2da7c7817
Merge pull request #4467
...
fa942ef6
2018-10-02 22:36:57 +02:00
xiphon
fa9e54b6ee
build: fix gcc false positive 'stringop-overflow' warning
2018-09-30 10:58:00 +00:00
Riccardo Spagni
83d8f03c23
Merge pull request #4333
...
73403004
2018-09-29 22:20:44 +02:00
iDunk5400
fa942ef610
daemon: silence daemon update warnings on testnet
2018-09-29 14:42:10 +02:00
Riccardo Spagni
8bf5a00564
Merge pull request #4423
...
357441a2d9f666d76b1b4e836f153533
2018-09-25 13:33:52 +02:00
Riccardo Spagni
689758d691
Merge pull request #4435
...
c39ad0cd
2018-09-25 13:11:05 +02:00
moneromooo-monero
c39ad0cd72
tx_pool: fix tx removal at startup keeping references
2018-09-25 09:58:37 +00:00
moneromooo-monero
50981c40ce
blockchain: add stagenet v8 and v9, two weeks before mainnet
2018-09-24 20:43:39 +00:00
Riccardo Spagni
d9f666d78c
update checkpoints.dat
2018-09-23 09:51:15 +02:00
Riccardo Spagni
0645dcdbdb
Merge pull request #4378
...
ac934663
2018-09-21 20:41:53 +02:00
Riccardo Spagni
d6893aedf6
Merge pull request #4369
...
b2bb9312befdcbf4
2018-09-21 20:31:21 +02:00
moneromooo-monero
341b3931ed
cryptonote_core: warn when the block rate deviates from expectations
...
The warning threshold is set to allow a false positive every
ten days on average.
2018-09-20 14:01:52 +00:00
Riccardo Spagni
22a6591a70
Merge pull request #4325
...
4e1e9a60
2018-09-18 17:39:16 +02:00
Riccardo Spagni
3584a852a3
Merge pull request #4372
...
1660b0e7
2018-09-14 12:56:01 +02:00
moneromooo-monero
be001326d1
remove obsolete daemon selection of fake outs and old tx construction
2018-09-14 10:51:45 +00:00
moneromooo-monero
ac9346637a
rpc: add a "is an update available" flag in get_info
...
Make it easier for a user to be told when to update
2018-09-14 09:28:03 +00:00
moneromooo-monero
1660b0e72c
tx_pool: make the max tx size a consensus rule from v8
2018-09-13 09:43:29 +00:00
moneromooo-monero
b2bb9312a7
blockchain: simplify output distribution code
2018-09-12 19:20:16 +00:00
moneromooo-monero
9137ad2c63
blockchain: add a testnet v9 a day after v8
...
So that bulletproofs become mandatory
2018-09-11 13:38:36 +00:00
moneromooo-monero
5ffb2ff9b7
v8: per byte fee, pad bulletproofs, fixed 11 ring size
2018-09-11 13:38:07 +00:00
moneromooo-monero
c444b1b229
require canonical multi output bulletproof layout
2018-09-11 13:37:39 +00:00
moneromooo-monero
2a8fcb421b
Bulletproof aggregated verification and tests
...
Also constrains bulletproofs to simple rct, for simplicity
2018-09-11 13:37:37 +00:00
moneromooo-monero
bacf0a1e2f
bulletproofs: add aggregated verification
...
Ported from sarang's java code
2018-09-11 13:37:32 +00:00
moneromooo-monero
9ce9f8caf6
bulletproofs: add multi output bulletproofs to rct
2018-09-11 13:37:28 +00:00
luigi1111
03738fdde1
Merge pull request #4276
...
48a7bc4
2018-09-04 13:25:44 -05:00
luigi1111
5f1bbe3bce
Merge pull request #4268
...
1f2409e
2018-09-04 13:16:04 -05:00
moneromooo-monero
4e1e9a607e
blockchain: add mainnet v8 height targetting 18 october
...
and v9 a day later
2018-09-02 16:02:17 +00:00
luigi1111
ec6982f8eb
Merge pull request #4240
...
83f5587
2018-08-22 20:58:55 -05:00
luigi1111
4a4ea78ecd
Merge pull request #4204
...
b278b83
2018-08-22 20:43:51 -05:00
moneromooo-monero
48a7bc4280
tx_pool: fix infinite loop when failing to find a meta record
2018-08-19 17:47:05 +00:00
stoffu
1f2409e9e2
Do memwipe for critical secret keys copied to rct::key
2018-08-16 22:26:30 +09:00
moneromooo-monero
82d1b74500
core: cache block template where possible
...
This avoids constant rechecking of the same things each time
a miner asks for the block template. The tx pool maintains
a cookie to allow users to detect when the pool state changed,
which means the block template needs rebuilding.
2018-08-16 12:44:33 +00:00
luigi1111
fd3b71129b
Merge pull request #4164
...
8e24533
2018-08-15 17:31:24 -05:00
moneromooo-monero
b278b83860
core: sync database based on bytes added, not blocks added
...
Blocks have a very wide range, whereas actual size is the relevant
quantity to consider when syncing
2018-08-12 16:13:46 +00:00
moneromooo-monero
83f5587167
blockchain: use uint64_t for height, not size_t
2018-08-09 17:09:26 +00:00
luigi1111
dda05f357a
Merge pull request #4108
...
8c05237
2018-07-27 14:26:01 -05:00
moneromooo-monero
8e24533a7f
blockchain: some batch tx scanning speedup
2018-07-21 12:05:12 +01:00
luigi1111
61eea83978
Merge pull request #4081
...
d95bc44
2018-07-19 14:12:30 -05:00
luigi1111
9474567d76
Merge pull request #4076
...
aa0ea0a
2018-07-19 14:11:24 -05:00
luigi1111
5cade94189
Merge pull request #4047
...
41b4bf9
2018-07-19 14:02:20 -05:00
luigi1111
21afa71ba6
Merge pull request #3981
...
45e419b
2018-07-19 13:39:24 -05:00
luigi1111
d518dae4bf
Merge pull request #3973
...
50af357
2018-07-19 13:37:10 -05:00
luigi1111
025187e6c9
Merge pull request #3854
...
149da4234cb6b49e1403e207b66e
2018-07-19 13:35:25 -05:00
moneromooo-monero
45e419bd5c
db: store cumulative rct output distribution in the db for speed
...
This gets rid of the temporary precalc cache.
Also make the RPC able to send data back in binary or JSON,
since there can be a lot of data
This bumps the LMDB database format to v3, with migration.
2018-07-13 11:37:04 +01:00
moneromooo-monero
8c0523771f
blockchain: cache next block difficulty after adding a block
...
It's not 100% certain it'll be needed, but it avoids getinfo
needing the blockchain lock and potentially blocking
2018-07-07 19:34:21 +01:00
moneromooo-monero
d95bc44c6b
blockchain: fix getting invalid block data on failure
2018-06-29 15:50:34 +01:00
victorsintnicolaas
34cb6b4b70
add --regtest and --fixed-difficulty for regression testing
...
on_generateblocks RPC call combines functionality from the on_getblocktemplate and on_submitblock RPC calls to allow rapid block creation. Difficulty is set permanently to 1 for regtest.
Makes use of FAKECHAIN network type, but takes hard fork heights from mainchain
Default reserve_size in generate_blocks RPC call is now 1. If it is 0, the following error occurs 'Failed to calculate offset for'.
Queries hard fork heights info of other network types
2018-06-29 10:06:11 +02:00
moneromooo-monero
aa0ea0aafc
blockchain: set the m_verifivation_failed flag in a couple more places
...
when a block being added to the main chain is invalid.
This ensures the peer is banned after a number of these.
2018-06-28 16:57:22 +01:00
moneromooo-monero
84d9e7faec
blockchain: fix build after waiter::wait prototype change
2018-06-28 00:24:39 +01:00
luigi1111
87d7612311
Merge pull request #3986
...
b628503
2018-06-27 16:22:03 -05:00
luigi1111
3ad4ecd4ff
Merge pull request #3982
...
08b85a80cf80ba
2018-06-27 15:38:23 -05:00
luigi1111
a844844cda
Merge pull request #3716
...
a2b557f6795bd0209ec96ed2c81ea830db257ea90231a895eba8331cf7f191741be339f025ae9ef2cb63dcfd2995d3e70227046242771a180e4c7d0
2018-06-27 15:33:01 -05:00
moneromooo-monero
2771a18e85
threadpool: allow leaf functions to run concurrently
...
Decrease the number of worker threads by one to account
for the fact the calling thread acts as a worker thread now
2018-06-26 22:15:22 +01:00
moneromooo-monero
ef2cb63287
blockchain: simplify/speedup handle_get_objects
2018-06-26 22:15:14 +01:00
moneromooo-monero
a830db2577
rpc: rework to avoid repeated calculations in get_blocks.bin
2018-06-26 22:14:23 +01:00
moneromooo-monero
ed2c81ed95
replace std::list with std::vector on some hot paths
...
also use reserve where appropriate
2018-06-26 22:14:21 +01:00
moneromooo-monero
50af3579ee
alt_chain_info can now give more info about a particular alt chain
2018-06-26 08:19:51 +01:00
luigi1111
14372ca95a
Merge pull request #3975
...
2d5921e
2018-06-25 15:24:45 -05:00
luigi1111
c3ec5373b3
Merge pull request #3936
...
d81e042
2018-06-25 14:53:27 -05:00
moneromooo-monero
41b4bf9d6d
tx_pool: cache check_tx_inputs results
...
This is called a lot when creating a block template, and
does not change until the blockchain changes.
This also avoids tx parsing when cached.
2018-06-24 11:22:26 +01:00
luigi1111
9eb51887b0
Merge pull request #3919
...
ace2eda
2018-06-20 14:39:09 -05:00
luigi1111
5a221c0e48
Merge pull request #3904
...
4f3a4fb
2018-06-20 14:33:08 -05:00
luigi1111
81a2ff768b
Merge pull request #3903
...
2b0c632
2018-06-20 14:31:33 -05:00
luigi1111
50bc95519e
Merge pull request #3828
...
16e209e
2018-06-19 12:41:07 -05:00
luigi1111
cfd66dae4b
Merge pull request #3691
...
db55263ce173cb3147468
2018-06-17 22:04:39 -05:00
luigi1111
fb2b16f10a
Merge pull request #3732
...
fa0839f
2018-06-16 14:05:53 -05:00
luigi1111
b3363e8e0a
Merge pull request #3726
...
b5cb1bc
2018-06-16 14:02:56 -05:00
luigi1111
6be2516140
Merge pull request #3687
...
6b13976
2018-06-12 12:22:12 -05:00
Jean Pierre Dudey
b628503bad
Remove old logic saved in comments.
...
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-06-11 09:36:05 -04:00
stoffu
08b85a8e00
cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-06-11 20:17:02 +09:00
moneromooo-monero
2d5921eefa
blockchain: avoid duplicate db query for height
2018-06-09 19:51:27 +01:00
luigi1111
2619d966c6
Merge pull request #3908
...
827ca3f95ccf50
2018-06-08 14:53:54 -05:00
luigi1111
22c8730261
Merge pull request #3450
...
3b941be
2018-06-08 14:31:49 -05:00
luigi1111
8a1f0d7d13
Merge pull request #3940
...
f24cbc5
2018-06-07 12:19:43 -05:00
moneromooo-monero
f24cbc5245
blockchain: fix deadlock with the difficulty cache
2018-06-06 10:37:51 +01:00
moneromooo-monero
d81e042306
tx_pool: initialize bitflags padding since it gets written to storage
...
Avoids valgrind reporting uninitialized data usage
2018-06-05 20:26:44 +01:00
stoffu
ace2edacb6
blockchain: pop forked blocks only when DB is not read-only
2018-06-04 20:59:50 +09:00
moneromooo-monero
f0322a083a
blockchain: demote a hash-of-hashes validation warning to debug
...
This data comes from untrusted peers, and validation failures
are therefore normal.
2018-06-02 23:48:12 +01:00
Riccardo Spagni
95ccf508cd
update checkpoints.dat for point release
2018-06-02 14:31:37 +02:00
moneromooo-monero
2b0c632f32
tx_pool: hold off parsing a tx blob till we actually need it
2018-06-02 09:17:41 +01:00
moneromooo-monero
4f3a4fb701
blockchain: return error when requesting non existent output
...
avoids RPC thread dying, causing the wallet to timeout
2018-06-01 21:52:04 +01:00
luigi1111
9bc8f76924
Merge pull request #3525
...
66a659b
2018-05-30 16:08:50 -05:00
luigi1111
a7ea14dc6a
Merge pull request #3876
...
740da1be942d34
2018-05-30 15:46:13 -05:00
luigi1111
4267a0bb51
Merge pull request #3731
...
a66f152
2018-05-30 15:44:25 -05:00
luigi1111
c534fe8d19
Merge pull request #3251
...
b9389e5
2018-05-29 17:56:26 -05:00
luigi1111
ed72f35e9a
Merge pull request #3446
...
a6b8d3f
2018-05-29 12:57:43 -05:00
luigi1111
764340d112
Merge pull request #3420
...
a6a54fa
2018-05-29 12:55:19 -05:00
moneromooo-monero
740da1ba95
core: fix automatic safe db sync mode switching
2018-05-28 12:14:04 +01:00
stoffu
a6b8d3fee1
tx_pool: remove old comment from fill_block_template()
2018-05-28 13:41:39 +09:00
moneromooo-monero
b9389e582e
db_lmdb: save pruned and prunable tx data separately
...
This bumps DB version to 2, migration code will run for v1 DBs
2018-05-23 22:48:12 +01:00
Riccardo Spagni
45975fd8eb
update checkpoints
2018-05-23 21:20:15 +02:00
Riccardo Spagni
f794d3b3df
Merge pull request #3787
...
ce63ab09
2018-05-21 21:36:38 +02:00
Riccardo Spagni
709658d166
Merge pull request #3832
...
cb9c7972
2018-05-21 20:57:52 +02:00
moneromooo-monero
5f8ffca34d
speed up get_output_distribution (and precalc common case)
2018-05-21 19:51:58 +01:00
Riccardo Spagni
791da4343c
Merge pull request #3749
...
872cb4ef
2018-05-21 20:45:35 +02:00
moneromooo-monero
ce173cbb5b
core: remove threadpool dependency from header
2018-05-20 12:06:07 +01:00
stoffu
cb9c7972b6
Fix output shuffling for multisig
2018-05-20 09:38:41 +09:00
moneromooo-monero
16e209e08d
core: lock incoming tx lock when checking the txpool and chain
...
This gets rid of an innocuous race trying to add the same tx
twice to the txpool
2018-05-18 09:39:56 +01:00
Thaer Khawaja
a66f152f75
Use median timestamp if current time renders a block invalid.
2018-05-13 11:58:05 -07:00
moneromooo-monero
b5cb1bc403
blockchain: avoid exception if asked for a block we do not have
...
This can happen if a peer tries to obtain the next span from other
peers if that span is needed for not downloaded yet. Also if the
peer maliciously requests a non existent block hash.
2018-05-09 14:03:07 +01:00
moneromooo-monero
ce63ab09db
blockchain: invalidate misc caches when popping blocks
...
Might be a bit heavy handed, but conservative.
2018-05-09 09:10:56 +01:00
moneromooo-monero
6f859e4328
cryptonote: make sure outPk setup always happens
2018-05-07 19:21:52 +01:00
stoffu
872cb4efd8
blockchain: pop top if block version disagrees with the ideal fork version
2018-05-06 20:50:46 +09:00
Thaer Khawaja
fa0839f2f5
Ensure m_timestamps has the correct number for computing difficulty.
2018-04-29 19:50:55 -07:00
Riccardo Spagni
2ab5b1a21f
Merge pull request #3683
...
dad10775
2018-04-28 16:57:36 +02:00
moneromooo-monero
6b13976330
blockchain: log in DEBUG when a block is found, and where
...
Eases up debugging
2018-04-23 11:43:12 +01:00
moneromooo-monero
ffeeefde60
speedup get_output_histogram for all amounts when min_count > 0
...
This skips the vast majority of "dust" output amounts with just
one instance on the chain. Clocks in at 0.15% of the original
time on testnet.
2018-04-23 10:54:28 +01:00
Thaer Khawaja
dad1077577
Only log an error if fork version is higher AND is not known.
2018-04-22 17:26:44 -07:00
Riccardo Spagni
a95461e76d
Merge pull request #3609
...
08343aba
2018-04-12 13:48:44 +02:00
Riccardo Spagni
226de8e928
Merge pull request #3530
...
eb59f7c5
2018-04-12 13:46:34 +02:00
Riccardo Spagni
5053f8f40b
Merge pull request #3502
...
11c933e1
2018-04-12 11:14:43 +02:00
moneromooo-monero
08343abaf4
tx_pool: fix loading with colliding key images
...
A key image may be present more than once if all but one of the
txes spending that key image are coming from blocks. When loading
a txpool from storage, we must load the one that's not from a
block first to avoid rejection
2018-04-11 15:27:56 +01:00
stoffu
eb59f7c563
cryptonote_tx_util: make destinations properly shuffled
2018-03-31 18:37:46 +09:00
stoffu
66a659bb03
blockchain: add scope guard to waiter for threaded txv1 verification
2018-03-30 19:22:32 +09:00
moneromooo-monero
11c933e137
fix lambda compile error on openbsd
2018-03-27 14:48:36 +01:00
Riccardo Spagni
dac3895ac1
update block hashes for checkpoints.dat
2018-03-24 08:36:10 +02:00
stoffu
3b941befae
core: add get_earliest_ideal_height_for_version()
2018-03-21 01:53:24 +09:00
moneromooo-monero
a6a54fa883
blockchain: cache difficulty for next block
...
Takes about 10 ms, which takes pretty much all of the get_info
RPC, which is called pretty often from wallets.
Also add a new lock so we don't need to lock the blockchain lock,
which will avoid blocking for a long time when calling the getinfo
RPC while syncing. Users of get_difficulty_for_next_block who need
the lock will have locked it already.
2018-03-19 09:05:40 +00:00
moneromooo-monero
b1398fff40
core: fix use of uninitialised data
2018-03-18 23:37:00 +00:00
moneromooo-monero
bb20f104ba
Move v7 fork to 1546000 to give more update time
2018-03-18 09:29:31 +00:00
Riccardo Spagni
83651630bc
Merge pull request #3418
...
20a00266
2018-03-17 16:51:47 +02:00
moneromooo-monero
20a002667c
blockchain: forbid bulletproof types before v8
...
They were already forbidden implicitely, but let's make that
explicit for robustness
2018-03-16 18:18:34 +00:00
Riccardo Spagni
432480fa42
Merge pull request #3414
...
524cbdc1
2018-03-16 18:09:34 +02:00
Riccardo Spagni
0f27fc57ac
Merge pull request #3336
...
57c0b1ed
2018-03-16 18:08:07 +02:00
moneromooo-monero
41f727ce42
add RPC to get a histogram of outputs of a given amount
2018-03-16 10:32:26 +00:00
stoffu
524cbdc1e2
blockchain: fix log message about per-kB fee
2018-03-16 10:43:19 +09:00
Dimitris Apostolou
57c0b1ed9f
Fix typos in various files
2018-03-15 18:25:38 +02:00
Jean Pierre Dudey
e1b526b371
Remove the Blockchain::get_all_known_block_ids function.
...
This function isn't used in the codebase.
Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2018-03-14 21:56:19 -04:00
stoffu
8705beaf51
keypair::generate: always require hw::device to avoid possible mistake
2018-03-14 21:00:16 +09:00
stoffu
27a196b126
device: untangle cyclic depenency
...
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
2018-03-14 21:00:15 +09:00
Riccardo Spagni
9a63fbcf83
Merge pull request #3371
...
84decbea
2018-03-14 13:37:25 +02:00
Riccardo Spagni
2e074e2ae7
Merge pull request #3358
...
978663d4
2018-03-14 13:36:47 +02:00
