anonimal
1bd962d9f9
wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)
2019-09-06 23:11:37 +00:00
moneromooo-monero
2ec455df1f
wallet: fix mismatch between two concepts of "balance"
...
One considers the blockchain, while the other considers the
blockchain and some recent actions, such as a recently created
transaction which spend some outputs, but isn't yet mined.
Typically, the "balance" command wants the latter, to reflect
the recent action, but things like proving ownership wants
the former.
This fixes a crash in get_reserve_proof, where a preliminary
check and the main code used two concepts of "balance".
2019-09-05 11:19:34 +00:00
moneromooo-monero
340774341f
wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments
...
Much easier to work with than the raw unlock_time field
2019-09-05 10:54:57 +00:00
luigi1111
a567e884b2
Merge pull request #5822
...
839fc62
reject setting lookahead major or minor to 0 (moneromoo-monero)
2019-09-04 09:39:07 -05:00
Lev Sizov
4ad191ffa9
Removed unused boost/value_init header
2019-09-02 14:38:29 +02:00
Jesus Ramirez
2cd4fd8972
Changed the use of boost:value_initialized for C++ list initializer
2019-09-02 14:16:29 +02:00
moneromooo-monero
1a367d6a22
simplewallet: lock console on inactivity
2019-08-28 19:01:48 +00:00
moneromooo-monero
83ca76435b
wallet_rpc_server: call deinit on exit
2019-08-28 15:59:33 +00:00
moneromooo-monero
21f6c80fcd
rpc: move a leftover light wallet RPC out of daemon RPC
2019-08-28 15:51:28 +00:00
luigi1111
8f6f674753
Merge pull request #5609
...
1dc3b1a
wallet: add --extra-entropy command line flag (moneromooo-monero)
2019-08-27 15:14:15 -05:00
luigi1111
3e80f44503
Merge pull request #5559
...
33e91e1
wallet, rpc: add a release field to get_version (moneromooo-monero)
2019-08-27 15:09:37 -05:00
moneromooo-monero
33e91e1a1e
wallet, rpc: add a release field to get_version
...
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
2019-08-26 19:28:25 +00:00
moneromooo-monero
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks
2019-08-24 14:46:31 +00:00
moneromooo-monero
894cc81e83
wallet2: fix cold signing losing tx keys
2019-08-23 16:38:20 +00:00
Tadeas Moravec
63186a01ce
Wallet: Option to export data to ASCII
...
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
2019-08-22 16:03:22 +02:00
stoffu
50813c103e
ringdb: fix bug in blackballing
2019-08-22 21:34:48 +09:00
moneromooo-monero
1dc3b1a516
wallet: add --extra-entropy command line flag
...
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
2019-08-22 11:12:57 +00:00
luigi1111
11ab328ce3
Merge pull request #5778
...
8703aa5
MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
2019-08-21 15:31:11 -05:00
luigi1111
1bd3f1a1fb
Merge pull request #5750
...
884df82
wallet: provide original address for outgoing transfers (xiphon)
2019-08-21 15:20:51 -05:00
luigi1111
65e937168e
Merge pull request #5722
...
8be5fea
simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
2019-08-21 15:08:10 -05:00
rbrunner7
8703aa59db
MMS: Use chans instead of normal addresses for auto-config
2019-08-20 19:55:31 +02:00
luigi1111
f205d28e96
Merge pull request #5727
...
7b9a420
Replace std::random_shuffle with std::shuffle (tomsmeding)
2019-08-19 17:31:39 -05:00
luigi1111
2da11baecc
Merge pull request #5718
...
c8709fe
wallet: do not print log settings when unset (moneromooo-monero)
7b18e83
unit_tests: check return values on test data parsing (moneromooo-monero)
2019-08-19 17:17:11 -05:00
moneromooo-monero
839fc6256b
reject setting lookahead major or minor to 0
2019-08-19 15:35:12 +00:00
luigi1111
12d08dcbf5
Merge pull request #5518
...
def703a
wallet_api: add multi destination tx support (selsta)
2019-08-17 15:24:02 -05:00
selsta
def703abec
wallet_api: add multi destination tx support
2019-08-16 16:23:12 +02:00
luigi1111
6b6593dad9
Merge pull request #5673
...
097cca5
wallet_api: catch getTxKey exception (ph4r05)
2019-08-15 17:21:26 -05:00
luigi1111
1a259a1c70
Merge pull request #5672
...
b2bfcab
wallet2: fix change subaddress mixup when sending pre rct outputs (moneromooo-monero)
2019-08-15 17:20:18 -05:00
luigi1111
739b02ef38
Merge pull request #5662
...
64fb0f8
device: tx_key caching fixed, store recovered txkey (ph4r05)
2019-08-15 17:19:12 -05:00
Tom Smeding
7b9a420787
Replace std::random_shuffle with std::shuffle
...
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-15 16:33:15 +02:00
luigi1111
2258551ef9
Merge pull request #5487
...
df83ed7
consensus: from v12, enforce >= 2 outputs (moneromooo-monero)
2019-08-14 15:26:55 -05:00
luigi1111
dd3b5ecb98
Merge pull request #5478
...
7d9b7fe
functional_tests: add validate_address tests (moneromooo-monero)
2019-08-14 15:23:31 -05:00
luigi1111
e37e263fcd
Merge pull request #4851
...
155475d
Add IPv6 support (KeeJef/tewinget)
2019-08-14 15:21:47 -05:00
Thomas Winget
155475d971
Add IPv6 support
...
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
2019-07-31 20:04:57 -04:00
moneromooo-monero
7d9b7fee43
functional_tests: add validate_address tests
2019-07-29 14:29:20 +00:00
Nejcraft
6da3561e2a
Fixed error preventing build of monero-gui
...
get_attribute expects 2 values instead of 1
2019-07-28 16:03:45 +02:00
luigi1111
c4071a00fb
Merge pull request #5600
...
dd58057
Remember RPC version on initial connect (hyc)
2019-07-24 14:29:10 -05:00
luigi1111
8ae2681e08
Merge pull request #5594
...
f074b6b
device: show address on device display (ph4r05)
2019-07-24 14:24:40 -05:00
luigi1111
8600b3c69d
Merge pull request #5576
...
577324a
wallet_manager: omit redundant disconnect, drop unused variable (xiphon)
2019-07-24 14:16:00 -05:00
luigi1111
b333513db7
Merge pull request #5534
...
4c66614
expose set/get walletcache attribute functionality in wallet api (selsta)
2019-07-24 14:09:58 -05:00
luigi1111
7138f9d347
Merge pull request #5514
...
e4d100b
wallet2: don't wait a day before using new version fees (moneromooo-monero)
2019-07-24 14:00:54 -05:00
luigi1111
407683a38c
Merge pull request #5513
...
bc94ba4
wallet: distinguish between empty and absent attributes (moneromooo-monero)
2019-07-24 13:59:19 -05:00
luigi1111
e3de4aa68b
Merge pull request #5502
...
25a7cfd
add a few checks where it seems appropriate (moneromooo-monero)
1a66a86
remove unused code (moneromooo-monero)
2019-07-24 13:57:06 -05:00
luigi1111
705fbcfda4
Merge pull request #5457
...
3b9ce45
wallet_rpc_server: remove unused variable (moneromooo-monero)
2019-07-24 13:51:18 -05:00
xiphon
884df82db3
wallet: provide original address for outgoing transfers
2019-07-10 13:39:18 +00:00
moneromooo-monero
3140a378da
wallet_rpc_server: fix get_bulk_payments with short payment ids
2019-07-09 14:39:44 +00:00
moneromooo-monero
8be5fea1de
simplewallet: optional all flag to export_outputs/export_key_images
2019-07-02 19:42:28 +00:00
moneromooo-monero
c8709fe52f
wallet: do not print log settings when unset
...
Coverity 199721
2019-07-01 15:17:30 +00:00
Dusan Klinec
097cca59c1
wallet_api: catch getTxKey exception
...
- getTxKey method throws an exception, e.g., when user declines txKey export
2019-06-19 12:09:49 +02:00
moneromooo-monero
b2bfcab618
wallet2: fix change subaddress mixup when sending pre rct outputs
2019-06-19 09:39:16 +00:00
Dusan Klinec
f074b6b571
device: show address on device display
...
- Trezor: support for device address display (subaddress, integrated address)
- Wallet::API support added
- Simplewallet:
- address device [<index>]
- address new <label> // shows address on device also
- integrated_address [device] <payment_id|address> // new optional "device" arg to display also on the device
2019-06-17 16:49:04 +02:00
Dusan Klinec
64fb0f872a
device: tx_key caching fixed, store recovered txkey
2019-06-17 14:53:39 +02:00
Howard Chu
dd58057126
Remember RPC version on initial connect
...
Don't keep asking for it on an intact connection
Wallet is too chatty over the wire
2019-06-02 09:31:50 +01:00
Riccardo Spagni
14d3295649
Merge pull request #5561
...
9bfa4c20
Fix allow any cert mode in wallet rpc when configured over rpc (Lee Clagett)
3544596f
Add ssl_options support to monerod's rpc mode. (Lee Clagett)
c9aaccf3
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works. (Lee Clagett)
2019-06-01 20:21:45 +02:00
xiphon
577324a954
wallet_manager: omit redundant disconnect, drop unused variable
2019-05-27 14:40:29 +00:00
Lee Clagett
9bfa4c20ca
Fix allow any cert mode in wallet rpc when configured over rpc
2019-05-22 00:15:14 -04:00
Lee Clagett
3544596f9f
Add ssl_options support to monerod's rpc mode.
2019-05-22 00:09:11 -04:00
Lee Clagett
c9aaccf346
Fix configuration bug; wallet2 --daemon-ssl-allow-any-cert now works.
2019-05-21 15:43:27 -04:00
moneromooo-monero
915f59e3c0
wallet: add unlock_time details to show_transfers
...
also add a note when receiving the tx, because the user
might not notice the "XXX blocks to unlock" in the balance.
2019-05-16 21:37:05 +00:00
luigi1111
1607419e38
Merge pull request #5538
...
615f287
wallet: fix certificate fingerprint length check (moneromooo-monero)
2019-05-14 16:02:59 -05:00
moneromooo-monero
615f287aec
wallet: fix certificate fingerprint length check
...
Fixed by crCr62U0
2019-05-11 13:05:06 +00:00
dsc
4c666141e3
expose set/get walletcache attribute functionality in wallet api
2019-05-10 19:24:45 +02:00
moneromooo-monero
46244dd08c
wallet_rpc_server: use original addresses in destinations in get_transfers
...
And add them for pending transfers, where they were missing
2019-05-10 14:44:13 +00:00
Riccardo Spagni
97cb1c9436
Merge pull request #5508
...
1c44e658
wallet2: reject standalone short payment IDs in monero: URI API (moneromooo-monero)
2019-05-07 17:35:28 +02:00
Riccardo Spagni
c20221f290
Merge pull request #5503
...
ccc1e311
wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
2019-05-07 17:34:16 +02:00
Riccardo Spagni
ebb1c03e8c
Merge pull request #5501
...
b4ca72dd
wallet2: fix infinite loop picking outputs in corner case (moneromooo-monero)
2019-05-07 17:32:33 +02:00
moneromooo-monero
e4d100b062
wallet2: don't wait a day before using new version fees
...
30 blocks should be more than enough to drain the txpool of
transactions made with the old fee scheme
2019-05-02 18:00:25 +00:00
moneromooo-monero
bc94ba4d14
wallet: distinguish between empty and absent attributes
2019-05-02 13:00:08 +00:00
Riccardo Spagni
77f9bfa4d5
Merge pull request #5493
...
5e0da6fb
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
2019-05-02 11:30:28 +02:00
Riccardo Spagni
52eb454d7b
Merge pull request #5491
...
98fb98f9
wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero)
9074c0d8
wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero)
968848a7
wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
2019-05-02 11:30:11 +02:00
Riccardo Spagni
efd2412e77
Merge pull request #5489
...
64983fce
wallet2: default to trying to keep 5 outputs of 2+ monero (moneromooo-monero)
2019-05-02 11:29:25 +02:00
moneromooo-monero
1c44e65863
wallet2: reject standalone short payment IDs in monero: URI API
2019-05-01 18:41:39 +00:00
moneromooo-monero
ccc1e311dc
wallet_rpc_server: reject standalone short payment id in address book
2019-04-30 21:07:37 +00:00
moneromooo-monero
1a66a86f94
remove unused code
2019-04-29 20:52:40 +00:00
moneromooo-monero
b4ca72dde9
wallet2: fix infinite loop picking outputs in corner case
...
If we have fewer outputs available on the chain than what we
require, but the output we're spending already has a ring,
it would loop picking outputs randomly, but never find enough.
Also tune logs for better debugging this kind of thing.
2019-04-29 10:02:20 +00:00
moneromooo-monero
5e0da6fb68
change SSL certificate fingerprint whitelisting from SHA1 to SHA-256
...
SHA1 is too close to bruteforceable
2019-04-26 11:37:15 +00:00
moneromooo-monero
98fb98f93f
wallet_rpc_server: adding missing return on error in set_daemon
2019-04-25 23:35:37 +00:00
moneromooo-monero
9074c0d8cf
wallet_rpc_server: return false on error in set_log_categories
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
moneromooo-monero
968848a77b
wallet_rpc_server: fix crash in validate_address if no wallet is loaded
...
Reported by SmajeNz0
2019-04-25 23:35:37 +00:00
Riccardo Spagni
581994b61c
Merge pull request #5486
...
4be18df3
tx_sanity_check: relax uniqueness check a bit (moneromooo-monero)
b386ae57
wallet2: add missing "sanity check failed" reason message (moneromooo-monero)
2019-04-24 22:41:40 +02:00
Riccardo Spagni
2e2ee3d823
Merge pull request #5485
...
c519d1df
wallet2: fix wrong change being recorded in sweep_all (moneromooo-monero)
2019-04-24 22:41:18 +02:00
Riccardo Spagni
edcb0cfff2
Merge pull request #5477
...
97e1c927
wallet: fix key image computation signaling to the device (Dusan Klinec)
2019-04-24 22:38:36 +02:00
moneromooo-monero
64983fcee4
wallet2: default to trying to keep 5 outputs of 2+ monero
...
In the case where previously a second unneeded output would be
added to a transaction. This should help *some* of the cases
where outputs are slowly being consolidated, leading to the
whole balance being locked when sending monero.
2019-04-24 12:25:43 +00:00
moneromooo-monero
df83ed74e4
consensus: from v12, enforce >= 2 outputs
2019-04-23 22:09:35 +00:00
moneromooo-monero
b386ae5725
wallet2: add missing "sanity check failed" reason message
2019-04-23 21:59:57 +00:00
moneromooo-monero
c519d1df34
wallet2: fix wrong change being recorded in sweep_all
...
leading to the sanity check triggering
2019-04-23 21:58:55 +00:00
Dusan Klinec
97e1c9278c
wallet: fix key image computation signaling to the device
2019-04-22 16:14:50 +02:00
moneromooo-monero
31a9aa83af
wallet_rpc_server: add block_height and frozen to incoming_transfers
2019-04-20 08:44:09 +00:00
Riccardo Spagni
950f79dc03
Merge pull request #5389
...
588e6700
simplewallet: fix output representation offset (moneromooo-monero)
35e0a968
wallet2: "output lineup" fake out selection (moneromooo-monero)
2019-04-18 22:01:51 +02:00
Riccardo Spagni
2e342d8df6
Merge pull request #5458
...
84047cb7
wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
2019-04-18 22:01:22 +02:00
moneromooo-monero
588e670089
simplewallet: fix output representation offset
2019-04-18 15:14:41 +00:00
moneromooo-monero
35e0a968bd
wallet2: "output lineup" fake out selection
...
Based on python code by sarang:
https://github.com/SarangNoether/skunkworks/blob/outputs/outputs/simulate.py
2019-04-18 15:14:38 +00:00
moneromooo-monero
84047cb729
wallet_rpc_server: add unlocked field to incoming_transfers output
2019-04-17 15:30:49 +00:00
moneromooo-monero
3b9ce453a9
wallet_rpc_server: remove unused variable
2019-04-17 11:25:33 +00:00
moneromooo-monero
7110226794
wallet_rpc_server: set suggested_confirmations_threshold for pool txes
2019-04-16 20:59:57 +00:00
moneromooo-monero
294e858d57
wallet_rpc_server: add set_log_level/set_log_categories
2019-04-16 20:50:15 +00:00
Riccardo Spagni
c8ce4217cf
Merge pull request #5445
...
b18f0b10
wallet: new --offline option (moneromooo-monero)
2019-04-16 22:46:53 +02:00
Riccardo Spagni
f376cd5605
Merge pull request #5446
...
7d79222f
daemon: remove debug info (moneromooo-monero)
8fec0f98
functional_tests: add sweep_single test (moneromooo-monero)
9880d61b
wallet_rpc_server: remove unused code (moneromooo-monero)
8a61b33d
rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero)
56508524
rpc: add relayed in get_transaction output (moneromooo-monero)
82e510f1
rpc: set default log category in core_rpc_server.h (moneromooo-monero)
2019-04-16 22:46:29 +02:00
Riccardo Spagni
1f01070a0c
Merge pull request #5434
...
ccb996af
rpc: new sanity check on relayed transactions (moneromooo-monero)
2019-04-16 22:41:40 +02:00
Riccardo Spagni
35b3d754e8
Merge pull request #5429
...
bcb86ae6
wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
2019-04-16 22:39:37 +02:00