025db3d2b4
Revert "Reject existing claimed blocks in sync mode"
2020-12-27 00:18:05 -05:00
609dbe6b92
Merge pull request #7154
...
cf7e1571daf0a25544
2020-12-26 13:40:36 -08:00
187b4d7521
Restrict duplicate keys in epee binary format
2020-12-20 03:47:32 +00:00
cf7e1571d3
protocol: reject claimed block hashes that already are in the chain
2020-12-17 02:54:02 +00:00
61b6e4cc67
Add aggressive restrictions to pre-handshake p2p buffer limit
2020-12-17 00:36:10 +00:00
4978f69d7a
Fix byte_stream::put_n
2020-12-14 14:45:24 -05:00
28e5e42986
Merge pull request #7110
...
d660f22ed
2020-12-10 17:41:59 -08:00
1e9483a2d5
Merge pull request #7009
...
7414e2bac
2020-12-10 17:34:50 -08:00
6bddd54f9d
Merge pull request #7003
...
08eb0949f
2020-12-10 17:33:50 -08:00
d660f22ed1
protocol: drop origin IP if a block fails to verify in sync mode
...
It would otherwise be possible for a peer to send bad blocks,
then disconnect and reconnect again, escaping bans
2020-12-10 21:59:18 +00:00
36d31ba0be
Merge pull request #7018
...
a9cd5d9
2020-11-29 01:58:13 -06:00
c041550ffa
Merge pull request #6973
...
be84f67
2020-11-29 01:54:43 -06:00
7a0334742a
Merge pull request #6937
...
8a282f6
2020-11-29 01:49:39 -06:00
450f1325ab
Merge pull request #6856
...
db70af1
2020-11-28 22:35:07 -06:00
a9cd5d914e
cryptonote_core: dandelion - use local height or median height if syncing
2020-11-25 01:27:42 +00:00
91fd634768
Better log message for unusable anon networks
2020-11-16 12:36:37 +00:00
be84f678b9
Switch to Dandelion++ fluff mode if no out connections for stem mode
2020-11-03 13:58:14 -05:00
8a282f64c9
Add RELINK_TARGETS, monero_add_target_no_relink and use monero_add_executable/monero_add_library where possible (mj-xmr)
...
Add monero_add_minimal_executable and use in tests
This is done in order not to have to relink targets, when just an .so changed, but not its interface.
2020-10-28 20:08:26 +01:00
08eb0949f3
Change to more efficient allocation strategy in byte_stream
2020-10-13 15:10:54 +00:00
249eae5f4a
Allow byte_stream->byte_slice conversion to shrink unused buffer space
2020-10-13 15:09:18 +00:00
a12a8174e0
Dandelion++: skip desynced peers in stem phase
2020-10-12 13:44:06 +00:00
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00
db70af1bbc
Unit Tests: Remove block reward upper bound size checks
...
Tests running after being compiled with `make debug-test` failed with
```
[ FAILED ] block_reward_and_current_block_weight.fails_on_huge_median_size
[ FAILED ] block_reward_and_current_block_weight.fails_on_huge_block_weight
```
With the introduction of the patch in
be82c40703 (diff-1a57d4e6013984c420da98d1adde0eafL113)
2020-10-03 02:32:17 +02:00
ee0b02d0db
Merge pull request #6757
...
6a37da8
2020-09-03 12:25:59 -05:00
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
44cd8a13ec
Merge pull request #6769
...
b641e0a2c
2020-08-27 12:05:16 -07:00
641b08c920
CLSAG optimizations
2020-08-27 12:44:04 +00:00
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
8cd1d6df8f
unit_tests: add ge_triple_scalarmult_base_vartime test
2020-08-27 12:44:01 +00:00
bad5d8d6f0
Merge pull request #6690
...
7175dcb10
2020-08-27 02:54:30 -07:00
b641e0a2c0
Add clear method to byte_stream
2020-08-17 21:30:34 -04:00
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption"
...
This reverts commit 921dd8dde5
2020-08-17 14:08:59 -05:00
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
10ad0d7eb2
Merge pull request #6718
...
85efc88c1
2020-08-16 12:53:50 -07:00
01b512f3a9
Merge pull request #6716
...
76c16822d
2020-08-16 12:52:21 -07:00
a08df6eb1b
Merge pull request #6603
...
4e2377995
2020-08-16 12:43:38 -07:00
009ca6fcd3
Merge pull request #6601
...
98c151ecb60627c9f2fe96e66eb
2020-08-16 12:43:11 -07:00
6d29ee6c52
Merge pull request #6493
...
921dd8dde
2020-08-16 12:39:59 -07:00
13549d590e
Merge pull request #6329
...
6bfcd3101
2020-08-16 12:37:43 -07:00
4e2377995d
Change ZMQ-JSON txextra to hex and remove unnecessary base fields
2020-08-14 23:01:00 +00:00
fe96e66ebe
Fix pruned tx for ZMQ's GetBlocksFast
2020-08-14 19:46:33 +00:00
921dd8dde5
Use domain-separated ChaCha20 for in-memory key encryption
2020-08-09 19:11:54 -04:00
6bfcd31015
Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.
2020-08-09 18:42:15 -04:00
c108c5e2f0
Merge pull request #6354
...
67ade8005
2020-08-09 06:42:49 -07:00
85efc88c1e
Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test
2020-07-23 03:36:05 -05:00
76c16822d0
wallet2_api: implement runtime proxy configuration
2020-07-20 13:45:12 +00:00
3ba6c7fd30
Merge pull request #6516
...
8656a8c9f
2020-07-19 03:34:28 -07:00
a0d179e528
Merge pull request #6512
...
5ef0607da
2020-07-19 03:32:59 -07:00
35e2520115
Merge pull request #6559
...
15538f7
2020-07-08 17:07:50 -05:00
15538f7e3f
ByteSlice: Fix persisting ptr to std::moved SSO buffer
...
The Bug:
1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_`
2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer)
3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
2020-05-20 10:13:58 +10:00
67ade80055
Add randomized delay when forwarding txes from i2p/tor -> ipv4/6
2020-05-15 07:57:35 +00:00
29e563bb1e
Fixed bugs for take_slice and byte_stream->byte_slice
2020-05-12 01:26:37 -04:00
8656a8c9ff
remove double includes
2020-05-11 13:53:17 +00:00
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
e5214a2ca2
Adding ZMQ/Pub support for txpool_add and chain_main events
2020-05-04 02:06:35 +00:00
06c81b6527
Merge pull request #6359
...
f9441c5
2020-04-21 08:38:21 -05:00
c26c93019a
Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON.
2020-04-11 04:12:11 +00:00
8185054db7
Merge pull request #6451
...
4ed60b6
2020-05-02 15:14:41 -05:00
a5cc613a68
Merge pull request #6460
...
f8b1480
2020-05-01 15:50:19 -05:00
f8b1480f95
unit_tests: fix gcc+ warning
2020-04-18 18:04:20 +03:00
4ed60b626a
Bulletproofs: verification speedup
2020-04-14 20:31:30 -04:00
d1f3d3376d
Merge pull request #6381
...
e719760
2020-04-04 13:12:31 -05:00
5757d99208
Merge pull request #6361
...
68a6507
2020-04-04 13:01:15 -05:00
0150a480fd
Merge pull request #6357
...
42a7a4d
2020-04-04 12:59:23 -05:00
cfc0f4a7fa
Merge pull request #6351
...
81c59435fcc23a3387f0e
2020-04-04 12:55:02 -05:00
bf70696a85
Merge pull request #6346
...
dbfa4f8
2020-04-04 12:50:17 -05:00
c4f75fe898
Merge pull request #6339
...
c61abf8
2020-04-04 12:47:31 -05:00
292e2d8f28
Merge pull request #6335
...
0078ce7
2020-04-04 12:42:50 -05:00
da99157462
Use byte_slice for sending zmq messages - removes data copy within zmq
2020-04-03 01:56:17 +00:00
096e2135dd
Merge pull request #6214
...
054b4c7
2020-03-31 13:32:55 -05:00
f9441c5759
Fixed string_ref usage bug in epee::from_hex::vector
2020-03-30 16:53:34 +00:00
0c29e17581
Fix network unit tests after epee changes
2020-03-28 13:30:22 -04:00
7d4a93fab3
Merge pull request #6285
...
d0641b42
2020-03-27 12:23:00 -07:00
02d887c2e5
Adding Dandelion++ support to public networks:
...
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
- Stem loops detected in tx_pool.cpp
- Embargo timeout for a blackhole attack during stem phase
2020-03-26 15:01:30 +00:00
054b4c7f41
protocol: request txpool contents when synced
...
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
2020-03-22 16:03:31 +00:00
aa93e38862
p2p: remove old debug commands
2020-03-20 22:09:44 -07:00
820ab9fdea
Merge pull request #6273
...
0f78b06e
2020-03-12 01:13:49 -07:00
e719760253
Fix receive order leakage with tx fluffing
2020-03-10 22:30:07 -04:00
5fcc23ae0a
Move hex->bin conversion to monero copyright files and with less includes
2020-03-09 05:23:59 +00:00
0f78b06e8c
Various improvements to the ZMQ JSON-RPC handling:
...
- Finding handling function in ZMQ JSON-RPC now uses binary search
- Temporary `std::vector`s in JSON output now use `epee::span` to
prevent allocations.
- Binary -> hex in JSON output no longer allocates temporary buffer
- C++ structs -> JSON skips intermediate DOM creation, and instead
write directly to an output stream.
2020-03-05 14:20:56 +00:00
944e8a4542
Merge pull request #6220
...
a9bdc6e4
2020-02-28 19:45:31 -08:00
e7997cd62a
Merge pull request #6202
...
02b80513
2020-02-28 19:33:21 -08:00
42a7a4dd32
daemon: auto public nodes - cache and prioritize most stable nodes
2020-02-28 08:06:43 +00:00
dbfa4f84ee
unit_tests: fix missing test names
2020-02-18 23:56:21 +00:00
c61abf87c0
remove empty statements
...
Cleaning up a little around the code base.
2020-02-17 11:55:15 -05:00
0078ce7fac
wipeable_string: split - treat CR, LF and Tabs as separators
2020-02-12 21:16:07 +00:00
dd8c6b1703
wallet: do not split integrated addresses in address book api
2020-01-26 00:03:53 +00:00
d0641b42fe
net: fix incorrect less operator for top/i2p addresses
2020-01-18 19:18:56 -08:00
dad4cf121e
Merge pull request #6018
...
dce6f053293780
2019-12-12 13:36:05 -06:00
02b8051339
unit_tests: remove invalid bulletproofs unit test
...
It was intended to check a case which is actually valid (0 gamma),
but was actually duplicating the bad amount test.
Reported by WhatDo_ on IRC.
2019-12-01 15:40:59 +00:00
68a6507c3f
Fixed bug in ZMQ JSON-RPC method field
2019-11-18 12:59:41 +00:00
dce6f055f9
rpc: Only show version string if it matches expected pattern
2019-11-12 18:19:24 -07:00
70c9cd3c9c
Change to Tx diffusion (Dandelion++ fluff) instead of flooding
2019-11-04 09:23:20 +00:00
a9bdc6e4c4
Improved performance for epee serialization:
...
- Removed copy of field names in binary deserialization
- Removed copy of array values in binary deserialization
- Removed copy of string values in json deserialization
- Removed unhelpful allocation in json string value parsing
- Removed copy of blob data on binary and json serialization
2019-11-04 01:46:41 +00:00
5d7ae2d279
Adding support for hidden (anonymity) txpool
2019-11-02 20:36:03 +00:00
1554a7768b
unit_tests: fix use after free
2019-10-30 18:40:20 +00:00
bb2bcf3521
Merge pull request #5972
...
9447e72
2019-10-22 10:52:14 -05:00
84ce43a239
Merge pull request #5966
...
be82c40
2019-10-22 10:08:32 -05:00
be82c40703
Support median block size > 4 GB
...
add a 128/64 division routine so we can use a > 32 bit median block
size in calculations
2019-10-21 10:41:07 +00:00
c65a221549
unit_tests: fix build after rename
2019-10-15 13:15:19 +00:00
d4d2b5c79a
p2p+rpc: don't skip p2p or rpc port bind failure by default
2019-10-13 13:27:46 +00:00
9447e7276d
cryptonote: add function to get weight from a pruned tx
...
The weight of the prunable data is deterministic from the
unpruned data, so it can be determined from a pruned tx
2019-10-11 12:08:36 +00:00
77afe91db6
unit_tests: fix build with boost 1.69
2019-10-11 01:16:03 +00:00
bf525793c7
Merge pull request #5915
...
8330e77
2019-10-08 15:55:03 -05:00
0e4ab6091c
Merge pull request #5960
...
ae34e1b
2019-10-08 14:49:57 -05:00
342e7f844f
Merge pull request #5921
...
2a7d915
2019-10-08 14:31:53 -05:00
ae34e1ba1c
unit_tests: fix ringdb unit tests
2019-10-04 21:11:46 +00:00
40501cc131
Merge pull request #5895
...
fdc00d0
2019-09-30 18:46:34 -05:00
8330e772f1
monerod can now sync from pruned blocks
...
If the peer (whether pruned or not itself) supports sending pruned blocks
to syncing nodes, the pruned version will be sent along with the hash
of the pruned data and the block weight. The original tx hashes can be
reconstructed from the pruned txes and theur prunable data hash. Those
hashes and the block weights are hashes and checked against the set of
precompiled hashes, ensuring the data we received is the original data.
It is currently not possible to use this system when not using the set
of precompiled hashes, since block weights can not otherwise be checked
for validity.
This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-27 00:10:37 +00:00
3f6096867d
Merge pull request #5916
...
7b076d5
2019-09-24 10:42:29 -05:00
06bee964a8
Merge pull request #5878
...
f9b3f6e
2019-09-24 10:10:28 -05:00
ee6e849627
Merge pull request #5877
...
2cd4fd84ad191f928f4be
2019-09-24 10:08:44 -05:00
7b076d5170
p2p: fix bans taking port into account
2019-09-16 22:45:45 +00:00
32f725d32f
Properly format multiline logs
...
As a side effect, colouring on Windows should now work
regardless of version
2019-09-16 16:58:01 +00:00
f9b3f6ef3b
Removed Berkeley DB and db switching logic
2019-09-16 16:18:05 +02:00
d663e1e3db
Merge pull request #5818
...
f91a06c
2019-09-14 13:25:14 -05:00
fdc00d0906
unit tests: replace global var with lambda returning static local var
...
Fixes assertion failure (curstate == 1) in random.c in debug mode
2019-09-09 11:44:06 +09:00
d0d76f771a
Merge pull request #5876
...
a5c7eeb
2019-09-08 20:10:44 -05:00
d91393daaf
Merge pull request #5856
...
f56e160
2019-09-08 20:06:04 -05:00
0e2fda5bf0
unit_tests: fix levin unit test on big endian
2019-09-04 14:53:58 +00:00
d046ca1db0
difficulty: fix check_hash on big endian
2019-09-04 14:53:53 +00:00
2cd4fd8972
Changed the use of boost:value_initialized for C++ list initializer
2019-09-02 14:16:29 +02:00
a5c7eebaea
unit_tests: fix build with CLANG 8 and boost 1.69
2019-08-30 11:43:03 +00:00
98af2e954b
Merge pull request #5793
...
bdfc63a3b24b1d
2019-08-29 14:36:41 -05:00
85014813cf
Merge pull request #5707
...
3a0451a
2019-08-28 02:22:00 -05:00
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
f56e160217
unit_tests: Fix uninitialized values
...
- Initialize the `hash` in the `get_block_hash()` function of the
`output_distribution` unit test explicitly, to silence `valgrind`
warnings.
2019-08-27 09:17:34 +02:00
a8e99198bf
Merge pull request #5748
...
b350726
2019-08-21 15:18:38 -05:00
f205d28e96
Merge pull request #5727
...
7b9a420
2019-08-19 17:31:39 -05:00
2da11baecc
Merge pull request #5718
...
c8709fe7b18e83
2019-08-19 17:17:11 -05:00
eeca5ca0c8
epee: support unicode in parsed strings
2019-08-16 17:06:03 +00:00
86ee631212
Merge pull request #5652
...
f81cb4f
2019-08-15 17:13:18 -05:00
7b9a420787
Replace std::random_shuffle with std::shuffle
...
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-08-15 16:33:15 +02:00
2a7d91523b
Fixed i2p/tor tx flooding bug (white noise disabled)
2019-07-29 12:27:00 +00:00
7fc76451a5
Merge pull request #5529
...
de27651
2019-07-24 14:06:11 -05:00
e3de4aa68b
Merge pull request #5502
...
25a7cfd1a66a86
2019-07-24 13:57:06 -05:00
f91a06c6d7
Dropping cppzmq dependency; adding some zmq utils
2019-07-22 06:37:16 +00:00
3b24b1d082
Added support for "noise" over I1P/Tor to mask Tx transmission.
2019-07-17 14:22:37 +00:00
bdfc63ae4d
Add ref-counted buffer byte_slice. Currently used for sending TCP data.
2019-07-16 16:30:35 +00:00
65c4004963
allow blocking whole subnets
2019-07-16 11:35:53 +00:00
b350726a5a
boost: update obsolete usage of endian API
2019-07-09 15:07:13 +00:00
c2238327d0
keccak: guard against misaligned memory accesses on ARM
...
The code generated is exactly the same as the direct access
one on x86_64
2019-07-04 22:13:16 +00:00
7b18e838ea
unit_tests: check return values on test data parsing
...
Won't trigger in practice, but you never know when that code changes
Coverity 199723, 199685
2019-07-01 15:17:30 +00:00
f81cb4f24b
unit_tests: add more leeway to the "same distribution" check
...
This is an inherently probabilistic check, which occasionally fails
for a matching distribution
2019-06-16 12:18:28 +00:00
dbecfe7d5d
unit_tests: make the density test a bit less stringent
...
It's an inherently random test
2019-05-20 10:42:50 +00:00
de27651f80
use crypto::rand instead of libc rand in a few tests
...
We don't need secure randomness here, but it should shut coverity up
2019-05-10 14:15:35 +00:00
f64f59627d
Merge pull request #5510
...
e9809382
2019-05-07 17:36:27 +02:00
97cb1c9436
Merge pull request #5508
...
1c44e658
2019-05-07 17:35:28 +02:00
2d04b0e500
Merge pull request #5499
...
a4c4a2d8
2019-05-07 17:31:45 +02:00
9d91301faa
Merge pull request #5496
...
0eb0d6b8
2019-05-07 17:30:27 +02:00
luigi1111
Alexander Blair
Lee Clagett
moneromooo-monero
xiphon
Howard Chu
mj-xmr
TheCharlatan
Sarang Noether
koe
Doyle
sumogr
SomaticFanatic
Aaron Hook
Interchained
Nathan Dorfman
Jesus Ramirez
stoffu
Matyas Liptak
Tom Smeding
Riccardo Spagni