Revert "Print stack trace upon exceptions"

Ain't nobody got time for link/cmake skullduggery.

This reverts commit fff238ec94.

tests/core_proxy/core_proxy.h

@@ -82,7 +82,7 @@ namespace tests
     bool on_idle(){return true;}
     bool find_blockchain_supplement(const std::list<crypto::hash>& qblock_ids, cryptonote::NOTIFY_RESPONSE_CHAIN_ENTRY::request& resp){return true;}
     bool handle_get_objects(cryptonote::NOTIFY_REQUEST_GET_OBJECTS::request& arg, cryptonote::NOTIFY_RESPONSE_GET_OBJECTS::request& rsp, cryptonote::cryptonote_connection_context& context){return true;}
-    cryptonote::blockchain_storage &get_blockchain_storage() { throw tools::runtime_error("Called invalid member function: please never call get_blockchain_storage on the TESTING class proxy_core."); }
+    cryptonote::blockchain_storage &get_blockchain_storage() { throw std::runtime_error("Called invalid member function: please never call get_blockchain_storage on the TESTING class proxy_core."); }
     bool get_test_drop_download() {return true;}
     bool get_test_drop_download_height() {return true;}
     bool prepare_handle_incoming_blocks(const std::list<cryptonote::block_complete_entry>  &blocks) { return true; }

tests/core_tests/chaingen.cpp

@@ -58,7 +58,7 @@ void test_generator::get_block_chain(std::vector<block_info>& blockchain, const
     auto it = m_blocks_info.find(curr);
     if (m_blocks_info.end() == it)
     {
-      throw tools::runtime_error("block hash wasn't found");
+      throw std::runtime_error("block hash wasn't found");
     }
 
     blockchain.push_back(it->second);
@@ -82,7 +82,7 @@ uint64_t test_generator::get_already_generated_coins(const crypto::hash& blk_id)
 {
   auto it = m_blocks_info.find(blk_id);
   if (it == m_blocks_info.end())
-    throw tools::runtime_error("block hash wasn't found");
+    throw std::runtime_error("block hash wasn't found");
 
   return it->second.already_generated_coins;
 }
@@ -323,7 +323,7 @@ bool init_output_indices(map_output_idx_t& outs, std::map<uint64_t, std::vector<
         BOOST_FOREACH(const crypto::hash &h, blk.tx_hashes) {
             const map_hash2tx_t::const_iterator cit = mtx.find(h);
             if (mtx.end() == cit)
-                throw tools::runtime_error("block contains an unknown tx hash");
+                throw std::runtime_error("block contains an unknown tx hash");
 
             vtx.push_back(cit->second);
         }
@@ -486,11 +486,11 @@ void fill_tx_sources_and_destinations(const std::vector<test_event_entry>& event
   destinations.clear();
 
   if (!fill_tx_sources(sources, events, blk_head, from, amount + fee, nmix))
-    throw tools::runtime_error("couldn't fill transaction sources");
+    throw std::runtime_error("couldn't fill transaction sources");
 
   tx_destination_entry de;
   if (!fill_tx_destination(de, to, amount))
-    throw tools::runtime_error("couldn't fill transaction destination");
+    throw std::runtime_error("couldn't fill transaction destination");
   destinations.push_back(de);
 
   tx_destination_entry de_change;
@@ -498,7 +498,7 @@ void fill_tx_sources_and_destinations(const std::vector<test_event_entry>& event
   if (0 < cache_back)
   {
     if (!fill_tx_destination(de_change, from, cache_back))
-      throw tools::runtime_error("couldn't fill transaction cache back destination");
+      throw std::runtime_error("couldn't fill transaction cache back destination");
     destinations.push_back(de_change);
   }
 }

tests/core_tests/chaingen.h

@@ -284,7 +284,7 @@ bool do_check_tx_verification_context(const cryptonote::tx_verification_context&
 {
   // Default block verification context check
   if (tvc.m_verifivation_failed)
-    throw tools::runtime_error("Transaction verification failed");
+    throw std::runtime_error("Transaction verification failed");
   return true;
 }
 //--------------------------------------------------------------------------
@@ -307,7 +307,7 @@ bool do_check_block_verification_context(const cryptonote::block_verification_co
 {
   // Default block verification context check
   if (bvc.m_verifivation_failed)
-    throw tools::runtime_error("Block verification failed");
+    throw std::runtime_error("Block verification failed");
   return true;
 }
 //--------------------------------------------------------------------------
@@ -621,7 +621,7 @@ inline bool do_replay_file(const std::string& filename)
         if (!tools::serialize_obj_to_file(events, filename)) \
         { \
             std::cout << concolor::magenta << "Failed to serialize data to file: " << filename << concolor::normal << std::endl; \
-            throw tools::runtime_error("Failed to serialize data to file"); \
+            throw std::runtime_error("Failed to serialize data to file"); \
         } \
     }
 

tests/core_tests/tx_validation.cpp

@@ -156,7 +156,7 @@ namespace
       }
     }
 
-    throw tools::runtime_error("invalid public key wasn't found");
+    throw std::runtime_error("invalid public key wasn't found");
     return crypto::public_key();
   }
 }

tests/net_load_tests/clt.cpp

@@ -37,7 +37,6 @@
 
 #include "gtest/gtest.h"
 
-#include "common/exception.h"
 #include "include_base_utils.h"
 #include "misc_language.h"
 #include "misc_log_ex.h"

tests/net_load_tests/srv.cpp

@@ -31,7 +31,6 @@
 #include <mutex>
 #include <thread>
 
-#include "common/exception.h"
 #include "include_base_utils.h"
 #include "misc_log_ex.h"
 #include "storages/levin_abstract_invoke2.h"

tests/unit_tests/ban.cpp

@@ -56,7 +56,7 @@ public:
   bool on_idle(){return true;}
   bool find_blockchain_supplement(const std::list<crypto::hash>& qblock_ids, cryptonote::NOTIFY_RESPONSE_CHAIN_ENTRY::request& resp){return true;}
   bool handle_get_objects(cryptonote::NOTIFY_REQUEST_GET_OBJECTS::request& arg, cryptonote::NOTIFY_RESPONSE_GET_OBJECTS::request& rsp, cryptonote::cryptonote_connection_context& context){return true;}
-  cryptonote::blockchain_storage &get_blockchain_storage() { throw tools::runtime_error("Called invalid member function: please never call get_blockchain_storage on the TESTING class test_core."); }
+  cryptonote::blockchain_storage &get_blockchain_storage() { throw std::runtime_error("Called invalid member function: please never call get_blockchain_storage on the TESTING class test_core."); }
   bool get_test_drop_download() const {return true;}
   bool get_test_drop_download_height() const {return true;}
   bool prepare_handle_incoming_blocks(const std::list<cryptonote::block_complete_entry>  &blocks) { return true; }

tests/unit_tests/epee_boosted_tcp_server.cpp

@@ -104,7 +104,7 @@ TEST(boosted_tcp_server, worker_threads_are_exception_resistant)
 
   // 2 theads, but 4 exceptions
   ASSERT_TRUE(srv.run_server(2, false));
-  ASSERT_TRUE(srv.async_call([&counter_incrementer]() { counter_incrementer(); throw tools::runtime_error("test 1"); }));
+  ASSERT_TRUE(srv.async_call([&counter_incrementer]() { counter_incrementer(); throw std::runtime_error("test 1"); }));
   ASSERT_TRUE(srv.async_call([&counter_incrementer]() { counter_incrementer(); throw std::string("test 2"); }));
   ASSERT_TRUE(srv.async_call([&counter_incrementer]() { counter_incrementer(); throw "test 3"; }));
   ASSERT_TRUE(srv.async_call([&counter_incrementer]() { counter_incrementer(); throw 4; }));

tests/unit_tests/mnemonics.cpp

@@ -27,7 +27,6 @@
 // THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "gtest/gtest.h"
-#include "common/exception.h"
 #include "mnemonics/electrum-words.h"
 #include "crypto/crypto.h"
 #include <stdlib.h>

tests/unit_tests/test_protocol_pack.cpp

@@ -30,7 +30,6 @@
 
 #include "gtest/gtest.h"
 
-#include "common/exception.h"
 #include "include_base_utils.h"
 #include "cryptonote_protocol/cryptonote_protocol_defs.h"
 #include "storages/portable_storage_template_helper.h"