rpc: error out from get_info if the proxied call errors out

Coverity 205410
This commit is contained in:
moneromooo-monero 2019-10-26 08:24:50 +00:00
parent fa16df9996
commit b90c4bc39e
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3

View file

@ -2226,8 +2226,7 @@ namespace cryptonote
//------------------------------------------------------------------------------------------------------------------------------ //------------------------------------------------------------------------------------------------------------------------------
bool core_rpc_server::on_get_info_json(const COMMAND_RPC_GET_INFO::request& req, COMMAND_RPC_GET_INFO::response& res, epee::json_rpc::error& error_resp, const connection_context *ctx) bool core_rpc_server::on_get_info_json(const COMMAND_RPC_GET_INFO::request& req, COMMAND_RPC_GET_INFO::response& res, epee::json_rpc::error& error_resp, const connection_context *ctx)
{ {
on_get_info(req, res, ctx); if (!on_get_info(req, res, ctx) || res.status != CORE_RPC_STATUS_OK)
if (res.status != CORE_RPC_STATUS_OK)
{ {
error_resp.code = CORE_RPC_ERROR_CODE_INTERNAL_ERROR; error_resp.code = CORE_RPC_ERROR_CODE_INTERNAL_ERROR;
error_resp.message = res.status; error_resp.message = res.status;