d0s3t3ch/wownero
1
0
Fork 0
mirror of https://git.wownero.com/wownero/wownero.git synced 2024-08-15 01:03:23 +00:00
Code Issues Projects Releases Wiki Activity

ringct: do not include bulletproof commitments in signed message

Browse source 
Those are not serialized, but are restored from the outPk masks,
so depending on what tries to validate the tx, those commitments
may or may not be filled with valid data at the time. The outPk
masks are already hashed as part of the rctSigBase field.
This commit is contained in:
moneromooo-monero 2017-12-09 15:22:24 +00:00
parent 782a84f7b4
commit 8d4469a0ac
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/ringct/rctSigs.cpp
View file

@ -347,11 +347,11 @@ namespace rct {
keyV kv; keyV kv;
if (rv.type == RCTTypeSimpleBulletproof || rv.type == RCTTypeFullBulletproof) if (rv.type == RCTTypeSimpleBulletproof || rv.type == RCTTypeFullBulletproof)
{ {
kv.reserve((6*2+10) * rv.p.bulletproofs.size()); kv.reserve((6*2+9) * rv.p.bulletproofs.size());
for (const auto &p: rv.p.bulletproofs) for (const auto &p: rv.p.bulletproofs)
{ {
for (size_t n = 0; n < p.V.size(); ++n) // V are not hashed as they're expanded from outPk.mask
kv.push_back(p.V[n]); // (and thus hashed as part of rctSigBase above)
kv.push_back(p.A); kv.push_back(p.A);
kv.push_back(p.S); kv.push_back(p.S);
kv.push_back(p.T1); kv.push_back(p.T1);