From f2e8348be0c91c903e68ef582cee687c52411722 Mon Sep 17 00:00:00 2001 From: Javier Smooth Date: Sun, 5 Apr 2015 04:01:00 -0700 Subject: [PATCH 1/2] triangular distribution to choose recent outputs more often for mixins --- src/cryptonote_core/blockchain_storage.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/cryptonote_core/blockchain_storage.cpp b/src/cryptonote_core/blockchain_storage.cpp index 136d4f1d1..a5e19b061 100644 --- a/src/cryptonote_core/blockchain_storage.cpp +++ b/src/cryptonote_core/blockchain_storage.cpp @@ -30,6 +30,7 @@ #include #include +#include #include #include @@ -1081,7 +1082,10 @@ bool blockchain_storage::get_random_outs_for_amounts(const COMMAND_RPC_GET_RANDO size_t try_count = 0; for(uint64_t j = 0; j != req.outs_count && try_count < up_index_limit;) { - size_t i = crypto::rand()%up_index_limit; + // triangular distribution over [a,b) with a=0, mode c=b=up_index_limit + uint64_t r = crypto::rand() % ((uint64_t)1 << 53); + double frac = std::sqrt((double)r / ((uint64_t)1 << 53)); + size_t i = (size_t)(frac*up_index_limit); if(used.count(i)) continue; bool added = add_out_to_get_random_outs(amount_outs, result_outs, amount, i); From 83ddc942c1629d67b9897ba8be8632035527c6fc Mon Sep 17 00:00:00 2001 From: Javier Smooth Date: Sun, 5 Apr 2015 04:39:09 -0700 Subject: [PATCH 2/2] handle unlikely rounding up after sqrt --- src/cryptonote_core/blockchain_storage.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cryptonote_core/blockchain_storage.cpp b/src/cryptonote_core/blockchain_storage.cpp index a5e19b061..d59fc7a58 100644 --- a/src/cryptonote_core/blockchain_storage.cpp +++ b/src/cryptonote_core/blockchain_storage.cpp @@ -1086,6 +1086,9 @@ bool blockchain_storage::get_random_outs_for_amounts(const COMMAND_RPC_GET_RANDO uint64_t r = crypto::rand() % ((uint64_t)1 << 53); double frac = std::sqrt((double)r / ((uint64_t)1 << 53)); size_t i = (size_t)(frac*up_index_limit); + // just in case rounding up to 1 occurs after sqrt + if (i == up_index_limit) + --i; if(used.count(i)) continue; bool added = add_out_to_get_random_outs(amount_outs, result_outs, amount, i);