From 9bde2dbfedf46fb40609fd9db43f5c8ee9283a9b Mon Sep 17 00:00:00 2001 From: Jeffrey Date: Sat, 19 Feb 2022 13:49:38 -0600 Subject: [PATCH] Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168 This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is. This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with --rpc-access-control-origins, but it is no longer mandatory. Original Issue: #8168 --- src/rpc/rpc_args.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/rpc/rpc_args.cpp b/src/rpc/rpc_args.cpp index 0966fb6d2..b2d019ae7 100644 --- a/src/rpc/rpc_args.cpp +++ b/src/rpc/rpc_args.cpp @@ -247,12 +247,6 @@ namespace cryptonote auto access_control_origins_input = command_line::get_arg(vm, arg.rpc_access_control_origins); if (!access_control_origins_input.empty()) { - if (!config.login) - { - LOG_ERROR(arg.rpc_access_control_origins.name << tr(" requires RPC server password --") << arg.rpc_login.name << tr(" cannot be empty")); - return boost::none; - } - std::vector access_control_origins; boost::split(access_control_origins, access_control_origins_input, boost::is_any_of(",")); std::for_each(access_control_origins.begin(), access_control_origins.end(), std::bind(&boost::trim, std::placeholders::_1, std::locale::classic()));