p2p: tone down "no incoming connections" warning to info if in peers is 0

Also add an info if not offline, since it weakens the network
This commit is contained in:
moneromooo-monero 2018-11-01 14:51:08 +00:00
parent 4cbb476cd1
commit 14a5c2068f
No known key found for this signature in database
GPG key ID: 686F07454D6CEFC3

View file

@ -1334,13 +1334,20 @@ namespace nodetool
template<class t_payload_net_handler> template<class t_payload_net_handler>
bool node_server<t_payload_net_handler>::check_incoming_connections() bool node_server<t_payload_net_handler>::check_incoming_connections()
{ {
if (m_offline || m_hide_my_port) if (m_offline)
return true; return true;
if (get_incoming_connections_count() == 0) if (get_incoming_connections_count() == 0)
{
if (m_hide_my_port || m_config.m_net_config.max_in_connection_count == 0)
{
MGINFO("Incoming connections disabled, enable them for full connectivity");
}
else
{ {
const el::Level level = el::Level::Warning; const el::Level level = el::Level::Warning;
MCLOG_RED(level, "global", "No incoming connections - check firewalls/routers allow port " << get_this_peer_port()); MCLOG_RED(level, "global", "No incoming connections - check firewalls/routers allow port " << get_this_peer_port());
} }
}
return true; return true;
} }
//----------------------------------------------------------------------------------- //-----------------------------------------------------------------------------------